From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: [PATCH 3/6] alpha: Unify the not-implemented system call entry name Date: Sat, 11 Aug 2018 03:45:53 +0100 Message-ID: <20180811024553.GF6515@ZenIV.linux.org.uk> References: <1531736638-15294-1-git-send-email-firoz.khan@linaro.org> <1531736638-15294-4-git-send-email-firoz.khan@linaro.org> <20180811000455.GC6515@ZenIV.linux.org.uk> <98937991-cefa-b7f3-11c3-12727b3159b1@twiddle.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <98937991-cefa-b7f3-11c3-12727b3159b1@twiddle.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: y2038-bounces@lists.linaro.org Sender: "Y2038" To: Richard Henderson Cc: linux-arch@vger.kernel.org, arnd@arndb.de, y2038@lists.linaro.org, linux-kernel@vger.kernel.org, ink@jurassic.park.msu.ru, deepa.kernel@gmail.com, linux-alpha@vger.kernel.org, Firoz Khan , mattst88@gmail.com List-Id: linux-arch.vger.kernel.org T24gRnJpLCBBdWcgMTAsIDIwMTggYXQgMDc6MzE6NTVQTSAtMDcwMCwgUmljaGFyZCBIZW5kZXJz b24gd3JvdGU6Cgo+ID4gKysrIGIvYXJjaC9hbHBoYS9rZXJuZWwvZW50cnkuUwo+ID4gQEAgLTQ3 Myw3ICs0NzMsNyBAQCBlbnRTeXM6Cj4gPiAgCWJuZSAgICAgJDMsIHN0cmFjZQo+ID4gIAliZXEJ JDQsIDFmCj4gPiAgCWxkcQkkMjcsIDAoJDUpCj4gPiAtMToJanNyCSQyNiwgKCQyNyksIGFscGhh X25pX3N5c2NhbGwKPiA+ICsxOglqc3IJJDI2LCAoJDI3KSwgc3lzX25pX3N5c2NhbGwKPiA+ICAJ bGRncAkkZ3AsIDAoJDI2KQo+ID4gIAlibHQJJDAsICRzeXNjYWxsX2Vycm9yCS8qIHRoZSBjYWxs IGZhaWxlZCAqLwo+ID4gIAlzdHEJJDAsIDAoJHNwKQo+IAo+IE9uY2UgdXBvbiBhIHRpbWUgSSBo YWQgYSBwYXRjaCB0byBtYWtlIHRoZSBoaW50Cj4gYmUgc3lzX2dldHRpbWVvZmRheSwgYXMgdGhl IG1vc3QgY29tbW9uIHN5c2NhbGwuCj4gRHVubm8gd2hhdCBoYXBwZW5lZCB0byB0aGF0LgoKTWln aHQgYXMgd2VsbC4uLiBwdHJhY2VkIGNhc2UgaGFzIGl0LCBub24tcHRyYWNlZCBkb2Vzbid0LgoK QlRXLCBzZWVpbmcgdGhhdCBpdCdzIHlvdXIgY29kZSAtIHdoeSB3YXMgdW5vcCB1c2VkIGluCmFs cGhhX25pX3N5c2NhbGw/ICBJIGRvbid0IHJlbWVtYmVyIHRoZSBydWxlcyByZSBwaXBlbGluZQpz dGFsbHM7IGlzIGl0IHRoYXQgc29tZSBlYXJsaWVyIHZhcmlhbnRzIHByZWZlciB1bm9wIHRvCm5v cCBpbiBzdWNoIHBsYWNlcz8gIEl0J3Mgbm90IHRoYXQgbWljcm9vcHRpbWl6aW5nIHRoYXQKb25l IG1ha2VzIGFueSBkaWZmZXJlbmNlLCBidXQganVzdCBvdXQgb2YgY3VyaW9zaXR5IC0Kd291bGQg c29tZXRoaW5nIGxpa2UKCWxkYSAgICAgJDAsIC1FTk9TWVMKCXN0cSAgICAgJHNwLCAwKCRzcCkJ Lyogc3AgIT0gMCAqLwoJcmV0CmRvIGp1c3QgYXMgd2VsbCB0aGVyZT8KX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWTIwMzggbWFpbGluZyBsaXN0ClkyMDM4 QGxpc3RzLmxpbmFyby5vcmcKaHR0cHM6Ly9saXN0cy5saW5hcm8ub3JnL21haWxtYW4vbGlzdGlu Zm8veTIwMzgK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zeniv.linux.org.uk ([195.92.253.2]:60734 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727093AbeHKFS3 (ORCPT ); Sat, 11 Aug 2018 01:18:29 -0400 Date: Sat, 11 Aug 2018 03:45:53 +0100 From: Al Viro Subject: Re: [PATCH 3/6] alpha: Unify the not-implemented system call entry name Message-ID: <20180811024553.GF6515@ZenIV.linux.org.uk> References: <1531736638-15294-1-git-send-email-firoz.khan@linaro.org> <1531736638-15294-4-git-send-email-firoz.khan@linaro.org> <20180811000455.GC6515@ZenIV.linux.org.uk> <98937991-cefa-b7f3-11c3-12727b3159b1@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <98937991-cefa-b7f3-11c3-12727b3159b1@twiddle.net> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Richard Henderson Cc: Firoz Khan , linux-alpha@vger.kernel.org, ink@jurassic.park.msu.ru, mattst88@gmail.com, y2038@lists.linaro.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, arnd@arndb.de, deepa.kernel@gmail.com Message-ID: <20180811024553.5acOzirfish4JoC0I8nyO1RgMCpnRJduyKc_92DMlEQ@z> On Fri, Aug 10, 2018 at 07:31:55PM -0700, Richard Henderson wrote: > > +++ b/arch/alpha/kernel/entry.S > > @@ -473,7 +473,7 @@ entSys: > > bne $3, strace > > beq $4, 1f > > ldq $27, 0($5) > > -1: jsr $26, ($27), alpha_ni_syscall > > +1: jsr $26, ($27), sys_ni_syscall > > ldgp $gp, 0($26) > > blt $0, $syscall_error /* the call failed */ > > stq $0, 0($sp) > > Once upon a time I had a patch to make the hint > be sys_gettimeofday, as the most common syscall. > Dunno what happened to that. Might as well... ptraced case has it, non-ptraced doesn't. BTW, seeing that it's your code - why was unop used in alpha_ni_syscall? I don't remember the rules re pipeline stalls; is it that some earlier variants prefer unop to nop in such places? It's not that microoptimizing that one makes any difference, but just out of curiosity - would something like lda $0, -ENOSYS stq $sp, 0($sp) /* sp != 0 */ ret do just as well there?