From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH] x86/mm: Simplify p[g4um]d_page() macros Date: Tue, 21 Aug 2018 07:20:00 +0200 Message-ID: <20180821052000.GB23615@kroah.com> References: <20180820203705.16212-1-andi@firstfloor.org> <20180820203705.16212-2-andi@firstfloor.org> <20180820220422.7qrayn7wivmejr24@two.firstfloor.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180820220422.7qrayn7wivmejr24@two.firstfloor.org> Sender: stable-owner@vger.kernel.org To: Andi Kleen Cc: Linus Torvalds , stable , Andi Kleen , Tom Lendacky , Alexander Potapenko , Andrey Ryabinin , Andrew Lutomirski , Arnd Bergmann , Borislav Petkov , Brijesh Singh , Dave Young , Dmitry Vyukov , Jonathan Corbet , Konrad Rzeszutek Wilk , Larry Woodman , Matt Fleming , "Michael S. Tsirkin" , Paolo Bonzini , Peter Zijlstra , Radim =?utf-8?B?S3LEjW3DocWZ?= List-Id: linux-arch.vger.kernel.org On Mon, Aug 20, 2018 at 03:04:23PM -0700, Andi Kleen wrote: > On Mon, Aug 20, 2018 at 02:57:39PM -0700, Linus Torvalds wrote: > > On Mon, Aug 20, 2018 at 1:37 PM Andi Kleen wrote: > > > > > > From: Andi Kleen > > > > > > Create a pgd_pfn() macro similar to the p[4um]d_pfn() macros and then > > > use the p[g4um]d_pfn() macros in the p[g4um]d_page() macros instead of > > > duplicating the code. > > > > When doing backports, _please_ explicitly specify which commit this is > > upstream too. > > Ok. > > > > > Also, the original upstream patch is credited to Tom Lendacky. > > Okay. > > > > > Or is there something I'm not seeing, and this is different from > > commit fd7e315988b7 ("x86/mm: Simplify p[g4um]d_page() macros")? > > No it's Tom's patch just ported to the older tree with some minor > changes. I just fat fingered it while doing the commit Ok, I've fixed this up by hand now, please be more careful next time. greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com ([66.111.4.25]:48351 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726175AbeHUIir (ORCPT ); Tue, 21 Aug 2018 04:38:47 -0400 Date: Tue, 21 Aug 2018 07:20:00 +0200 From: Greg KH Subject: Re: [PATCH] x86/mm: Simplify p[g4um]d_page() macros Message-ID: <20180821052000.GB23615@kroah.com> References: <20180820203705.16212-1-andi@firstfloor.org> <20180820203705.16212-2-andi@firstfloor.org> <20180820220422.7qrayn7wivmejr24@two.firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180820220422.7qrayn7wivmejr24@two.firstfloor.org> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Andi Kleen Cc: Linus Torvalds , stable , Andi Kleen , Tom Lendacky , Alexander Potapenko , Andrey Ryabinin , Andrew Lutomirski , Arnd Bergmann , Borislav Petkov , Brijesh Singh , Dave Young , Dmitry Vyukov , Jonathan Corbet , Konrad Rzeszutek Wilk , Larry Woodman , Matt Fleming , "Michael S. Tsirkin" , Paolo Bonzini , Peter Zijlstra , Radim =?utf-8?B?S3LEjW3DocWZ?= , Rik van Riel , Toshi Kani , kasan-dev , KVM list , linux-arch , "open list:DOCUMENTATION" , linux-efi , linux-mm , Ingo Molnar Message-ID: <20180821052000.6-cOZR0Jx_0Xg5zlyk1Ko6tfsdDNqhIUhRiFDrqpWX4@z> On Mon, Aug 20, 2018 at 03:04:23PM -0700, Andi Kleen wrote: > On Mon, Aug 20, 2018 at 02:57:39PM -0700, Linus Torvalds wrote: > > On Mon, Aug 20, 2018 at 1:37 PM Andi Kleen wrote: > > > > > > From: Andi Kleen > > > > > > Create a pgd_pfn() macro similar to the p[4um]d_pfn() macros and then > > > use the p[g4um]d_pfn() macros in the p[g4um]d_page() macros instead of > > > duplicating the code. > > > > When doing backports, _please_ explicitly specify which commit this is > > upstream too. > > Ok. > > > > > Also, the original upstream patch is credited to Tom Lendacky. > > Okay. > > > > > Or is there something I'm not seeing, and this is different from > > commit fd7e315988b7 ("x86/mm: Simplify p[g4um]d_page() macros")? > > No it's Tom's patch just ported to the older tree with some minor > changes. I just fat fingered it while doing the commit Ok, I've fixed this up by hand now, please be more careful next time. greg k-h