From: Tejun Heo <tj@kernel.org>
To: Alexander Pateenok <pateenoc@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Christoph Lameter <cl@linux.com>,
Dennis Zhou <dennisszhou@gmail.com>,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] percpu: cleanup PER_CPU_DEF_ATTRIBUTES macro
Date: Tue, 21 Aug 2018 08:56:11 -0700 [thread overview]
Message-ID: <20180821155611.GN3978217@devbig004.ftw2.facebook.com> (raw)
In-Reply-To: <20180821134030.lycgq7l7czetdngs@K55DR>
Hello,
On Tue, Aug 21, 2018 at 04:40:30PM +0300, Alexander Pateenok wrote:
> The macro is not used:
>
> $ grep -r PER_CPU_DEF_ATTRIBUTES
> include/linux/percpu-defs.h: __PCPU_ATTRS(sec) PER_CPU_DEF_ATTRIBUTES __weak \
> include/linux/percpu-defs.h: __PCPU_ATTRS(sec) PER_CPU_DEF_ATTRIBUTES \
> include/asm-generic/percpu.h:#ifndef PER_CPU_DEF_ATTRIBUTES
> include/asm-generic/percpu.h:#define PER_CPU_DEF_ATTRIBUTES
>
> It was added with b01e8dc34379 ("alpha: fix percpu build breakage") and
> removed in 2009 with b01e8dc34379..6088464cf1ae.
>
> Signed-off-by: Alexander Pateenok <pateenoc@gmail.com>
I'm not sure this is a meaningful cleanup, but then again, why not?
Can you please repost the patch to Andrew so that it can go through
-mm tree? Please feel free to add
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
next prev parent reply other threads:[~2018-08-21 15:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-21 13:40 [PATCH] percpu: cleanup PER_CPU_DEF_ATTRIBUTES macro Alexander Pateenok
2018-08-21 13:40 ` Alexander Pateenok
2018-08-21 15:56 ` Tejun Heo [this message]
2018-08-21 15:56 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180821155611.GN3978217@devbig004.ftw2.facebook.com \
--to=tj@kernel.org \
--cc=arnd@arndb.de \
--cc=cl@linux.com \
--cc=dennisszhou@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pateenoc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).