From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [RFC PATCH 2/2] mm: mmu_notifier fix for tlb_end_vma (build failures) Date: Fri, 24 Aug 2018 15:25:33 +0100 Message-ID: <20180824142532.GG11868@brain-police> References: <20180823084709.19717-1-npiggin@gmail.com> <20180823084709.19717-3-npiggin@gmail.com> <20180824130722.GA31409@roeck-us.net> <20180824131026.GB11868@brain-police> <20180824132419.GA9983@roeck-us.net> <20180824133427.GC11868@brain-police> <20180824135048.GF11868@brain-police> <7d0111f4-c369-43a8-72c6-1a7390cdebdd@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <7d0111f4-c369-43a8-72c6-1a7390cdebdd@roeck-us.net> Sender: linux-kernel-owner@vger.kernel.org To: Guenter Roeck Cc: Nicholas Piggin , Peter Zijlstra , torvalds@linux-foundation.org, luto@kernel.org, x86@kernel.org, bp@alien8.de, riel@surriel.com, jannh@google.com, ascannell@google.com, dave.hansen@intel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, David Miller , Martin Schwidefsky , Michael Ellerman , linux-arch@vger.kernel.org, Palmer Dabbelt , linux-riscv@lists.infradead.org List-Id: linux-arch.vger.kernel.org On Fri, Aug 24, 2018 at 07:06:51AM -0700, Guenter Roeck wrote: > On 08/24/2018 06:50 AM, Will Deacon wrote: > > >>-#include > >>+struct mmu_gather; > >> static inline void tlb_flush(struct mmu_gather *tlb) > >> { > >> flush_tlb_mm(tlb->mm); > > > >Bah, didn't spot the dereference so this won't work either. You basically > >just need to copy what I did for arm64 in d475fac95779. > > > > Yes, this seems to work. It doesn't really need "struct mmu_gather;" - > I assume that is included from elsewhere - but I added it to be safe. struct mmu_gather comes in via asm-generic/tlb.h. > Can you send a full patch, or do you want me to do it ? I'm evidently incapable of writing code today, so please go ahead :) Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:58020 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725985AbeHXSAe (ORCPT ); Fri, 24 Aug 2018 14:00:34 -0400 Date: Fri, 24 Aug 2018 15:25:33 +0100 From: Will Deacon Subject: Re: [RFC PATCH 2/2] mm: mmu_notifier fix for tlb_end_vma (build failures) Message-ID: <20180824142532.GG11868@brain-police> References: <20180823084709.19717-1-npiggin@gmail.com> <20180823084709.19717-3-npiggin@gmail.com> <20180824130722.GA31409@roeck-us.net> <20180824131026.GB11868@brain-police> <20180824132419.GA9983@roeck-us.net> <20180824133427.GC11868@brain-police> <20180824135048.GF11868@brain-police> <7d0111f4-c369-43a8-72c6-1a7390cdebdd@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7d0111f4-c369-43a8-72c6-1a7390cdebdd@roeck-us.net> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Guenter Roeck Cc: Nicholas Piggin , Peter Zijlstra , torvalds@linux-foundation.org, luto@kernel.org, x86@kernel.org, bp@alien8.de, riel@surriel.com, jannh@google.com, ascannell@google.com, dave.hansen@intel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, David Miller , Martin Schwidefsky , Michael Ellerman , linux-arch@vger.kernel.org, Palmer Dabbelt , linux-riscv@lists.infradead.org Message-ID: <20180824142533.yM5uV-px1zs-L_dlNtGjCfugXkelLdSz6NRKljb8PLA@z> On Fri, Aug 24, 2018 at 07:06:51AM -0700, Guenter Roeck wrote: > On 08/24/2018 06:50 AM, Will Deacon wrote: > > >>-#include > >>+struct mmu_gather; > >> static inline void tlb_flush(struct mmu_gather *tlb) > >> { > >> flush_tlb_mm(tlb->mm); > > > >Bah, didn't spot the dereference so this won't work either. You basically > >just need to copy what I did for arm64 in d475fac95779. > > > > Yes, this seems to work. It doesn't really need "struct mmu_gather;" - > I assume that is included from elsewhere - but I added it to be safe. struct mmu_gather comes in via asm-generic/tlb.h. > Can you send a full patch, or do you want me to do it ? I'm evidently incapable of writing code today, so please go ahead :) Will