From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH v5 10/16] x86/mce: enable Hygon support to MCE infrastructure Date: Wed, 5 Sep 2018 11:22:34 +0200 Message-ID: <20180905092234.GC2237@zn.tnic> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Pu Wen Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, thomas.lendacky@amd.com, pbonzini@redhat.com, tony.luck@intel.com, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-edac@vger.kernel.org List-Id: linux-arch.vger.kernel.org On Wed, Aug 29, 2018 at 08:44:54PM +0800, Pu Wen wrote: > Hygon machine check arch is similar to AMD family 17h. To enable the MCE > infrastructure support, add CPU vendor check for Hygon to share the code > path of AMD. > > Add hygon mce init function mce_hygon_feature_init() to minimize further > maintenance effort. > > Signed-off-by: Pu Wen > --- > arch/x86/include/asm/mce.h | 5 +++++ > arch/x86/kernel/cpu/mcheck/mce-severity.c | 3 ++- > arch/x86/kernel/cpu/mcheck/mce.c | 21 +++++++++++++++------ > 3 files changed, 22 insertions(+), 7 deletions(-) > > diff --git a/arch/x86/include/asm/mce.h b/arch/x86/include/asm/mce.h > index 3a17107..12357aa 100644 > --- a/arch/x86/include/asm/mce.h > +++ b/arch/x86/include/asm/mce.h > @@ -214,6 +214,11 @@ static inline void mce_amd_feature_init(struct cpuinfo_x86 *c) { } > static inline int umc_normaddr_to_sysaddr(u64 norm_addr, u16 nid, u8 umc, u64 *sys_addr) { return -EINVAL; }; > #endif > > +static inline void mce_hygon_feature_init(struct cpuinfo_x86 *c) > +{ > + return mce_amd_feature_init(c); > +} > + What happens if CONFIG_X86_MCE_AMD=n ? In general, since you're using AMD code, you need to make CPU_SUP_HYGON depend on a bunch of AMD config items like CONFIG_X86_MCE_AMD, CONFIG_CPU_SUP_AMD, CONFIG_AMD_NB,... Audit your code and see what other config items need to be selected. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.skyhub.de ([5.9.137.197]:54576 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725862AbeIENwM (ORCPT ); Wed, 5 Sep 2018 09:52:12 -0400 Date: Wed, 5 Sep 2018 11:22:34 +0200 From: Borislav Petkov Subject: Re: [PATCH v5 10/16] x86/mce: enable Hygon support to MCE infrastructure Message-ID: <20180905092234.GC2237@zn.tnic> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Pu Wen Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, thomas.lendacky@amd.com, pbonzini@redhat.com, tony.luck@intel.com, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-edac@vger.kernel.org Message-ID: <20180905092234._Y9poBiMyEp2Kz6nXv7tC29c0grrv909Fq73Yl5T4j0@z> On Wed, Aug 29, 2018 at 08:44:54PM +0800, Pu Wen wrote: > Hygon machine check arch is similar to AMD family 17h. To enable the MCE > infrastructure support, add CPU vendor check for Hygon to share the code > path of AMD. > > Add hygon mce init function mce_hygon_feature_init() to minimize further > maintenance effort. > > Signed-off-by: Pu Wen > --- > arch/x86/include/asm/mce.h | 5 +++++ > arch/x86/kernel/cpu/mcheck/mce-severity.c | 3 ++- > arch/x86/kernel/cpu/mcheck/mce.c | 21 +++++++++++++++------ > 3 files changed, 22 insertions(+), 7 deletions(-) > > diff --git a/arch/x86/include/asm/mce.h b/arch/x86/include/asm/mce.h > index 3a17107..12357aa 100644 > --- a/arch/x86/include/asm/mce.h > +++ b/arch/x86/include/asm/mce.h > @@ -214,6 +214,11 @@ static inline void mce_amd_feature_init(struct cpuinfo_x86 *c) { } > static inline int umc_normaddr_to_sysaddr(u64 norm_addr, u16 nid, u8 umc, u64 *sys_addr) { return -EINVAL; }; > #endif > > +static inline void mce_hygon_feature_init(struct cpuinfo_x86 *c) > +{ > + return mce_amd_feature_init(c); > +} > + What happens if CONFIG_X86_MCE_AMD=n ? In general, since you're using AMD code, you need to make CPU_SUP_HYGON depend on a bunch of AMD config items like CONFIG_X86_MCE_AMD, CONFIG_CPU_SUP_AMD, CONFIG_AMD_NB,... Audit your code and see what other config items need to be selected. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.