From: Borislav Petkov <bp@alien8.de>
To: Pu Wen <puwen@hygon.cn>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
x86@kernel.org, thomas.lendacky@amd.com, pbonzini@redhat.com,
tony.luck@intel.com, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, linux-edac@vger.kernel.org
Subject: Re: [PATCH v5 10/16] x86/mce: enable Hygon support to MCE infrastructure
Date: Thu, 6 Sep 2018 14:29:56 +0200 [thread overview]
Message-ID: <20180906122956.GF10768@zn.tnic> (raw)
In-Reply-To: <634f371e-1a2d-5b23-c9b0-5f32a8ee4cee@hygon.cn>
On Thu, Sep 06, 2018 at 07:40:52PM +0800, Pu Wen wrote:
> The first is the compilation test. Test the kernel with both MCE selected
> and unselected to see if is the compiling process successful or not.
This is a kernel compile test - it has nothing to do with actual machine
testing.
> The other test is functionality test. For example, during the MCE BIOS
> development, to see if the MCE functions OK, it may need to select and
> unselect MCE in kernel for double checking.
Say what now?! What testing do you do if you boot a kernel which doesn't
even use the functionality you're testing?!
> Actually in normal use scenario and in real product the MCE should be
> always selected.
It better be!
> To ensure this, I think there are two ways as below:
> - Select X86_MCE_AMD in CPU_SUP_HYGON config entry, it also cater to the
> first test scenario, but meanwhile lacks flexibility.
> - The linux distros(Ubuntu, CentOS, etc) ensure that X86_MCE_AMD is
> selected to the default config file, and indeed they do.
> Which way is better?
The first way but change that dependency to CPU_SUP_AMD because there
are people building their own kernels and don't run distro configs. And
you need CPU_SUP_AMD because you're using their code.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2018-09-06 12:29 UTC|newest]
Thread overview: 98+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-29 12:42 [PATCH v5 00/16] Add support for Hygon Dhyana Family 18h processor Pu Wen
2018-08-29 12:42 ` Pu Wen
2018-08-29 12:42 ` [PATCH v5 01/16] x86/cpu: create Dhyana init file and register new cpu_dev to system Pu Wen
2018-08-29 12:42 ` Pu Wen
2018-08-29 19:35 ` Andi Kleen
2018-08-29 19:35 ` Andi Kleen
2018-08-30 17:40 ` Pu Wen
2018-08-30 17:40 ` Pu Wen
2018-08-30 12:35 ` Borislav Petkov
2018-08-30 12:35 ` Borislav Petkov
2018-08-30 18:02 ` Pu Wen
2018-08-30 18:02 ` Pu Wen
2018-08-29 12:43 ` [PATCH v5 02/16] x86/cache: get cache size/leaves and setup cache cpumap for Dhyana Pu Wen
2018-08-29 12:43 ` Pu Wen
2018-09-03 9:57 ` Borislav Petkov
2018-09-03 9:57 ` Borislav Petkov
2018-09-03 12:59 ` Pu Wen
2018-09-03 12:59 ` Pu Wen
2018-08-29 12:43 ` [PATCH v5 03/16] x86/mtrr: get MTRR number and support TOP_MEM2 Pu Wen
2018-08-29 12:43 ` Pu Wen
2018-09-03 19:04 ` Borislav Petkov
2018-09-03 19:04 ` Borislav Petkov
2018-09-04 3:02 ` Pu Wen
2018-09-04 3:02 ` Pu Wen
2018-09-04 8:02 ` Borislav Petkov
2018-09-04 8:02 ` Borislav Petkov
2018-09-04 12:43 ` Pu Wen
2018-09-04 12:43 ` Pu Wen
2018-08-29 12:43 ` [PATCH v5 04/16] x86/smpboot: smp init nodelay and no flush caches before sleep Pu Wen
2018-08-29 12:43 ` Pu Wen
2018-09-04 9:15 ` Borislav Petkov
2018-09-04 9:15 ` Borislav Petkov
2018-08-29 12:43 ` [PATCH v5 05/16] x86/pmu: enable Hygon support to PMU infrastructure Pu Wen
2018-08-29 12:43 ` Pu Wen
2018-09-04 10:48 ` Borislav Petkov
2018-09-04 10:48 ` Borislav Petkov
2018-09-04 13:32 ` Pu Wen
2018-09-04 13:32 ` Pu Wen
2018-08-29 12:44 ` [PATCH v5 06/16] x86/nops: init ideal_nops for Hygon Pu Wen
2018-08-29 12:44 ` Pu Wen
2018-09-04 14:01 ` Borislav Petkov
2018-09-04 14:01 ` Borislav Petkov
2018-08-29 12:44 ` [PATCH v5 07/16] x86/pci: add Hygon PCI vendor and northbridge support Pu Wen
2018-08-29 12:44 ` Pu Wen
2018-09-04 14:52 ` Borislav Petkov
2018-09-04 14:52 ` Borislav Petkov
2018-09-04 15:45 ` Pu Wen
2018-09-04 15:45 ` Pu Wen
2018-09-04 16:03 ` Borislav Petkov
2018-09-04 16:03 ` Borislav Petkov
2018-08-29 12:44 ` [PATCH v5 08/16] x86/apic: add modern APIC support for Hygon Pu Wen
2018-08-29 12:44 ` Pu Wen
2018-09-04 18:33 ` Borislav Petkov
2018-09-04 18:33 ` Borislav Petkov
2018-09-05 8:08 ` Pu Wen
2018-09-05 8:08 ` Pu Wen
2018-08-29 12:44 ` [PATCH v5 09/16] x86/bugs: add lfence mitigation to spectre v2 and no meltdown " Pu Wen
2018-08-29 12:44 ` Pu Wen
2018-09-05 9:13 ` Borislav Petkov
2018-09-05 9:13 ` Borislav Petkov
2018-09-05 10:40 ` Pu Wen
2018-09-05 10:40 ` Pu Wen
2018-08-29 12:44 ` [PATCH v5 10/16] x86/mce: enable Hygon support to MCE infrastructure Pu Wen
2018-08-29 12:44 ` Pu Wen
2018-09-05 9:22 ` Borislav Petkov
2018-09-05 9:22 ` Borislav Petkov
2018-09-05 12:59 ` Pu Wen
2018-09-05 12:59 ` Pu Wen
2018-09-05 13:15 ` Borislav Petkov
2018-09-05 13:15 ` Borislav Petkov
2018-09-06 3:52 ` Pu Wen
2018-09-06 3:52 ` Pu Wen
2018-09-06 8:39 ` Borislav Petkov
2018-09-06 8:39 ` Borislav Petkov
2018-09-06 11:40 ` Pu Wen
2018-09-06 11:40 ` Pu Wen
2018-09-06 12:29 ` Borislav Petkov [this message]
2018-09-06 12:29 ` Borislav Petkov
2018-09-06 15:47 ` Pu Wen
2018-09-06 15:47 ` Pu Wen
2018-08-29 12:45 ` [PATCH v5 11/16] x86/kvm: enable Hygon support to KVM infrastructure Pu Wen
2018-08-29 12:45 ` Pu Wen
2018-09-05 10:30 ` Borislav Petkov
2018-09-05 10:30 ` Borislav Petkov
2018-08-29 12:45 ` [PATCH v5 12/16] x86/xen: enable Hygon support to Xen Pu Wen
2018-08-29 12:45 ` Pu Wen
2018-08-29 12:45 ` [PATCH v5 13/16] driver/acpi: enable Hygon support to ACPI driver Pu Wen
2018-08-29 12:45 ` Pu Wen
2018-08-29 12:45 ` [PATCH v5 14/16] driver/cpufreq: enable Hygon support to cpufreq driver Pu Wen
2018-08-29 12:45 ` Pu Wen
2018-08-29 12:45 ` [PATCH v5 15/16] driver/edac: enable Hygon support to AMD64 EDAC driver Pu Wen
2018-08-29 12:45 ` Pu Wen
2018-09-05 10:44 ` Borislav Petkov
2018-09-05 10:44 ` Borislav Petkov
2018-09-05 13:03 ` Pu Wen
2018-09-05 13:03 ` Pu Wen
2018-08-29 12:45 ` [PATCH v5 16/16] tools/cpupower: enable Hygon support to cpupower tool Pu Wen
2018-08-29 12:45 ` Pu Wen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180906122956.GF10768@zn.tnic \
--to=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=puwen@hygon.cn \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).