From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Will Deacon <will.deacon@arm.com>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
stern@rowland.harvard.edu, andrea.parri@amarulasolutions.com,
peterz@infradead.org, boqun.feng@gmail.com, npiggin@gmail.com,
dhowells@redhat.com, j.alglave@ucl.ac.uk, luc.maranget@inria.fr,
akiyks@gmail.com, mingo@kernel.org
Subject: Re: [PATCH RFC tools/memory-model] Add litmus-test naming scheme
Date: Thu, 6 Sep 2018 08:13:36 -0700 [thread overview]
Message-ID: <20180906151336.GR4225@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180906135218.GA5212@arm.com>
On Thu, Sep 06, 2018 at 02:52:18PM +0100, Will Deacon wrote:
> On Wed, Sep 05, 2018 at 05:01:17PM -0700, Paul E. McKenney wrote:
> > On Tue, May 29, 2018 at 09:17:13PM +0100, Will Deacon wrote:
> > > On Tue, May 29, 2018 at 05:11:07AM -0700, Paul E. McKenney wrote:
> > > > On Tue, May 29, 2018 at 10:30:50AM +0100, Will Deacon wrote:
> > > > > Hi Paul,
> > > > >
> > > > > On Fri, May 25, 2018 at 12:10:20PM -0700, Paul E. McKenney wrote:
> > > > > > This commit documents the scheme used to generate the names for the
> > > > > > litmus tests.
> > > > > >
> > > > > > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> > > > > > ---
> > > > > > README | 136 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
> > > > > > 1 file changed, 135 insertions(+), 1 deletion(-)
> > > > >
> > > > > Whilst I think documentation like this is extremely important for users,
> > > > > this feels like it's documenting how to drive parts of diy and I'm not
> > > > > convinced that it belongs in the kernel source tree as long as the projects
> > > > > remain separate.
> > > > >
> > > > > Why not contribute this to the herdtools7 documentation, then just reference
> > > > > that from here? That would also be helpful for other people interested in
> > > > > memory models, but perhaps not interested in Linux (assuming such people
> > > > > exist ;).
> > > >
> > > > We would still need at least a pointer from the Linux kernel to that
> > > > documentation, but I am happy either way. We probably need examples of
> > > > the common cases, but probably not a full exposition of all the available
> > > > herd7 edges.
> > >
> > > Completely agreed.
> > >
> > > > Should this be in the herdtools7 documentation, or as added detail
> > > > from a variation on the "diyone7 -bell linux-kernel.bell -show edges"
> > > > command? If the latter, I suppose that the ones coming from the .bell
> > > > file might simply be labelled as such.
> > >
> > > Many of the edges aren't specific to the Linux kernel, so I think they
> > > should be part of the diyone7 documentation. We could then describe only
> > > the additional edges added by the kernel memory model (e.g. "Once") in
> > > the kernel documentation.
> >
> > And there are a -lot- of them, and they are likely to change going
> > forward, both in herd7 and in linux-kernel.bell. How about if I give
> > examples and say where they are from and how to get a list, as in the
> > following --squash commit to be merged with the orginal?
>
> Sure, that looks much easier to maintain. With that, you can add my ack:
>
> Acked-by: Will Deacon <will.deacon@arm.com>
Applied, thank you!
And the lkmm branch has finally been updated to indicate the three
commits that have acks/reviews and thus that appear ready for the
next merge window, give or take the ongoing discussions.
Thanx, Paul
next prev parent reply other threads:[~2018-09-06 15:13 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-25 19:10 [PATCH RFC tools/memory-model] Add litmus-test naming scheme Paul E. McKenney
2018-05-25 19:10 ` Paul E. McKenney
2018-05-28 11:20 ` Andrea Parri
2018-05-28 11:20 ` Andrea Parri
2018-05-28 21:48 ` Paul E. McKenney
2018-05-28 21:48 ` Paul E. McKenney
2018-05-29 9:33 ` Andrea Parri
2018-05-29 9:33 ` Andrea Parri
2018-05-29 12:19 ` Paul E. McKenney
2018-05-29 12:19 ` Paul E. McKenney
2018-05-29 12:32 ` Andrea Parri
2018-05-29 12:32 ` Andrea Parri
2018-05-29 9:30 ` Will Deacon
2018-05-29 9:30 ` Will Deacon
2018-05-29 12:11 ` Paul E. McKenney
2018-05-29 12:11 ` Paul E. McKenney
2018-05-29 20:17 ` Will Deacon
2018-05-29 20:17 ` Will Deacon
2018-09-06 0:01 ` Paul E. McKenney
2018-09-06 0:01 ` Paul E. McKenney
2018-09-06 13:52 ` Will Deacon
2018-09-06 13:52 ` Will Deacon
2018-09-06 15:13 ` Paul E. McKenney [this message]
2018-09-06 15:13 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180906151336.GR4225@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=akiyks@gmail.com \
--cc=andrea.parri@amarulasolutions.com \
--cc=boqun.feng@gmail.com \
--cc=dhowells@redhat.com \
--cc=j.alglave@ucl.ac.uk \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luc.maranget@inria.fr \
--cc=mingo@kernel.org \
--cc=npiggin@gmail.com \
--cc=peterz@infradead.org \
--cc=stern@rowland.harvard.edu \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).