From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guo Ren Subject: Re: [PATCH V3 17/26] csky: Misc headers Date: Fri, 7 Sep 2018 16:08:41 +0800 Message-ID: <20180907080840.GA22852@guoren> References: <66335e5f59c186b291f8c3c98c9dadbd61d0cd3e.1536138304.git.ren_guo@c-sky.com> <20180907051747.GC13356@guoren-Inspiron-7460> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Arnd Bergmann Cc: linux-arch , Linux Kernel Mailing List , Thomas Gleixner , Daniel Lezcano , Jason Cooper , c-sky_gcc_upstream@c-sky.com, gnu-csky@mentor.com, Thomas Petazzoni , wbx@uclibc-ng.org, Greentime Hu List-Id: linux-arch.vger.kernel.org On Fri, Sep 07, 2018 at 10:01:03AM +0200, Arnd Bergmann wrote: > On Fri, Sep 7, 2018 at 7:17 AM Guo Ren wrote: > > > > On Thu, Sep 06, 2018 at 04:16:30PM +0200, Arnd Bergmann wrote: > > > On Wed, Sep 5, 2018 at 2:08 PM Guo Ren wrote: > > > > > > > diff --git a/arch/csky/boot/dts/qemu.dts b/arch/csky/boot/dts/qemu.dts > > > > new file mode 100644 > > > > index 0000000..d36e4cd > > > > --- /dev/null > > > > +++ b/arch/csky/boot/dts/qemu.dts > > > > @@ -0,0 +1,77 @@ > > > > +/dts-v1/; > > > > +/ { > > > > + compatible = "csky,qemu"; > > > > + #address-cells = <1>; > > > > + #size-cells = <1>; > > > > + interrupt-parent = <&intc>; > > > > > > Ideally, qemu would supply a dtb file that matches the current configuration, > > > as we do for instance on the ARM 'virt' machine. This allows you > > > much more flexibility in running all kinds of options, as well as extending > > > qemu later with new features. > > So, I should remove qemu.dts in next version patch? > > It's up to you really. If you won't have a version of qemu that can do this > by itself, it may make sense to keep it around for a while. You might > want to include the version of your current qemu port is based on > qemu-2.x but not upstream, you could include a qemu-2.x.dts file > here, and have the future 3.x port provide its own. Ok, thx for the tips. Guo Ren From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp2200-217.mail.aliyun.com ([121.197.200.217]:47606 "EHLO smtp2200-217.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726444AbeIGMsi (ORCPT ); Fri, 7 Sep 2018 08:48:38 -0400 Date: Fri, 7 Sep 2018 16:08:41 +0800 From: Guo Ren Subject: Re: [PATCH V3 17/26] csky: Misc headers Message-ID: <20180907080840.GA22852@guoren> References: <66335e5f59c186b291f8c3c98c9dadbd61d0cd3e.1536138304.git.ren_guo@c-sky.com> <20180907051747.GC13356@guoren-Inspiron-7460> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Arnd Bergmann Cc: linux-arch , Linux Kernel Mailing List , Thomas Gleixner , Daniel Lezcano , Jason Cooper , c-sky_gcc_upstream@c-sky.com, gnu-csky@mentor.com, Thomas Petazzoni , wbx@uclibc-ng.org, Greentime Hu Message-ID: <20180907080841.PnkIcImaJaIIgow41Hkm8LXWU6QtBTX5R1XySCNGa5w@z> On Fri, Sep 07, 2018 at 10:01:03AM +0200, Arnd Bergmann wrote: > On Fri, Sep 7, 2018 at 7:17 AM Guo Ren wrote: > > > > On Thu, Sep 06, 2018 at 04:16:30PM +0200, Arnd Bergmann wrote: > > > On Wed, Sep 5, 2018 at 2:08 PM Guo Ren wrote: > > > > > > > diff --git a/arch/csky/boot/dts/qemu.dts b/arch/csky/boot/dts/qemu.dts > > > > new file mode 100644 > > > > index 0000000..d36e4cd > > > > --- /dev/null > > > > +++ b/arch/csky/boot/dts/qemu.dts > > > > @@ -0,0 +1,77 @@ > > > > +/dts-v1/; > > > > +/ { > > > > + compatible = "csky,qemu"; > > > > + #address-cells = <1>; > > > > + #size-cells = <1>; > > > > + interrupt-parent = <&intc>; > > > > > > Ideally, qemu would supply a dtb file that matches the current configuration, > > > as we do for instance on the ARM 'virt' machine. This allows you > > > much more flexibility in running all kinds of options, as well as extending > > > qemu later with new features. > > So, I should remove qemu.dts in next version patch? > > It's up to you really. If you won't have a version of qemu that can do this > by itself, it may make sense to keep it around for a while. You might > want to include the version of your current qemu port is based on > qemu-2.x but not upstream, you could include a qemu-2.x.dts file > here, and have the future 3.x port provide its own. Ok, thx for the tips. Guo Ren