From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [RFC PATCH 1/2] mm: move tlb_table_flush to tlb_flush_mmu_free Date: Fri, 7 Sep 2018 14:44:00 +0100 Message-ID: <20180907134359.GA12187@arm.com> References: <20180823084709.19717-1-npiggin@gmail.com> <20180823084709.19717-2-npiggin@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Rik van Riel Cc: Nicholas Piggin , Peter Zijlstra , torvalds@linux-foundation.org, luto@kernel.org, x86@kernel.org, bp@alien8.de, jannh@google.com, ascannell@google.com, dave.hansen@intel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, David Miller , Martin Schwidefsky , Michael Ellerman , linux-arch@vger.kernel.org List-Id: linux-arch.vger.kernel.org On Thu, Sep 06, 2018 at 04:29:59PM -0400, Rik van Riel wrote: > On Thu, 2018-08-23 at 18:47 +1000, Nicholas Piggin wrote: > > There is no need to call this from tlb_flush_mmu_tlbonly, it > > logically belongs with tlb_flush_mmu_free. This allows some > > code consolidation with a subsequent fix. > > > > Signed-off-by: Nicholas Piggin > > Reviewed-by: Rik van Riel > > This patch also fixes an infinite recursion bug > with CONFIG_HAVE_RCU_TABLE_FREE enabled, which > has this call trace: > > tlb_table_flush > -> tlb_table_invalidate > -> tlb_flush_mmu_tlbonly > -> tlb_table_flush > -> ... (infinite recursion) > > This should probably be applied sooner rather than > later. It's already in mainline with a cc stable afaict. Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com ([217.140.101.70]:60610 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728481AbeIGSYr (ORCPT ); Fri, 7 Sep 2018 14:24:47 -0400 Date: Fri, 7 Sep 2018 14:44:00 +0100 From: Will Deacon Subject: Re: [RFC PATCH 1/2] mm: move tlb_table_flush to tlb_flush_mmu_free Message-ID: <20180907134359.GA12187@arm.com> References: <20180823084709.19717-1-npiggin@gmail.com> <20180823084709.19717-2-npiggin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Rik van Riel Cc: Nicholas Piggin , Peter Zijlstra , torvalds@linux-foundation.org, luto@kernel.org, x86@kernel.org, bp@alien8.de, jannh@google.com, ascannell@google.com, dave.hansen@intel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, David Miller , Martin Schwidefsky , Michael Ellerman , linux-arch@vger.kernel.org Message-ID: <20180907134400.SFLiJUpaakGDxqmtDVn5rDLfCiWRC6taOU2oQM-LFdU@z> On Thu, Sep 06, 2018 at 04:29:59PM -0400, Rik van Riel wrote: > On Thu, 2018-08-23 at 18:47 +1000, Nicholas Piggin wrote: > > There is no need to call this from tlb_flush_mmu_tlbonly, it > > logically belongs with tlb_flush_mmu_free. This allows some > > code consolidation with a subsequent fix. > > > > Signed-off-by: Nicholas Piggin > > Reviewed-by: Rik van Riel > > This patch also fixes an infinite recursion bug > with CONFIG_HAVE_RCU_TABLE_FREE enabled, which > has this call trace: > > tlb_table_flush > -> tlb_table_invalidate > -> tlb_flush_mmu_tlbonly > -> tlb_table_flush > -> ... (infinite recursion) > > This should probably be applied sooner rather than > later. It's already in mainline with a cc stable afaict. Will