From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH v6 01/16] x86/cpu: Create Hygon Dhyana architecture support file Date: Mon, 10 Sep 2018 18:38:21 +0200 Message-ID: <20180910163821.GD4386@zn.tnic> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Pu Wen Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, thomas.lendacky@amd.com, pbonzini@redhat.com, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org List-Id: linux-arch.vger.kernel.org On Mon, Sep 10, 2018 at 09:15:29PM +0800, Pu Wen wrote: > Add x86 architecture support for new processor Hygon Dhyana Family "... for a new processor: Hygon... " > 18h. Instead of all that: > Rework to create a separated file(arch/x86/kernel/cpu/hygon.c) > from the AMD one(arch/x86/kernel/cpu/amd.c) to initialize Dhyana. > In this way we can remove old AMD architecture support codes and > generate a clear initialization flow for Hygon Dhyana CPU. It also > reduce the long-term maintenance effort. ... simply say: "Carve out initialization code needed by Dhyana into a separate compilation unit." > Add Maintainer information > for hygon.c in accordance. That sentence is not needed - that fact is visible in the diff. > > To identify Hygon Dhyana CPU, add a new vendor type X86_VENDOR_HYGON(9) > for system recognition. No need for that "(9)" - also visible from the diff and an implementation detail. > > To enable the config for Hygon Dhyana CPU, add a separated Kconfig > entry(CPU_SUP_HYGON) in kernel config setup. That sentence is not needed for the same reason as above. > And select CPU_SUP_AMD > to solve the dependency issues in kernel. No, this should say: "Since Dhyana uses AMD functionality to a large degree, select CPU_SUP_AMD which provides that functionality." > > Signed-off-by: Pu Wen > --- > MAINTAINERS | 6 + > arch/x86/Kconfig.cpu | 14 ++ > arch/x86/include/asm/processor.h | 3 +- > arch/x86/kernel/cpu/Makefile | 1 + > arch/x86/kernel/cpu/hygon.c | 408 +++++++++++++++++++++++++++++++++++++++ > 5 files changed, 431 insertions(+), 1 deletion(-) > create mode 100644 arch/x86/kernel/cpu/hygon.c With that taken care of: Reviewed-by: Borislav Petkov -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.skyhub.de ([5.9.137.197]:59740 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727810AbeIJVd0 (ORCPT ); Mon, 10 Sep 2018 17:33:26 -0400 Date: Mon, 10 Sep 2018 18:38:21 +0200 From: Borislav Petkov Subject: Re: [PATCH v6 01/16] x86/cpu: Create Hygon Dhyana architecture support file Message-ID: <20180910163821.GD4386@zn.tnic> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Pu Wen Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, thomas.lendacky@amd.com, pbonzini@redhat.com, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Message-ID: <20180910163821.n3gaI8DFRFFZ1wTYf24kyUyOLxIeOdS_eyMDGH02wLw@z> On Mon, Sep 10, 2018 at 09:15:29PM +0800, Pu Wen wrote: > Add x86 architecture support for new processor Hygon Dhyana Family "... for a new processor: Hygon... " > 18h. Instead of all that: > Rework to create a separated file(arch/x86/kernel/cpu/hygon.c) > from the AMD one(arch/x86/kernel/cpu/amd.c) to initialize Dhyana. > In this way we can remove old AMD architecture support codes and > generate a clear initialization flow for Hygon Dhyana CPU. It also > reduce the long-term maintenance effort. ... simply say: "Carve out initialization code needed by Dhyana into a separate compilation unit." > Add Maintainer information > for hygon.c in accordance. That sentence is not needed - that fact is visible in the diff. > > To identify Hygon Dhyana CPU, add a new vendor type X86_VENDOR_HYGON(9) > for system recognition. No need for that "(9)" - also visible from the diff and an implementation detail. > > To enable the config for Hygon Dhyana CPU, add a separated Kconfig > entry(CPU_SUP_HYGON) in kernel config setup. That sentence is not needed for the same reason as above. > And select CPU_SUP_AMD > to solve the dependency issues in kernel. No, this should say: "Since Dhyana uses AMD functionality to a large degree, select CPU_SUP_AMD which provides that functionality." > > Signed-off-by: Pu Wen > --- > MAINTAINERS | 6 + > arch/x86/Kconfig.cpu | 14 ++ > arch/x86/include/asm/processor.h | 3 +- > arch/x86/kernel/cpu/Makefile | 1 + > arch/x86/kernel/cpu/hygon.c | 408 +++++++++++++++++++++++++++++++++++++++ > 5 files changed, 431 insertions(+), 1 deletion(-) > create mode 100644 arch/x86/kernel/cpu/hygon.c With that taken care of: Reviewed-by: Borislav Petkov -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.