From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Rostedt Subject: Re: [PATCH security-next v3 04/29] LSM: Remove initcall tracing Date: Wed, 26 Sep 2018 12:35:22 -0400 Message-ID: <20180926123522.4080d9eb@vmware.local.home> References: <20180925001832.18322-1-keescook@chromium.org> <20180925001832.18322-5-keescook@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180925001832.18322-5-keescook@chromium.org> Sender: linux-kernel-owner@vger.kernel.org To: Kees Cook Cc: James Morris , "Serge E. Hallyn" , Abderrahmane Benbachir , linux-security-module@vger.kernel.org, Casey Schaufler , John Johansen , Tetsuo Handa , Paul Moore , Stephen Smalley , "Schaufler, Casey" , Jonathan Corbet , linux-doc@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-arch.vger.kernel.org On Mon, 24 Sep 2018 17:18:07 -0700 Kees Cook wrote: > This partially reverts commit 58eacfffc417 ("init, tracing: instrument > security and console initcall trace events") since security init calls > are about to no longer resemble regular init calls. I'm not against the change, but how much are they going to "no longer resemble regular init calls"? -- Steve > > Cc: James Morris > Cc: "Serge E. Hallyn" > Cc: Abderrahmane Benbachir > Cc: Steven Rostedt (VMware) > Cc: linux-security-module@vger.kernel.org > Signed-off-by: Kees Cook > --- > security/security.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/security/security.c b/security/security.c > index 892fe6b691cf..41a5da2c7faf 100644 > --- a/security/security.c > +++ b/security/security.c > @@ -30,8 +30,6 @@ > #include > #include > > -#include > - > #define MAX_LSM_EVM_XATTR 2 > > /* Maximum number of letters for an LSM name string */ > @@ -47,17 +45,13 @@ static __initdata char chosen_lsm[SECURITY_NAME_MAX + 1] = > > static void __init do_security_initcalls(void) > { > - int ret; > initcall_t call; > initcall_entry_t *ce; > > ce = __start_lsm_info; > - trace_initcall_level("security"); > while (ce < __end_lsm_info) { > call = initcall_from_entry(ce); > - trace_initcall_start(call); > - ret = call(); > - trace_initcall_finish(call, ret); > + call(); > ce++; > } > } From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:34506 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728241AbeIZWtR (ORCPT ); Wed, 26 Sep 2018 18:49:17 -0400 Date: Wed, 26 Sep 2018 12:35:22 -0400 From: Steven Rostedt Subject: Re: [PATCH security-next v3 04/29] LSM: Remove initcall tracing Message-ID: <20180926123522.4080d9eb@vmware.local.home> In-Reply-To: <20180925001832.18322-5-keescook@chromium.org> References: <20180925001832.18322-1-keescook@chromium.org> <20180925001832.18322-5-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Kees Cook Cc: James Morris , "Serge E. Hallyn" , Abderrahmane Benbachir , linux-security-module@vger.kernel.org, Casey Schaufler , John Johansen , Tetsuo Handa , Paul Moore , Stephen Smalley , "Schaufler, Casey" , Jonathan Corbet , linux-doc@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20180926163522.IgitqGzasXt4Urjk18kAT_DdxSzWGLMA6oT90K9PeDw@z> On Mon, 24 Sep 2018 17:18:07 -0700 Kees Cook wrote: > This partially reverts commit 58eacfffc417 ("init, tracing: instrument > security and console initcall trace events") since security init calls > are about to no longer resemble regular init calls. I'm not against the change, but how much are they going to "no longer resemble regular init calls"? -- Steve > > Cc: James Morris > Cc: "Serge E. Hallyn" > Cc: Abderrahmane Benbachir > Cc: Steven Rostedt (VMware) > Cc: linux-security-module@vger.kernel.org > Signed-off-by: Kees Cook > --- > security/security.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/security/security.c b/security/security.c > index 892fe6b691cf..41a5da2c7faf 100644 > --- a/security/security.c > +++ b/security/security.c > @@ -30,8 +30,6 @@ > #include > #include > > -#include > - > #define MAX_LSM_EVM_XATTR 2 > > /* Maximum number of letters for an LSM name string */ > @@ -47,17 +45,13 @@ static __initdata char chosen_lsm[SECURITY_NAME_MAX + 1] = > > static void __init do_security_initcalls(void) > { > - int ret; > initcall_t call; > initcall_entry_t *ce; > > ce = __start_lsm_info; > - trace_initcall_level("security"); > while (ce < __end_lsm_info) { > call = initcall_from_entry(ce); > - trace_initcall_start(call); > - ret = call(); > - trace_initcall_finish(call, ret); > + call(); > ce++; > } > }