From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH V6 03/33] csky: Kernel booting Date: Fri, 28 Sep 2018 09:13:05 -0700 Message-ID: <20180928161305.GB19827@infradead.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Guo Ren Cc: akpm@linux-foundation.org, arnd@arndb.de, daniel.lezcano@linaro.org, davem@davemloft.net, gregkh@linuxfoundation.org, jason@lakedaemon.net, marc.zyngier@arm.com, mark.rutland@arm.com, mchehab+samsung@kernel.org, peterz@infradead.org, robh@kernel.org, robh+dt@kernel.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, devicetree@vger.kernel.org, green.hu@gmail.com List-Id: linux-arch.vger.kernel.org > +phys_addr_t __init_memblock memblock_end_of_REG0(void) > +{ > + return (memblock.memory.regions[0].base + memblock.memory.regions[0].size); > +} No need for the braces. > + if (memblock.memory.cnt > 1) { > + zone_size[ZONE_NORMAL] = PFN_DOWN(memblock_start_of_REG1()) - min_low_pfn; > + zhole_size[ZONE_NORMAL] = PFN_DOWN(memblock_start_of_REG1()) - max_low_pfn; Please brake lines after 80 characters. > + pr_info("C-SKY: https://github.com/c-sky/csky-linux\n"); I don't think this belongs into the kernel log. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.133]:56044 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728643AbeI1Whk (ORCPT ); Fri, 28 Sep 2018 18:37:40 -0400 Date: Fri, 28 Sep 2018 09:13:05 -0700 From: Christoph Hellwig Subject: Re: [PATCH V6 03/33] csky: Kernel booting Message-ID: <20180928161305.GB19827@infradead.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Guo Ren Cc: akpm@linux-foundation.org, arnd@arndb.de, daniel.lezcano@linaro.org, davem@davemloft.net, gregkh@linuxfoundation.org, jason@lakedaemon.net, marc.zyngier@arm.com, mark.rutland@arm.com, mchehab+samsung@kernel.org, peterz@infradead.org, robh@kernel.org, robh+dt@kernel.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, devicetree@vger.kernel.org, green.hu@gmail.com Message-ID: <20180928161305.qhO25x1LYCnaLsz2G7bibuBIEzs7pwvLXGIkuooII3o@z> > +phys_addr_t __init_memblock memblock_end_of_REG0(void) > +{ > + return (memblock.memory.regions[0].base + memblock.memory.regions[0].size); > +} No need for the braces. > + if (memblock.memory.cnt > 1) { > + zone_size[ZONE_NORMAL] = PFN_DOWN(memblock_start_of_REG1()) - min_low_pfn; > + zhole_size[ZONE_NORMAL] = PFN_DOWN(memblock_start_of_REG1()) - max_low_pfn; Please brake lines after 80 characters. > + pr_info("C-SKY: https://github.com/c-sky/csky-linux\n"); I don't think this belongs into the kernel log.