From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guo Ren Subject: Re: [PATCH V8 18/21] dt-bindings: csky CPU Bindings Date: Fri, 12 Oct 2018 20:18:21 +0800 Message-ID: <20181012121821.GA12182@guoren-Inspiron-7460> References: <1c77e479a1dc0119912ac146b1038963b3653381.1539315391.git.ren_guo@c-sky.com> <20181012113551.GA17917@bogus> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20181012113551.GA17917@bogus> Sender: linux-kernel-owner@vger.kernel.org To: Rob Herring Cc: akpm@linux-foundation.org, arnd@arndb.de, daniel.lezcano@linaro.org, davem@davemloft.net, gregkh@linuxfoundation.org, hch@infradead.org, marc.zyngier@arm.com, mark.rutland@arm.com, peterz@infradead.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, devicetree@vger.kernel.org, c-sky_gcc_upstream@c-sky.com List-Id: linux-arch.vger.kernel.org On Fri, Oct 12, 2018 at 06:35:51AM -0500, Rob Herring wrote: > On Fri, Oct 12, 2018 at 12:42:53PM +0800, Guo Ren wrote: > > This patch adds the documentation to describe that how to add cpu nodes in > > dts for SMP. > > > > Signed-off-by: Guo Ren > > Cc: Rob Herring > > --- > > Documentation/devicetree/bindings/csky/cpus.txt | 70 +++++++++++++++++++++++++ > > 1 file changed, 70 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/csky/cpus.txt > > > > diff --git a/Documentation/devicetree/bindings/csky/cpus.txt b/Documentation/devicetree/bindings/csky/cpus.txt > > new file mode 100644 > > index 0000000..ee3901d > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/csky/cpus.txt > > @@ -0,0 +1,70 @@ > > +================== > > +C-SKY CPU Bindings > > +================== > > + > > +The device tree allows to describe the layout of CPUs in a system through > > +the "cpus" node, which in turn contains a number of subnodes (ie "cpu") > > +defining properties for every cpu. > > + > > +Only SMP system need to care about the cpus node and single processor > > +needn't define cpus node at all. > > + > > +===================================== > > +cpus and cpu node bindings definition > > +===================================== > > + > > +- cpus node > > + > > + Description: Container of cpu nodes > > + > > + The node name must be "cpus". > > + > > + A cpus node must define the following properties: > > + > > + - #address-cells > > + Usage: required > > + Value type: > > + Definition: must be set to 1 > > + - #size-cells > > + Usage: required > > + Value type: > > + Definition: must be set to 0 > > + > > +- cpu node > > + > > + Description: Describes one of SMP cores > > + > > + PROPERTIES > > + > > What happened to compatible? Opps ... I forgot it. - compatible: Usage: required Value type: Definition: must contain "csky", eg: "csky,610" "csky,807" "csky,810" "csky,860" > > > + - device_type > > + Usage: required > > + Value type: > > + Definition: must be "cpu" > > + - reg > > + Usage: required > > + Value type: > > + Definition: CPU index > > + - status: > > Drop this. It is implied. Ok, remove status. Best Regards Guo Ren From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp2200-217.mail.aliyun.com ([121.197.200.217]:53864 "EHLO smtp2200-217.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728145AbeJLTuo (ORCPT ); Fri, 12 Oct 2018 15:50:44 -0400 Date: Fri, 12 Oct 2018 20:18:21 +0800 From: Guo Ren Subject: Re: [PATCH V8 18/21] dt-bindings: csky CPU Bindings Message-ID: <20181012121821.GA12182@guoren-Inspiron-7460> References: <1c77e479a1dc0119912ac146b1038963b3653381.1539315391.git.ren_guo@c-sky.com> <20181012113551.GA17917@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181012113551.GA17917@bogus> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Rob Herring Cc: akpm@linux-foundation.org, arnd@arndb.de, daniel.lezcano@linaro.org, davem@davemloft.net, gregkh@linuxfoundation.org, hch@infradead.org, marc.zyngier@arm.com, mark.rutland@arm.com, peterz@infradead.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, devicetree@vger.kernel.org, c-sky_gcc_upstream@c-sky.com Message-ID: <20181012121821.6RqJGRuJQBO1uKgZ81GODXi5pxw0AuxnKx8IB5lHCus@z> On Fri, Oct 12, 2018 at 06:35:51AM -0500, Rob Herring wrote: > On Fri, Oct 12, 2018 at 12:42:53PM +0800, Guo Ren wrote: > > This patch adds the documentation to describe that how to add cpu nodes in > > dts for SMP. > > > > Signed-off-by: Guo Ren > > Cc: Rob Herring > > --- > > Documentation/devicetree/bindings/csky/cpus.txt | 70 +++++++++++++++++++++++++ > > 1 file changed, 70 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/csky/cpus.txt > > > > diff --git a/Documentation/devicetree/bindings/csky/cpus.txt b/Documentation/devicetree/bindings/csky/cpus.txt > > new file mode 100644 > > index 0000000..ee3901d > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/csky/cpus.txt > > @@ -0,0 +1,70 @@ > > +================== > > +C-SKY CPU Bindings > > +================== > > + > > +The device tree allows to describe the layout of CPUs in a system through > > +the "cpus" node, which in turn contains a number of subnodes (ie "cpu") > > +defining properties for every cpu. > > + > > +Only SMP system need to care about the cpus node and single processor > > +needn't define cpus node at all. > > + > > +===================================== > > +cpus and cpu node bindings definition > > +===================================== > > + > > +- cpus node > > + > > + Description: Container of cpu nodes > > + > > + The node name must be "cpus". > > + > > + A cpus node must define the following properties: > > + > > + - #address-cells > > + Usage: required > > + Value type: > > + Definition: must be set to 1 > > + - #size-cells > > + Usage: required > > + Value type: > > + Definition: must be set to 0 > > + > > +- cpu node > > + > > + Description: Describes one of SMP cores > > + > > + PROPERTIES > > + > > What happened to compatible? Opps ... I forgot it. - compatible: Usage: required Value type: Definition: must contain "csky", eg: "csky,610" "csky,807" "csky,810" "csky,860" > > > + - device_type > > + Usage: required > > + Value type: > > + Definition: must be "cpu" > > + - reg > > + Usage: required > > + Value type: > > + Definition: CPU index > > + - status: > > Drop this. It is implied. Ok, remove status. Best Regards Guo Ren