From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 4/8] pci: consolidate PCI config entry in drivers/pci Date: Mon, 15 Oct 2018 10:57:37 +0200 Message-ID: <20181015085737.GC27159@lst.de> References: <20181013151016.31674-1-hch@lst.de> <20181013151016.31674-5-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Masahiro Yamada Cc: Christoph Hellwig , mporter@kernel.crashing.org, alex.bou9@gmail.com, Dominik Brodowski , Linux Kbuild mailing list , linux-pci@vger.kernel.org, linux-scsi , linux-arch , Linux Kernel Mailing List , linuxppc-dev List-Id: linux-arch.vger.kernel.org On Mon, Oct 15, 2018 at 03:37:05PM +0900, Masahiro Yamada wrote: > I think HAVE_ is a preferred prefix in this case according to this doc: > https://github.com/masahir0y/linux/blob/v4.19-rc4/Documentation/kbuild/kconfig-language.txt#L448 Ok, I'll switch everything to HAVE_* > If you do this for entire powerpc, > the other 'select HAS_PCI' addtions to > arch/powerpc/platforms/*/Kconfig look redundant. I'll drop them. > > -config PCI > > - bool "PCI support" > > - select PCI_MSI > > > I think this 'select PCI_MSI' for riscv was lost. Indeed, fixed. > > menu "Bus options (PCI etc.)" > > > > -config PCI > > - bool "PCI support" > > - default y > > > The default is y for x86 (and xtensa as well). > > With this patch, the default will be flipped. > > I think most of people want to use PCI for x86, > and this change will make people upset. > > Will you update arch/{x86,xtensa}/configs/*_defconfig? Yes. Alternatively we could add a new ARCH_PCI_DEFAULT symbol, that architectures could select if they want PCI by default. Does anyone thing this is a good idea? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de ([213.95.11.211]:41038 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726273AbeJOQmA (ORCPT ); Mon, 15 Oct 2018 12:42:00 -0400 Date: Mon, 15 Oct 2018 10:57:37 +0200 From: Christoph Hellwig Subject: Re: [PATCH 4/8] pci: consolidate PCI config entry in drivers/pci Message-ID: <20181015085737.GC27159@lst.de> References: <20181013151016.31674-1-hch@lst.de> <20181013151016.31674-5-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Masahiro Yamada Cc: Christoph Hellwig , mporter@kernel.crashing.org, alex.bou9@gmail.com, Dominik Brodowski , Linux Kbuild mailing list , linux-pci@vger.kernel.org, linux-scsi , linux-arch , Linux Kernel Mailing List , linuxppc-dev Message-ID: <20181015085737.gV1lqzGHdra8bNvWnJaxboLcXDeirtetdZa8H3W0yP0@z> On Mon, Oct 15, 2018 at 03:37:05PM +0900, Masahiro Yamada wrote: > I think HAVE_ is a preferred prefix in this case according to this doc: > https://github.com/masahir0y/linux/blob/v4.19-rc4/Documentation/kbuild/kconfig-language.txt#L448 Ok, I'll switch everything to HAVE_* > If you do this for entire powerpc, > the other 'select HAS_PCI' addtions to > arch/powerpc/platforms/*/Kconfig look redundant. I'll drop them. > > -config PCI > > - bool "PCI support" > > - select PCI_MSI > > > I think this 'select PCI_MSI' for riscv was lost. Indeed, fixed. > > menu "Bus options (PCI etc.)" > > > > -config PCI > > - bool "PCI support" > > - default y > > > The default is y for x86 (and xtensa as well). > > With this patch, the default will be flipped. > > I think most of people want to use PCI for x86, > and this change will make people upset. > > Will you update arch/{x86,xtensa}/configs/*_defconfig? Yes. Alternatively we could add a new ARCH_PCI_DEFAULT symbol, that architectures could select if they want PCI by default. Does anyone thing this is a good idea?