From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guo Ren Subject: Re: [PATCH V9 05/21] csky: System Call Date: Thu, 18 Oct 2018 10:02:04 +0800 Message-ID: <20181018020203.GA12027@guoren-Inspiron-7460> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Arnd Bergmann Cc: Andrew Morton , Daniel Lezcano , David Miller , gregkh , Christoph Hellwig , Marc Zyngier , Mark Rutland , Peter Zijlstra , Rob Herring , Thomas Gleixner , Linux Kernel Mailing List , linux-arch , DTML , Rob Herring , c-sky_gcc_upstream@c-sky.com List-Id: linux-arch.vger.kernel.org On Wed, Oct 17, 2018 at 05:02:33PM +0200, Arnd Bergmann wrote: > On Tue, Oct 16, 2018 at 5:01 AM Guo Ren wrote: > > > > This patch adds files related to syscall. > > > > Signed-off-by: Guo Ren > > Cc: Arnd Bergmann > > Reviewed-by: Arnd Bergmann > > I had a detailed look at this one and provided lots of comments, however > one tiny thing escaped me: > > > +#define __NR_set_thread_area (__NR_arch_specific_syscall + 0) > > +__SYSCALL(__NR_set_thread_area, sys_set_thread_area) > > +#define __NR_cacheflush (__NR_arch_specific_syscall + 4) > > +__SYSCALL(__NR_cacheflush, sys_cacheflush) > > It's odd that the second one uses __NR_arch_specific_syscall + 4 rather > than +1. If you can still change that changing too much other stuff, > that might avoid some head-scratching later. If it causes problems, > just leave it and maybe add a comment saying that the numbers > inbetween are still available. Change to (__NR_arch_specific_syscall + 1) is ok for now. Best Regards Guo Ren From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp2200-217.mail.aliyun.com ([121.197.200.217]:33159 "EHLO smtp2200-217.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727335AbeJRKBM (ORCPT ); Thu, 18 Oct 2018 06:01:12 -0400 Date: Thu, 18 Oct 2018 10:02:04 +0800 From: Guo Ren Subject: Re: [PATCH V9 05/21] csky: System Call Message-ID: <20181018020203.GA12027@guoren-Inspiron-7460> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Arnd Bergmann Cc: Andrew Morton , Daniel Lezcano , David Miller , gregkh , Christoph Hellwig , Marc Zyngier , Mark Rutland , Peter Zijlstra , Rob Herring , Thomas Gleixner , Linux Kernel Mailing List , linux-arch , DTML , Rob Herring , c-sky_gcc_upstream@c-sky.com Message-ID: <20181018020204.CiODlHrc_m4gacUNtQV2K8bIY7WyVxIdroHtgO9P3Kw@z> On Wed, Oct 17, 2018 at 05:02:33PM +0200, Arnd Bergmann wrote: > On Tue, Oct 16, 2018 at 5:01 AM Guo Ren wrote: > > > > This patch adds files related to syscall. > > > > Signed-off-by: Guo Ren > > Cc: Arnd Bergmann > > Reviewed-by: Arnd Bergmann > > I had a detailed look at this one and provided lots of comments, however > one tiny thing escaped me: > > > +#define __NR_set_thread_area (__NR_arch_specific_syscall + 0) > > +__SYSCALL(__NR_set_thread_area, sys_set_thread_area) > > +#define __NR_cacheflush (__NR_arch_specific_syscall + 4) > > +__SYSCALL(__NR_cacheflush, sys_cacheflush) > > It's odd that the second one uses __NR_arch_specific_syscall + 4 rather > than +1. If you can still change that changing too much other stuff, > that might avoid some head-scratching later. If it causes problems, > just leave it and maybe add a comment saying that the numbers > inbetween are still available. Change to (__NR_arch_specific_syscall + 1) is ok for now. Best Regards Guo Ren