From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Rapoport Subject: Re: [PATCH v2 0/2] arm64: Cut rebuild time when changing CONFIG_BLK_DEV_INITRD Date: Fri, 26 Oct 2018 12:07:09 +0100 Message-ID: <20181026110708.GA3814@rapoport-lnx> References: <20181024193256.23734-1-f.fainelli@gmail.com> <20181025093833.GA23607@rapoport-lnx> <20181025172935.GA27364@rapoport-lnx> <1bb3bd63-a88e-b668-ea36-f0f985c0e2b1@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1bb3bd63-a88e-b668-ea36-f0f985c0e2b1@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Florian Fainelli Cc: Rob Herring , Ard Biesheuvel , "linux-kernel@vger.kernel.org" , Catalin Marinas , Will Deacon , Arnd Bergmann , Greg Kroah-Hartman , Marc Zyngier , Olof Johansson , linux-alpha@vger.kernel.org, arcml , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-c6x-dev@linux-c6x.org, "moderated list:H8/300 ARCHITECTURE" , linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, Linux-MIPS List-Id: linux-arch.vger.kernel.org On Thu, Oct 25, 2018 at 04:07:13PM -0700, Florian Fainelli wrote: > On 10/25/18 2:13 PM, Rob Herring wrote: > > On Thu, Oct 25, 2018 at 12:30 PM Mike Rapoport wrote: > >> > >> On Thu, Oct 25, 2018 at 08:15:15AM -0500, Rob Herring wrote: > >>> +Ard > >>> > >>> On Thu, Oct 25, 2018 at 4:38 AM Mike Rapoport wrote: > >>>> > >>>> On Wed, Oct 24, 2018 at 02:55:17PM -0500, Rob Herring wrote: > >>>>> On Wed, Oct 24, 2018 at 2:33 PM Florian Fainelli wrote: > >>>>>> > >>>>>> Hi all, > >>>>>> > >>>>>> While investigating why ARM64 required a ton of objects to be rebuilt > >>>>>> when toggling CONFIG_DEV_BLK_INITRD, it became clear that this was > >>>>>> because we define __early_init_dt_declare_initrd() differently and we do > >>>>>> that in arch/arm64/include/asm/memory.h which gets included by a fair > >>>>>> amount of other header files, and translation units as well. > >>>>> > >>>> I think arm64 does not have to redefine __early_init_dt_declare_initrd(). > >>>> Something like this might be just all we need (completely untested, > >>>> probably it won't even compile): [ ... ] > FWIW, I am extracting the ARM implementation that parses the initrd > early command line parameter and the "setup" code doing the page > boundary alignment and memblock checking into a helper into lib/ that > other architectures can re-use. So far, this removes the need for > unicore32, arc and arm to duplicate essentially the same logic. Presuming you are going to need asm-generic/initrd.h for that as well, using override for __early_init_dt_declare_initrd in arm64 version of initrd.h might be the simplest option. > -- > Florian > -- Sincerely yours, Mike. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:36818 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726949AbeJZToN (ORCPT ); Fri, 26 Oct 2018 15:44:13 -0400 Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w9QAxWF0015935 for ; Fri, 26 Oct 2018 07:07:32 -0400 Received: from e06smtp01.uk.ibm.com (e06smtp01.uk.ibm.com [195.75.94.97]) by mx0a-001b2d01.pphosted.com with ESMTP id 2nc1gwgpvc-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 26 Oct 2018 07:07:32 -0400 Received: from localhost by e06smtp01.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 26 Oct 2018 12:07:29 +0100 Date: Fri, 26 Oct 2018 12:07:09 +0100 From: Mike Rapoport Subject: Re: [PATCH v2 0/2] arm64: Cut rebuild time when changing CONFIG_BLK_DEV_INITRD References: <20181024193256.23734-1-f.fainelli@gmail.com> <20181025093833.GA23607@rapoport-lnx> <20181025172935.GA27364@rapoport-lnx> <1bb3bd63-a88e-b668-ea36-f0f985c0e2b1@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1bb3bd63-a88e-b668-ea36-f0f985c0e2b1@gmail.com> Message-ID: <20181026110708.GA3814@rapoport-lnx> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Florian Fainelli Cc: Rob Herring , Ard Biesheuvel , "linux-kernel@vger.kernel.org" , Catalin Marinas , Will Deacon , Arnd Bergmann , Greg Kroah-Hartman , Marc Zyngier , Olof Johansson , linux-alpha@vger.kernel.org, arcml , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-c6x-dev@linux-c6x.org, "moderated list:H8/300 ARCHITECTURE" , linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, Linux-MIPS , nios2-dev@lists.rocketboards.org, Openrisc , linux-parisc@vger.kernel.org, linuxppc-dev , linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, SH-Linux , sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, devicetree@vger.kernel.org, "open list:GENERIC INCLUDE/ASM HEADER FILES" Message-ID: <20181026110709.xqtMo23mSil9uPBrWee7M-IYQcDrzTm062pkhCBCLj8@z> On Thu, Oct 25, 2018 at 04:07:13PM -0700, Florian Fainelli wrote: > On 10/25/18 2:13 PM, Rob Herring wrote: > > On Thu, Oct 25, 2018 at 12:30 PM Mike Rapoport wrote: > >> > >> On Thu, Oct 25, 2018 at 08:15:15AM -0500, Rob Herring wrote: > >>> +Ard > >>> > >>> On Thu, Oct 25, 2018 at 4:38 AM Mike Rapoport wrote: > >>>> > >>>> On Wed, Oct 24, 2018 at 02:55:17PM -0500, Rob Herring wrote: > >>>>> On Wed, Oct 24, 2018 at 2:33 PM Florian Fainelli wrote: > >>>>>> > >>>>>> Hi all, > >>>>>> > >>>>>> While investigating why ARM64 required a ton of objects to be rebuilt > >>>>>> when toggling CONFIG_DEV_BLK_INITRD, it became clear that this was > >>>>>> because we define __early_init_dt_declare_initrd() differently and we do > >>>>>> that in arch/arm64/include/asm/memory.h which gets included by a fair > >>>>>> amount of other header files, and translation units as well. > >>>>> > >>>> I think arm64 does not have to redefine __early_init_dt_declare_initrd(). > >>>> Something like this might be just all we need (completely untested, > >>>> probably it won't even compile): [ ... ] > FWIW, I am extracting the ARM implementation that parses the initrd > early command line parameter and the "setup" code doing the page > boundary alignment and memblock checking into a helper into lib/ that > other architectures can re-use. So far, this removes the need for > unicore32, arc and arm to duplicate essentially the same logic. Presuming you are going to need asm-generic/initrd.h for that as well, using override for __early_init_dt_declare_initrd in arm64 version of initrd.h might be the simplest option. > -- > Florian > -- Sincerely yours, Mike.