From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH v5] kernel/signal: Signal-based pre-coredump notification Date: Wed, 21 Nov 2018 16:37:11 -0800 Message-ID: <20181121163711.2c00316784d221eb1750edb0@linux-foundation.org> References: <458c04d8-d189-4a26-729a-bb1d1d751534@cisco.com> <7741efa7-a3f8-62a1-ba52-613883164643@cisco.com> <84460a77-a111-404e-4bad-88104a6e246e@cisco.com> <20181026082812.GA10581@redhat.com> <21f678a8-4001-df36-c26e-e96cf203b1b1@cisco.com> <20181029111804.GA24820@redhat.com> <0c197608-3b7e-ffd1-8943-801a60beb917@cisco.com> <20181030164628.GD7643@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20181030164628.GD7643@redhat.com> Sender: linux-kernel-owner@vger.kernel.org To: Oleg Nesterov Cc: Enke Chen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Peter Zijlstra , Arnd Bergmann , "Eric W. Biederman" , Khalid Aziz , Kate Stewart , Helge Deller , Greg Kroah-Hartman , Al Viro , Christian Brauner , Catalin Marinas , Will Deacon , Dave Martin , Mauro Carvalho Chehab , Michal Hocko , Rik van Riel List-Id: linux-arch.vger.kernel.org On Tue, 30 Oct 2018 17:46:29 +0100 Oleg Nesterov wrote: > On 10/29, Enke Chen wrote: > > > > Reviewed-by: Oleg Nesterov > > Hmm. I didn't say this ;) > > But OK, feel free to keep this tag. > > I do not like this feauture. Why is that? > But I see no technical problems in this version > and I never pretented I understand the user-space needs, so I won't argue. The changelog appears to spell this all out quite well? Unusually well, in my experience ;) A couple of things... - We'll be looking for a manpage update please. (Search MAINTAINERS for "manpage") - As it's a linux-specific feature, a test under tools/testing/selftests would be appropriate. I don't know how much that work will be. Do we have other linux-specific signal extensions which could piggyback onto that? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:44942 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732226AbeKVLOD (ORCPT ); Thu, 22 Nov 2018 06:14:03 -0500 Date: Wed, 21 Nov 2018 16:37:11 -0800 From: Andrew Morton Subject: Re: [PATCH v5] kernel/signal: Signal-based pre-coredump notification Message-ID: <20181121163711.2c00316784d221eb1750edb0@linux-foundation.org> In-Reply-To: <20181030164628.GD7643@redhat.com> References: <458c04d8-d189-4a26-729a-bb1d1d751534@cisco.com> <7741efa7-a3f8-62a1-ba52-613883164643@cisco.com> <84460a77-a111-404e-4bad-88104a6e246e@cisco.com> <20181026082812.GA10581@redhat.com> <21f678a8-4001-df36-c26e-e96cf203b1b1@cisco.com> <20181029111804.GA24820@redhat.com> <0c197608-3b7e-ffd1-8943-801a60beb917@cisco.com> <20181030164628.GD7643@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Oleg Nesterov Cc: Enke Chen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Peter Zijlstra , Arnd Bergmann , "Eric W. Biederman" , Khalid Aziz , Kate Stewart , Helge Deller , Greg Kroah-Hartman , Al Viro , Christian Brauner , Catalin Marinas , Will Deacon , Dave Martin , Mauro Carvalho Chehab , Michal Hocko , Rik van Riel , "Kirill A. Shutemov" , Roman Gushchin , Marcos Paulo de Souza , Dominik Brodowski , Cyrill Gorcunov , Yang Shi , Jann Horn , Kees Cook , x86@kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, "Victor Kamensky (kamensky)" , xe-linux-external@cisco.com, Stefan Strogin Message-ID: <20181122003711.WlfE37SaNHKZH2y6_wvrAk5Msw3WWCLYqjz_TofI2E8@z> On Tue, 30 Oct 2018 17:46:29 +0100 Oleg Nesterov wrote: > On 10/29, Enke Chen wrote: > > > > Reviewed-by: Oleg Nesterov > > Hmm. I didn't say this ;) > > But OK, feel free to keep this tag. > > I do not like this feauture. Why is that? > But I see no technical problems in this version > and I never pretented I understand the user-space needs, so I won't argue. The changelog appears to spell this all out quite well? Unusually well, in my experience ;) A couple of things... - We'll be looking for a manpage update please. (Search MAINTAINERS for "manpage") - As it's a linux-specific feature, a test under tools/testing/selftests would be appropriate. I don't know how much that work will be. Do we have other linux-specific signal extensions which could piggyback onto that?