From: Jessica Yu <jeyu@kernel.org>
To: Mathias Krause <minipli@googlemail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH] vmlinux.lds.h: drop unused __vermagic
Date: Wed, 2 Jan 2019 21:29:39 +0100 [thread overview]
Message-ID: <20190102202938.GA26600@linux-8ccs> (raw)
In-Reply-To: <1546173604-26066-1-git-send-email-minipli@googlemail.com>
+++ Mathias Krause [30/12/18 13:40 +0100]:
>The reference to '__vermagic' is a relict from v2.5 times. And even
>there it had a very short life time, from v2.5.59 (commit 1d411b80ee18
>("Module Sanity Check") in the historic tree) to v2.5.69 (commit
>67ac5b866bda ("[PATCH] complete modinfo section")).
>
>Neither current kernels nor modules contain a '__vermagic' section any
>more, so get rid of it.
>
>Signed-off-by: Mathias Krause <minipli@googlemail.com>
>Cc: Rusty Russell <rusty@rustcorp.com.au>
>Cc: Jessica Yu <jeyu@kernel.org>
Thanks for the cleanup.
Reviewed-by: Jessica Yu <jeyu@kernel.org>
>---
> include/asm-generic/vmlinux.lds.h | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
>index 3d7a6a9c2370..530ce1e7a1ec 100644
>--- a/include/asm-generic/vmlinux.lds.h
>+++ b/include/asm-generic/vmlinux.lds.h
>@@ -332,7 +332,6 @@
> __start_rodata = .; \
> *(.rodata) *(.rodata.*) \
> RO_AFTER_INIT_DATA /* Read only after init */ \
>- KEEP(*(__vermagic)) /* Kernel version magic */ \
> . = ALIGN(8); \
> __start___tracepoints_ptrs = .; \
> KEEP(*(__tracepoints_ptrs)) /* Tracepoints: pointer array */ \
>--
>2.19.2
>
next prev parent reply other threads:[~2019-01-02 20:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-30 12:40 [PATCH] vmlinux.lds.h: drop unused __vermagic Mathias Krause
2018-12-30 12:40 ` Mathias Krause
2019-01-02 20:29 ` Jessica Yu [this message]
2019-01-02 20:29 ` Jessica Yu
2019-01-21 11:39 ` Mathias Krause
2019-01-21 11:39 ` Mathias Krause
2019-03-10 19:26 ` Mathias Krause
2019-03-10 19:26 ` Mathias Krause
2019-03-11 11:55 ` Jessica Yu
2019-03-11 11:55 ` Jessica Yu
2019-03-11 12:11 ` Arnd Bergmann
2019-03-11 12:11 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190102202938.GA26600@linux-8ccs \
--to=jeyu@kernel.org \
--cc=arnd@arndb.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minipli@googlemail.com \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox