From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrea Parri Subject: Re: [PATCH RFC memory-model 0/6] LKMM updates Date: Thu, 10 Jan 2019 09:40:24 +0100 Message-ID: <20190110084024.GA10280@andrea> References: <20190109210706.GA27268@linux.ibm.com> <20190109231852.GA4494@andrea> <20190109234043.GD1215@linux.ibm.com> <20190110003952.GA4354@andrea> <20190110042027.GG1215@linux.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190110042027.GG1215@linux.ibm.com> Sender: linux-kernel-owner@vger.kernel.org To: "Paul E. McKenney" Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, mingo@kernel.org, stern@rowland.harvard.edu, parri.andrea@gmail.com, will.deacon@arm.com, peterz@infradead.org, boqun.feng@gmail.com, npiggin@gmail.com, dhowells@redhat.com, j.alglave@ucl.ac.uk, luc.maranget@inria.fr, akiyks@gmail.com, willy@infradead.org List-Id: linux-arch.vger.kernel.org > > > > It seems that > > > > > > > > 1b52d0186177 ("tools/memory-model: Model smp_mb__after_unlock_lock()") > > > > > > > > from linux-rcu/dev got lost; this also needs an ack (probably yours! ;D, > > > > considered that, IIRC, you introduced the primitive and RCU is currently > > > > its only user.) > > > > > > That commit is in -tip: > > > > > > 4607abbcf464 ("tools/memory-model: Model smp_mb__after_unlock_lock()") > > > > > > So it has already left my -rcu tree. ;-) > > > > Oh, you're right: now I see the commit (e.g., with "git show"), but I > > don't see the corresponding changes applied to the tree. > > > > https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?h=locking/core&id=4607abbcf464ea2be14da444215d05c73025cf6e > > https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/tree/tools/memory-model/linux-kernel.bell?h=locking/core > > > > Is this expected? > > Are you asking why it is in -tip but not in mainline? I am not sure, > but given that the merge window was over the holiday season and that > the length of the merge window proved to be shorter than many people > expected it to be, I am not too surprised. ;-) Mmh, let me try again: $ git clone git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git $ cd tip $ git checkout -b locking/core origin/locking/core $ git show 4607abbcf464 commit 4607abbcf464ea2be14da444215d05c73025cf6e Author: Andrea Parri Date: Mon Dec 3 15:04:49 2018 -0800 tools/memory-model: Model smp_mb__after_unlock_lock() $ cd tools/memory-model $ herd7 -conf linux-kernel.cfg after-unlock-lock-same-cpu.litmus File "after-unlock-lock-same-cpu.litmus": Unknown macro smp_mb__after_unlock_lock (User error) [aka, linux-kernel.def in tip:locking/core does not have the smp_mb__after_unlock_lock() added by 4607abbcf464] Andrea > > Thanx, Paul > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f65.google.com ([209.85.208.65]:46407 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727328AbfAJIki (ORCPT ); Thu, 10 Jan 2019 03:40:38 -0500 Received: by mail-ed1-f65.google.com with SMTP id o10so9471231edt.13 for ; Thu, 10 Jan 2019 00:40:37 -0800 (PST) Date: Thu, 10 Jan 2019 09:40:24 +0100 From: Andrea Parri Subject: Re: [PATCH RFC memory-model 0/6] LKMM updates Message-ID: <20190110084024.GA10280@andrea> References: <20190109210706.GA27268@linux.ibm.com> <20190109231852.GA4494@andrea> <20190109234043.GD1215@linux.ibm.com> <20190110003952.GA4354@andrea> <20190110042027.GG1215@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190110042027.GG1215@linux.ibm.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: "Paul E. McKenney" Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, mingo@kernel.org, stern@rowland.harvard.edu, parri.andrea@gmail.com, will.deacon@arm.com, peterz@infradead.org, boqun.feng@gmail.com, npiggin@gmail.com, dhowells@redhat.com, j.alglave@ucl.ac.uk, luc.maranget@inria.fr, akiyks@gmail.com, willy@infradead.org Message-ID: <20190110084024.9rNIm0msvqwxCIpiBWsszVNMqNJRT5UgHcLVuc_iifU@z> > > > > It seems that > > > > > > > > 1b52d0186177 ("tools/memory-model: Model smp_mb__after_unlock_lock()") > > > > > > > > from linux-rcu/dev got lost; this also needs an ack (probably yours! ;D, > > > > considered that, IIRC, you introduced the primitive and RCU is currently > > > > its only user.) > > > > > > That commit is in -tip: > > > > > > 4607abbcf464 ("tools/memory-model: Model smp_mb__after_unlock_lock()") > > > > > > So it has already left my -rcu tree. ;-) > > > > Oh, you're right: now I see the commit (e.g., with "git show"), but I > > don't see the corresponding changes applied to the tree. > > > > https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?h=locking/core&id=4607abbcf464ea2be14da444215d05c73025cf6e > > https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/tree/tools/memory-model/linux-kernel.bell?h=locking/core > > > > Is this expected? > > Are you asking why it is in -tip but not in mainline? I am not sure, > but given that the merge window was over the holiday season and that > the length of the merge window proved to be shorter than many people > expected it to be, I am not too surprised. ;-) Mmh, let me try again: $ git clone git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git $ cd tip $ git checkout -b locking/core origin/locking/core $ git show 4607abbcf464 commit 4607abbcf464ea2be14da444215d05c73025cf6e Author: Andrea Parri Date: Mon Dec 3 15:04:49 2018 -0800 tools/memory-model: Model smp_mb__after_unlock_lock() $ cd tools/memory-model $ herd7 -conf linux-kernel.cfg after-unlock-lock-same-cpu.litmus File "after-unlock-lock-same-cpu.litmus": Unknown macro smp_mb__after_unlock_lock (User error) [aka, linux-kernel.def in tip:locking/core does not have the smp_mb__after_unlock_lock() added by 4607abbcf464] Andrea > > Thanx, Paul >