From: Will Deacon <will.deacon@arm.com>
To: Firoz Khan <firoz.khan@linaro.org>
Cc: Kate Stewart <kstewart@linuxfoundation.org>,
linux-arch@vger.kernel.org, arnd@arndb.de,
y2038@lists.linaro.org, Catalin Marinas <catalin.marinas@arm.com>,
Philippe Ombredanne <pombredanne@nexb.com>,
linux-kernel@vger.kernel.org, Stefan Agner <stefan@agner.ch>,
marcin.juszkiewicz@linaro.org,
Russell King <rmk+kernel@armlinux.org.uk>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
deepa.kernel@gmail.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/3] arm64: system call table generation for asm-generic
Date: Sat, 19 Jan 2019 23:56:52 +0000 [thread overview]
Message-ID: <20190119235650.GC26876@brain-police> (raw)
In-Reply-To: <1546530025-26014-1-git-send-email-firoz.khan@linaro.org>
On Thu, Jan 03, 2019 at 09:10:22PM +0530, Firoz Khan wrote:
> This will be an automated scripts to provide easy support
> for add/modify/delete the system call entry by add in
> respective *.tbl file.
>
> System call table generation support for asm-generic is
> provide for arm64 architecture which will use the common
> scripts resides in scripts directory and use syscall.tbl
> syscall_arm32.tbl files as inputs. This implementation
> will replace asm-generic/unistd.h.
>
> This patch depends on:
> https://lore.kernel.org/lkml/1546439331-18646-1-git-send-email-firoz.khan@linaro.org/
> https://lore.kernel.org/lkml/1546520681-24453-1-git-send-email-firoz.khan@linaro.org/
I'm having a hard time understanding what the benefit of this series is,
given that we only support EABI compat tasks. When adding a new compat
system call, you can't just blindly hook it up without checking whether it
needs a wrapper to deal with any type conversion etc, so really we're just
replacing one table with another as far as I can tell. What am I missing?
I also really don't think we should be generating the 32-bit UAPI headers
from the 64-bit compat system call support (if that's what you're trying to
do -- make headers_check fails with your patches applied). arch/arm/ is the
canonical place for the 32-bit UAPI, and we're just implementing that.
Will
_______________________________________________
Y2038 mailing list
Y2038@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/y2038
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Firoz Khan <firoz.khan@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Stefan Agner <stefan@agner.ch>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Russell King <rmk+kernel@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Philippe Ombredanne <pombredanne@nexb.com>,
Thomas Gleixner <tglx@linutronix.de>,
Kate Stewart <kstewart@linuxfoundation.org>,
y2038@lists.linaro.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, arnd@arndb.de,
deepa.kernel@gmail.com, marcin.juszkiewicz@linaro.org
Subject: Re: [PATCH 0/3] arm64: system call table generation for asm-generic
Date: Sat, 19 Jan 2019 23:56:52 +0000 [thread overview]
Message-ID: <20190119235650.GC26876@brain-police> (raw)
Message-ID: <20190119235652.sZzQzCROqiRInAGHiQgp9ayJpjzvBKCnILsby7xgaDs@z> (raw)
In-Reply-To: <1546530025-26014-1-git-send-email-firoz.khan@linaro.org>
On Thu, Jan 03, 2019 at 09:10:22PM +0530, Firoz Khan wrote:
> This will be an automated scripts to provide easy support
> for add/modify/delete the system call entry by add in
> respective *.tbl file.
>
> System call table generation support for asm-generic is
> provide for arm64 architecture which will use the common
> scripts resides in scripts directory and use syscall.tbl
> syscall_arm32.tbl files as inputs. This implementation
> will replace asm-generic/unistd.h.
>
> This patch depends on:
> https://lore.kernel.org/lkml/1546439331-18646-1-git-send-email-firoz.khan@linaro.org/
> https://lore.kernel.org/lkml/1546520681-24453-1-git-send-email-firoz.khan@linaro.org/
I'm having a hard time understanding what the benefit of this series is,
given that we only support EABI compat tasks. When adding a new compat
system call, you can't just blindly hook it up without checking whether it
needs a wrapper to deal with any type conversion etc, so really we're just
replacing one table with another as far as I can tell. What am I missing?
I also really don't think we should be generating the 32-bit UAPI headers
from the 64-bit compat system call support (if that's what you're trying to
do -- make headers_check fails with your patches applied). arch/arm/ is the
canonical place for the 32-bit UAPI, and we're just implementing that.
Will
next prev parent reply other threads:[~2019-01-19 23:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 15:40 [PATCH 0/3] arm64: system call table generation for asm-generic Firoz Khan
2019-01-03 15:40 ` Firoz Khan
2019-01-03 15:40 ` [PATCH 1/3] arm64: add system call table generation files Firoz Khan
2019-01-03 15:40 ` Firoz Khan
2019-01-03 15:40 ` [PATCH 2/3] arm64: assign __NR_*_Linux_syscalls generated by the scripts Firoz Khan
2019-01-03 15:40 ` Firoz Khan
2019-01-03 15:40 ` [PATCH 3/3] arm64: generate uapi and kapi headers Firoz Khan
2019-01-03 15:40 ` Firoz Khan
2019-01-04 17:40 ` kbuild test robot
2019-01-19 23:56 ` Will Deacon [this message]
2019-01-19 23:56 ` [PATCH 0/3] arm64: system call table generation for asm-generic Will Deacon
2019-01-21 15:53 ` Arnd Bergmann
2019-01-21 15:53 ` Arnd Bergmann
2019-01-22 4:17 ` Firoz Khan
2019-01-22 4:17 ` Firoz Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190119235650.GC26876@brain-police \
--to=will.deacon@arm.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=deepa.kernel@gmail.com \
--cc=firoz.khan@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.juszkiewicz@linaro.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=pombredanne@nexb.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=stefan@agner.ch \
--cc=tglx@linutronix.de \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox