From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [PATCH 0/3] arm64: system call table generation for asm-generic Date: Sat, 19 Jan 2019 23:56:52 +0000 Message-ID: <20190119235650.GC26876@brain-police> References: <1546530025-26014-1-git-send-email-firoz.khan@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1546530025-26014-1-git-send-email-firoz.khan@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: y2038-bounces@lists.linaro.org Sender: "Y2038" To: Firoz Khan Cc: Kate Stewart , linux-arch@vger.kernel.org, arnd@arndb.de, y2038@lists.linaro.org, Catalin Marinas , Philippe Ombredanne , linux-kernel@vger.kernel.org, Stefan Agner , marcin.juszkiewicz@linaro.org, Russell King , Mathieu Desnoyers , deepa.kernel@gmail.com, Greg Kroah-Hartman , Thomas Gleixner , linux-arm-kernel@lists.infradead.org List-Id: linux-arch.vger.kernel.org T24gVGh1LCBKYW4gMDMsIDIwMTkgYXQgMDk6MTA6MjJQTSArMDUzMCwgRmlyb3ogS2hhbiB3cm90 ZToKPiBUaGlzIHdpbGwgYmUgYW4gYXV0b21hdGVkIHNjcmlwdHMgdG8gcHJvdmlkZSBlYXN5IHN1 cHBvcnQKPiBmb3IgYWRkL21vZGlmeS9kZWxldGUgdGhlIHN5c3RlbSBjYWxsIGVudHJ5IGJ5IGFk ZCBpbiAKPiByZXNwZWN0aXZlICoudGJsIGZpbGUuCj4gCj4gU3lzdGVtIGNhbGwgdGFibGUgZ2Vu ZXJhdGlvbiBzdXBwb3J0IGZvciBhc20tZ2VuZXJpYyBpcwo+IHByb3ZpZGUgZm9yIGFybTY0IGFy Y2hpdGVjdHVyZSB3aGljaCB3aWxsIHVzZSB0aGUgY29tbW9uCj4gc2NyaXB0cyByZXNpZGVzIGlu IHNjcmlwdHMgZGlyZWN0b3J5IGFuZCB1c2Ugc3lzY2FsbC50YmwKPiBzeXNjYWxsX2FybTMyLnRi bCBmaWxlcyBhcyBpbnB1dHMuIFRoaXMgaW1wbGVtZW50YXRpb24gCj4gd2lsbCByZXBsYWNlIGFz bS1nZW5lcmljL3VuaXN0ZC5oLgo+IAo+IFRoaXMgcGF0Y2ggZGVwZW5kcyBvbjoKPiAgaHR0cHM6 Ly9sb3JlLmtlcm5lbC5vcmcvbGttbC8xNTQ2NDM5MzMxLTE4NjQ2LTEtZ2l0LXNlbmQtZW1haWwt Zmlyb3oua2hhbkBsaW5hcm8ub3JnLwo+ICBodHRwczovL2xvcmUua2VybmVsLm9yZy9sa21sLzE1 NDY1MjA2ODEtMjQ0NTMtMS1naXQtc2VuZC1lbWFpbC1maXJvei5raGFuQGxpbmFyby5vcmcvCgpJ J20gaGF2aW5nIGEgaGFyZCB0aW1lIHVuZGVyc3RhbmRpbmcgd2hhdCB0aGUgYmVuZWZpdCBvZiB0 aGlzIHNlcmllcyBpcywKZ2l2ZW4gdGhhdCB3ZSBvbmx5IHN1cHBvcnQgRUFCSSBjb21wYXQgdGFz a3MuIFdoZW4gYWRkaW5nIGEgbmV3IGNvbXBhdApzeXN0ZW0gY2FsbCwgeW91IGNhbid0IGp1c3Qg YmxpbmRseSBob29rIGl0IHVwIHdpdGhvdXQgY2hlY2tpbmcgd2hldGhlciBpdApuZWVkcyBhIHdy YXBwZXIgdG8gZGVhbCB3aXRoIGFueSB0eXBlIGNvbnZlcnNpb24gZXRjLCBzbyByZWFsbHkgd2Un cmUganVzdApyZXBsYWNpbmcgb25lIHRhYmxlIHdpdGggYW5vdGhlciBhcyBmYXIgYXMgSSBjYW4g dGVsbC4gV2hhdCBhbSBJIG1pc3Npbmc/CgpJIGFsc28gcmVhbGx5IGRvbid0IHRoaW5rIHdlIHNo b3VsZCBiZSBnZW5lcmF0aW5nIHRoZSAzMi1iaXQgVUFQSSBoZWFkZXJzCmZyb20gdGhlIDY0LWJp dCBjb21wYXQgc3lzdGVtIGNhbGwgc3VwcG9ydCAoaWYgdGhhdCdzIHdoYXQgeW91J3JlIHRyeWlu ZyB0bwpkbyAtLSBtYWtlIGhlYWRlcnNfY2hlY2sgZmFpbHMgd2l0aCB5b3VyIHBhdGNoZXMgYXBw bGllZCkuIGFyY2gvYXJtLyBpcyB0aGUKY2Fub25pY2FsIHBsYWNlIGZvciB0aGUgMzItYml0IFVB UEksIGFuZCB3ZSdyZSBqdXN0IGltcGxlbWVudGluZyB0aGF0LgoKV2lsbApfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpZMjAzOCBtYWlsaW5nIGxpc3QKWTIw MzhAbGlzdHMubGluYXJvLm9yZwpodHRwczovL2xpc3RzLmxpbmFyby5vcmcvbWFpbG1hbi9saXN0 aW5mby95MjAzOAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:46680 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729803AbfASX5B (ORCPT ); Sat, 19 Jan 2019 18:57:01 -0500 Date: Sat, 19 Jan 2019 23:56:52 +0000 From: Will Deacon Subject: Re: [PATCH 0/3] arm64: system call table generation for asm-generic Message-ID: <20190119235650.GC26876@brain-police> References: <1546530025-26014-1-git-send-email-firoz.khan@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1546530025-26014-1-git-send-email-firoz.khan@linaro.org> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Firoz Khan Cc: Catalin Marinas , Stefan Agner , Mathieu Desnoyers , Russell King , linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman , Philippe Ombredanne , Thomas Gleixner , Kate Stewart , y2038@lists.linaro.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, arnd@arndb.de, deepa.kernel@gmail.com, marcin.juszkiewicz@linaro.org Message-ID: <20190119235652.sZzQzCROqiRInAGHiQgp9ayJpjzvBKCnILsby7xgaDs@z> On Thu, Jan 03, 2019 at 09:10:22PM +0530, Firoz Khan wrote: > This will be an automated scripts to provide easy support > for add/modify/delete the system call entry by add in > respective *.tbl file. > > System call table generation support for asm-generic is > provide for arm64 architecture which will use the common > scripts resides in scripts directory and use syscall.tbl > syscall_arm32.tbl files as inputs. This implementation > will replace asm-generic/unistd.h. > > This patch depends on: > https://lore.kernel.org/lkml/1546439331-18646-1-git-send-email-firoz.khan@linaro.org/ > https://lore.kernel.org/lkml/1546520681-24453-1-git-send-email-firoz.khan@linaro.org/ I'm having a hard time understanding what the benefit of this series is, given that we only support EABI compat tasks. When adding a new compat system call, you can't just blindly hook it up without checking whether it needs a wrapper to deal with any type conversion etc, so really we're just replacing one table with another as far as I can tell. What am I missing? I also really don't think we should be generating the 32-bit UAPI headers from the 64-bit compat system call support (if that's what you're trying to do -- make headers_check fails with your patches applied). arch/arm/ is the canonical place for the 32-bit UAPI, and we're just implementing that. Will