From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [PATCH v6 15/27] compiler: Option to default to hidden symbols Date: Fri, 1 Feb 2019 10:12:59 +0300 Message-ID: <20190201071259.GB14343@kadam> References: <20190131192533.34130-1-thgarnie@chromium.org> <20190131192533.34130-16-thgarnie@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Content-Disposition: inline In-Reply-To: <20190131192533.34130-16-thgarnie@chromium.org> To: Thomas Garnier Cc: kernel-hardening@lists.openwall.com, kristen@linux.intel.com, Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , x86@kernel.org, Luis Chamberlain , Greg Kroah-Hartman , "Rafael J. Wysocki" , Arnd Bergmann , Luc Van Oostenryck , Steven Rostedt , Jason Baron , Thomas Garnier , Jordan Borgner , Masami Hiramatsu , Masahiro Yamada , "Peter Zijlstra (Intel)" , Andrew Morton , Kees Cook List-Id: linux-arch.vger.kernel.org On Thu, Jan 31, 2019 at 11:24:22AM -0800, Thomas Garnier wrote: > Provide an option to default visibility to hidden except for key > symbols. It took me a while to figure out the verb in this sentence... :P It's weird that we're annotating things to be default. What visibility are they we leave off the annotation? regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from aserp2130.oracle.com ([141.146.126.79]:49290 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726092AbfBAHPC (ORCPT ); Fri, 1 Feb 2019 02:15:02 -0500 Date: Fri, 1 Feb 2019 10:12:59 +0300 From: Dan Carpenter Subject: Re: [PATCH v6 15/27] compiler: Option to default to hidden symbols Message-ID: <20190201071259.GB14343@kadam> References: <20190131192533.34130-1-thgarnie@chromium.org> <20190131192533.34130-16-thgarnie@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190131192533.34130-16-thgarnie@chromium.org> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Thomas Garnier Cc: kernel-hardening@lists.openwall.com, kristen@linux.intel.com, Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , x86@kernel.org, Luis Chamberlain , Greg Kroah-Hartman , "Rafael J. Wysocki" , Arnd Bergmann , Luc Van Oostenryck , Steven Rostedt , Jason Baron , Thomas Garnier , Jordan Borgner , Masami Hiramatsu , Masahiro Yamada , "Peter Zijlstra (Intel)" , Andrew Morton , Kees Cook , Mathieu Desnoyers , Arnaldo Carvalho de Melo , Andi Kleen , Jan Beulich , Song Liu , Adrian Hunter , Alexander Shishkin , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-sparse@vger.kernel.org Message-ID: <20190201071259.bHEtLl6OCTGwsQrbTeT0o6qyEng5NXwUs16e5H7erDk@z> On Thu, Jan 31, 2019 at 11:24:22AM -0800, Thomas Garnier wrote: > Provide an option to default visibility to hidden except for key > symbols. It took me a while to figure out the verb in this sentence... :P It's weird that we're annotating things to be default. What visibility are they we leave off the annotation? regards, dan carpenter