From: Christoph Hellwig <hch@lst.de>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Kr���m������" <rkrcmar@redhat.com>,
kvm@vger.kernel.org, linux-arch <linux-arch@vger.kernel.org>,
"Palmer Dabbelt" <palmer@sifive.com>,
"Greentime Hu" <green.hu@gmail.com>,
"Vincent Chen" <deanbo422@gmail.com>,
"Arnd Bergmann" <arnd@arndb.de>, "Joerg Roedel" <joro@8bytes.org>,
"Christoffer Dall" <christoffer.dall@arm.com>,
"Marc Zyngier" <marc.zyngier@arm.com>,
"James Hogan" <jhogan@kernel.org>,
"Paul Mackerras" <paulus@ozlabs.org>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
"Janosch Frank" <frankja@linux.ibm.com>,
"Christoph Hellwig" <hch@lst.de>,
"Sam Ravnborg" <sam@ravnborg.org>
Subject: Re: [PATCH] KVM: export <linux/kvm_para.h> and <asm/kvm_para.h> for all architectures
Date: Mon, 4 Feb 2019 09:26:09 +0100 [thread overview]
Message-ID: <20190204082609.GB5953@lst.de> (raw)
In-Reply-To: <1549252517-23834-1-git-send-email-yamada.masahiro@socionext.com>
On Mon, Feb 04, 2019 at 12:55:16PM +0900, Masahiro Yamada wrote:
> We have two ways to fix this inconsistency:
>
> [A] export both <linux/kvm_para.h> and <asm/kvm_para.h> for all
> architectures, irrespective of the KVM support
>
> [B] Match the header export of <linux/kvm_para.h> and <asm/kvm_para.h>
> to the KVM support
>
> This commit adopts [A].
>
> Remove 'no-export-headers' from include/uapi/linux/Kbuild to export
> <linux/kvm_para.h> for all architectures.
>
> Add 'mandatory-y' to include/uapi/asm-generic/Kbuild.asm to export
> <asm/kvm_para.h> for all architectures. If arch does not have specific
> implementation, a wrapper file to <asm-generic/kvm_para.h> is
> automatically generated, and exported.
>
> include/uapi/asm-generic/kvm_para.h is just a empty file. I cleaned
> up empty <asm/kvm_para.h> stubs.
Thanks, this look so much cleaner than what we had before!
Acked-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2019-02-04 8:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 3:55 [PATCH] KVM: export <linux/kvm_para.h> and <asm/kvm_para.h> for all architectures Masahiro Yamada
2019-02-04 8:26 ` Christoph Hellwig [this message]
2019-02-05 12:13 ` Paolo Bonzini
2019-02-06 5:21 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190204082609.GB5953@lst.de \
--to=hch@lst.de \
--cc=arnd@arndb.de \
--cc=borntraeger@de.ibm.com \
--cc=christoffer.dall@arm.com \
--cc=deanbo422@gmail.com \
--cc=frankja@linux.ibm.com \
--cc=green.hu@gmail.com \
--cc=jhogan@kernel.org \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=palmer@sifive.com \
--cc=paulus@ozlabs.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=sam@ravnborg.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox