From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/3] drm: tweak header name Date: Fri, 8 Feb 2019 09:56:59 +0100 Message-ID: <20190208085659.GI23159@phenom.ffwll.local> References: <20190124142448.23243-1-mst@redhat.com> <20190124142448.23243-4-mst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190124142448.23243-4-mst@redhat.com> Sender: linux-kernel-owner@vger.kernel.org To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Arnd Bergmann , Maarten Lankhorst , Maxime Ripard , Sean Paul , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org List-Id: linux-arch.vger.kernel.org On Fri, Feb 08, 2019 at 01:02:58AM -0500, Michael S. Tsirkin wrote: > Use linux/mman.h to make sure we get all mmap flags we need. > > Signed-off-by: Michael S. Tsirkin drmP.h is seriously deprecated (and a monster mess). If this fixes anything, I think would be better to include the right header in the right places, and leave drmP.h to die quietly ... What exactly does this fix? -Daniel > --- > include/drm/drmP.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/include/drm/drmP.h b/include/drm/drmP.h > index bdb0d5548f39..a3184416ddc5 100644 > --- a/include/drm/drmP.h > +++ b/include/drm/drmP.h > @@ -57,8 +57,7 @@ > #include > #include > #include > - > -#include > +#include > #include > #include > > -- > MST > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f68.google.com ([209.85.208.68]:42997 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727168AbfBHI5E (ORCPT ); Fri, 8 Feb 2019 03:57:04 -0500 Received: by mail-ed1-f68.google.com with SMTP id r15so2106678eds.9 for ; Fri, 08 Feb 2019 00:57:03 -0800 (PST) Date: Fri, 8 Feb 2019 09:56:59 +0100 From: Daniel Vetter Subject: Re: [PATCH 2/3] drm: tweak header name Message-ID: <20190208085659.GI23159@phenom.ffwll.local> References: <20190124142448.23243-1-mst@redhat.com> <20190124142448.23243-4-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190124142448.23243-4-mst@redhat.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Arnd Bergmann , Maarten Lankhorst , Maxime Ripard , Sean Paul , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Message-ID: <20190208085659.spC94OFRVOSIOwaE5fhNNJElJGCZ9JU3gthX2f2Filk@z> On Fri, Feb 08, 2019 at 01:02:58AM -0500, Michael S. Tsirkin wrote: > Use linux/mman.h to make sure we get all mmap flags we need. > > Signed-off-by: Michael S. Tsirkin drmP.h is seriously deprecated (and a monster mess). If this fixes anything, I think would be better to include the right header in the right places, and leave drmP.h to die quietly ... What exactly does this fix? -Daniel > --- > include/drm/drmP.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/include/drm/drmP.h b/include/drm/drmP.h > index bdb0d5548f39..a3184416ddc5 100644 > --- a/include/drm/drmP.h > +++ b/include/drm/drmP.h > @@ -57,8 +57,7 @@ > #include > #include > #include > - > -#include > +#include > #include > #include > > -- > MST > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch