From: "Michael S. Tsirkin" <mst@redhat.com>
To: Borislav Petkov <bp@alien8.de>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
Arnd Bergmann <arnd@arndb.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org
Subject: Re: [PATCH 1/3] x86/mpx: tweak header name
Date: Sat, 9 Feb 2019 19:20:48 -0500 [thread overview]
Message-ID: <20190209191723-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20190208215232.GN674@zn.tnic>
On Fri, Feb 08, 2019 at 10:52:32PM +0100, Borislav Petkov wrote:
> On Fri, Feb 08, 2019 at 04:43:37PM -0500, Michael S. Tsirkin wrote:
> > Coding style violation: if a linux/foo.h exists then it must
> > be included in preference to asm/foo.h
> >
> > And the specific issue is that a follow-up patch moves code from
> > asm/mman.h to linux/mman.h so if any one was indirectly using
> > this header it will now miss the symbols that are being moved.
>
> Ok, so first of all, this should be your commit message - not what you
> have there now.
>
> Then, please send full patchsets to recipients - I have only this patch
> in my mbox and have no clue what the whole patchset is addressing.
I can copy you on all patches, sure.
> Further, do you want an ACK only or should I pick this up?
If you can pick it up then great.
> Finally, this whole file is going away:
>
> https://lkml.kernel.org/r/7de5232f-4bc1-5c85-00d5-cb646462577f@intel.com
>
> so your patch might become obsolete by then. Depends on what goes first.
>
> Thx.
> --
> Regards/Gruss,
> Boris.
>
> Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2019-02-10 0:20 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 6:02 [PATCH 0/3] generic asm: mman cleanup Michael S. Tsirkin
2019-02-08 6:02 ` Michael S. Tsirkin
2019-02-08 6:02 ` [PATCH 1/3] x86/mpx: tweak header name Michael S. Tsirkin
2019-02-08 6:02 ` Michael S. Tsirkin
2019-02-08 15:42 ` Borislav Petkov
2019-02-08 15:42 ` Borislav Petkov
2019-02-08 21:43 ` Michael S. Tsirkin
2019-02-08 21:43 ` Michael S. Tsirkin
2019-02-08 21:50 ` Dave Hansen
2019-02-08 21:50 ` Dave Hansen
2019-02-08 21:52 ` Borislav Petkov
2019-02-08 21:52 ` Borislav Petkov
2019-02-10 0:20 ` Michael S. Tsirkin [this message]
2019-02-10 0:20 ` Michael S. Tsirkin
2019-02-08 6:02 ` [PATCH 2/2] arch: move common mmap flags to linux/mman.h Michael S. Tsirkin
2019-02-08 6:02 ` Michael S. Tsirkin
2019-02-08 6:02 ` [PATCH 2/3] drm: tweak header name Michael S. Tsirkin
2019-02-08 6:02 ` Michael S. Tsirkin
2019-02-08 8:56 ` Daniel Vetter
2019-02-08 8:56 ` Daniel Vetter
2019-02-08 12:55 ` Michael S. Tsirkin
2019-02-08 12:55 ` Michael S. Tsirkin
2019-02-08 6:03 ` [PATCH 3/3] arch: move common mmap flags to linux/mman.h Michael S. Tsirkin
2019-02-08 6:03 ` Michael S. Tsirkin
2019-02-08 18:12 ` [PATCH 0/3] generic asm: mman cleanup Mike Rapoport
2019-02-08 18:12 ` Mike Rapoport
2019-02-08 21:19 ` Michael S. Tsirkin
2019-02-08 21:19 ` Michael S. Tsirkin
2019-02-11 4:20 ` Michael S. Tsirkin
2019-02-11 4:20 ` Michael S. Tsirkin
2019-02-18 14:03 ` Arnd Bergmann
2019-02-18 14:03 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190209191723-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox