* void __iomem *addr should be const
@ 2019-02-10 12:29 Hugo Lefeuvre
2019-02-10 12:29 ` Hugo Lefeuvre
2019-02-16 19:16 ` Thomas Gleixner
0 siblings, 2 replies; 6+ messages in thread
From: Hugo Lefeuvre @ 2019-02-10 12:29 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: linux-arch, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 719 bytes --]
Hi,
__iomem *addr seems to lack a const qualifier in the ioread* definitions
from include/asm-generic/iomap.h (other definitions such as
asm-generic/io.h do have the const).
This issue was briefly discussed a while ago[0] but the outcome is not
quite clear to me. Should I submit a patch addressing this issue or is it
a definitive wontfix?
This issue triggers warnings in my current work but I would like to avoid
dropping the const if possible.
regards,
Hugo
[0] https://patchwork.kernel.org/patch/5742881/
--
Hugo Lefeuvre (hle) | www.owl.eu.com
RSA4096_ 360B 03B3 BF27 4F4D 7A3F D5E8 14AA 1EB8 A247 3DFD
ed25519_ 37B2 6D38 0B25 B8A2 6B9F 3A65 A36F 5357 5F2D DC4C
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* void __iomem *addr should be const
2019-02-10 12:29 void __iomem *addr should be const Hugo Lefeuvre
@ 2019-02-10 12:29 ` Hugo Lefeuvre
2019-02-16 19:16 ` Thomas Gleixner
1 sibling, 0 replies; 6+ messages in thread
From: Hugo Lefeuvre @ 2019-02-10 12:29 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: linux-arch, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 719 bytes --]
Hi,
__iomem *addr seems to lack a const qualifier in the ioread* definitions
from include/asm-generic/iomap.h (other definitions such as
asm-generic/io.h do have the const).
This issue was briefly discussed a while ago[0] but the outcome is not
quite clear to me. Should I submit a patch addressing this issue or is it
a definitive wontfix?
This issue triggers warnings in my current work but I would like to avoid
dropping the const if possible.
regards,
Hugo
[0] https://patchwork.kernel.org/patch/5742881/
--
Hugo Lefeuvre (hle) | www.owl.eu.com
RSA4096_ 360B 03B3 BF27 4F4D 7A3F D5E8 14AA 1EB8 A247 3DFD
ed25519_ 37B2 6D38 0B25 B8A2 6B9F 3A65 A36F 5357 5F2D DC4C
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: void __iomem *addr should be const
2019-02-10 12:29 void __iomem *addr should be const Hugo Lefeuvre
2019-02-10 12:29 ` Hugo Lefeuvre
@ 2019-02-16 19:16 ` Thomas Gleixner
2019-02-16 19:16 ` Thomas Gleixner
2019-02-16 20:49 ` Hugo Lefeuvre
1 sibling, 2 replies; 6+ messages in thread
From: Thomas Gleixner @ 2019-02-16 19:16 UTC (permalink / raw)
To: Hugo Lefeuvre; +Cc: Arnd Bergmann, linux-arch, linux-kernel
On Sun, 10 Feb 2019, Hugo Lefeuvre wrote:
> __iomem *addr seems to lack a const qualifier in the ioread* definitions
> from include/asm-generic/iomap.h (other definitions such as
> asm-generic/io.h do have the const).
>
> This issue was briefly discussed a while ago[0] but the outcome is not
> quite clear to me. Should I submit a patch addressing this issue or is it
> a definitive wontfix?
>
> This issue triggers warnings in my current work but I would like to avoid
> dropping the const if possible.
The const makes perfectly sense and we should have consistent state all
over the place.
Thanks,
tglx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: void __iomem *addr should be const
2019-02-16 19:16 ` Thomas Gleixner
@ 2019-02-16 19:16 ` Thomas Gleixner
2019-02-16 20:49 ` Hugo Lefeuvre
1 sibling, 0 replies; 6+ messages in thread
From: Thomas Gleixner @ 2019-02-16 19:16 UTC (permalink / raw)
To: Hugo Lefeuvre; +Cc: Arnd Bergmann, linux-arch, linux-kernel
On Sun, 10 Feb 2019, Hugo Lefeuvre wrote:
> __iomem *addr seems to lack a const qualifier in the ioread* definitions
> from include/asm-generic/iomap.h (other definitions such as
> asm-generic/io.h do have the const).
>
> This issue was briefly discussed a while ago[0] but the outcome is not
> quite clear to me. Should I submit a patch addressing this issue or is it
> a definitive wontfix?
>
> This issue triggers warnings in my current work but I would like to avoid
> dropping the const if possible.
The const makes perfectly sense and we should have consistent state all
over the place.
Thanks,
tglx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: void __iomem *addr should be const
2019-02-16 19:16 ` Thomas Gleixner
2019-02-16 19:16 ` Thomas Gleixner
@ 2019-02-16 20:49 ` Hugo Lefeuvre
2019-02-16 20:49 ` Hugo Lefeuvre
1 sibling, 1 reply; 6+ messages in thread
From: Hugo Lefeuvre @ 2019-02-16 20:49 UTC (permalink / raw)
To: Thomas Gleixner; +Cc: Arnd Bergmann, linux-arch, linux-kernel
Hi,
> The const makes perfectly sense and we should have consistent state all
> over the place.
Thanks, I will submit a patch addressing this issue soon.
regards,
Hugo
--
Hugo Lefeuvre (hle) | www.owl.eu.com
RSA4096_ 360B 03B3 BF27 4F4D 7A3F D5E8 14AA 1EB8 A247 3DFD
ed25519_ 37B2 6D38 0B25 B8A2 6B9F 3A65 A36F 5357 5F2D DC4C
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: void __iomem *addr should be const
2019-02-16 20:49 ` Hugo Lefeuvre
@ 2019-02-16 20:49 ` Hugo Lefeuvre
0 siblings, 0 replies; 6+ messages in thread
From: Hugo Lefeuvre @ 2019-02-16 20:49 UTC (permalink / raw)
To: Thomas Gleixner; +Cc: Arnd Bergmann, linux-arch, linux-kernel
Hi,
> The const makes perfectly sense and we should have consistent state all
> over the place.
Thanks, I will submit a patch addressing this issue soon.
regards,
Hugo
--
Hugo Lefeuvre (hle) | www.owl.eu.com
RSA4096_ 360B 03B3 BF27 4F4D 7A3F D5E8 14AA 1EB8 A247 3DFD
ed25519_ 37B2 6D38 0B25 B8A2 6B9F 3A65 A36F 5357 5F2D DC4C
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-02-16 20:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-10 12:29 void __iomem *addr should be const Hugo Lefeuvre
2019-02-10 12:29 ` Hugo Lefeuvre
2019-02-16 19:16 ` Thomas Gleixner
2019-02-16 19:16 ` Thomas Gleixner
2019-02-16 20:49 ` Hugo Lefeuvre
2019-02-16 20:49 ` Hugo Lefeuvre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox