From: Hugo Lefeuvre <hle@owl.eu.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: kbuild test robot <lkp@intel.com>,
kbuild-all@01.org, linux-arch <linux-arch@vger.kernel.org>
Subject: Re: [asm-generic:master 4/6] lib/iomap.c:198:48: warning: passing argument 1 of 'mmio_insb' discards 'const' qualifier from pointer target type
Date: Mon, 18 Feb 2019 22:59:08 +0100 [thread overview]
Message-ID: <20190218215908.GC18457@behemoth.owl.eu.com.local> (raw)
In-Reply-To: <CAK8P3a3fs=pcQBcB+sGFfuK-pQ-a6du-rJ_VQiyv1_FK2LW2oA@mail.gmail.com>
> It seems to be a result of applying the patches in the wrong order, in
> particular
> 'iomap: add missing const to ioread*/iowrite addr arg' before 'lib/iomap: add
> missing const to mmio_ins* addr arg'. I've swapped them around now
> and uploaded the new branch.
>
> Hugo, could you check
> git://git.kernel.org/pub/scm/linux/kernel/git/arnd/asm-generic.git
> that it still makes sense to you?
Agree. However the first error will require an additional patch. ioread()
definitions from arch/ almost always omit the const[0], leading to
conflicting types...
I guess we should just add the missing const to arch/ definitions. The
patch is very simple anyways... Should I submit it separately or update the
applied patch set?
[0] https://elixir.bootlin.com/linux/latest/ident/ioread32
--
Hugo Lefeuvre (hle) | www.owl.eu.com
RSA4096_ 360B 03B3 BF27 4F4D 7A3F D5E8 14AA 1EB8 A247 3DFD
ed25519_ 37B2 6D38 0B25 B8A2 6B9F 3A65 A36F 5357 5F2D DC4C
prev parent reply other threads:[~2019-02-18 21:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-18 18:20 [asm-generic:master 4/6] lib/iomap.c:198:48: warning: passing argument 1 of 'mmio_insb' discards 'const' qualifier from pointer target type kbuild test robot
2019-02-18 21:17 ` Arnd Bergmann
2019-02-18 21:59 ` Hugo Lefeuvre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190218215908.GC18457@behemoth.owl.eu.com.local \
--to=hle@owl.eu.com \
--cc=arnd@arndb.de \
--cc=kbuild-all@01.org \
--cc=linux-arch@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox