From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Rutland Subject: Re: [PATCH v5 19/23] arm64: Enable compat vDSO support Date: Fri, 22 Feb 2019 14:41:54 +0000 Message-ID: <20190222144154.GO42419@lakrids.cambridge.arm.com> References: <20190222122430.21180-1-vincenzo.frascino@arm.com> <20190222122430.21180-20-vincenzo.frascino@arm.com> <20190222143957.GN42419@lakrids.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20190222143957.GN42419@lakrids.cambridge.arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Vincenzo Frascino Cc: linux-arch@vger.kernel.org, Shuah Khan , Arnd Bergmann , Catalin Marinas , Daniel Lezcano , Will Deacon , Russell King , Ralf Baechle , Mark Salyzyn , Paul Burton , Dmitry Safonov <0x7f454c46@gmail.com>, Rasmus Villemoes , Thomas Gleixner , Peter Collingbourne , linux-arm-kernel@lists.infradead.org List-Id: linux-arch.vger.kernel.org On Fri, Feb 22, 2019 at 02:39:58PM +0000, Mark Rutland wrote: > On Fri, Feb 22, 2019 at 12:24:26PM +0000, Vincenzo Frascino wrote: > > Enable compat vDSO support in the arm64 defconfig. > > > > Note that the default compiler is set to arm-linux-gnueabihf-. > > For this to take effect and for the compat vDSO to compile correctly, it > > is required that this compiler is in the PATH. > > I do not have such a compiler in my path by default. > > I hope that we handle that gracefully, rather than causing a build > failure. > > Can't we detect the presence of the compat compiler at config time, as > happens for the native compiler? > > Thanks, > Mark. > > > > > Cc: Catalin Marinas > > Cc: Will Deacon > > Signed-off-by: Vincenzo Frascino > > --- > > arch/arm64/configs/defconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > > index c8432e24207e..3adebe5f3573 100644 > > --- a/arch/arm64/configs/defconfig > > +++ b/arch/arm64/configs/defconfig > > @@ -120,6 +120,7 @@ CONFIG_ACPI_APEI_MEMORY_FAILURE=y > > CONFIG_ACPI_APEI_EINJ=y > > CONFIG_VIRTUALIZATION=y > > CONFIG_KVM=y > > +CONFIG_CROSS_COMPILE_COMPAT_VDSO="arm-linux-gnueabihf-" Also, the kernel.org crosstool compilers are arm-linux-gnueabi-. Could we please avoid having a default, in the same way that we don't have a default for CROSS_COMPILE? Otherwise, it's always gongi to be wrong for someone, and we'll never be able to change it anyway. Thanks, Mark. > > CONFIG_ARM64_CRYPTO=y > > CONFIG_CRYPTO_SHA1_ARM64_CE=y > > CONFIG_CRYPTO_SHA2_ARM64_CE=y > > -- > > 2.20.1 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com ([217.140.101.70]:33626 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726278AbfBVOmA (ORCPT ); Fri, 22 Feb 2019 09:42:00 -0500 Date: Fri, 22 Feb 2019 14:41:54 +0000 From: Mark Rutland Subject: Re: [PATCH v5 19/23] arm64: Enable compat vDSO support Message-ID: <20190222144154.GO42419@lakrids.cambridge.arm.com> References: <20190222122430.21180-1-vincenzo.frascino@arm.com> <20190222122430.21180-20-vincenzo.frascino@arm.com> <20190222143957.GN42419@lakrids.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190222143957.GN42419@lakrids.cambridge.arm.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Vincenzo Frascino Cc: linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Arnd Bergmann , Russell King , Ralf Baechle , Paul Burton , Daniel Lezcano , Thomas Gleixner , Mark Salyzyn , Peter Collingbourne , Shuah Khan , Dmitry Safonov <0x7f454c46@gmail.com>, Rasmus Villemoes Message-ID: <20190222144154.ljTPkCXt2wNxODOTXFcBdiHgMm47X1KHIKmgvlybXJ0@z> On Fri, Feb 22, 2019 at 02:39:58PM +0000, Mark Rutland wrote: > On Fri, Feb 22, 2019 at 12:24:26PM +0000, Vincenzo Frascino wrote: > > Enable compat vDSO support in the arm64 defconfig. > > > > Note that the default compiler is set to arm-linux-gnueabihf-. > > For this to take effect and for the compat vDSO to compile correctly, it > > is required that this compiler is in the PATH. > > I do not have such a compiler in my path by default. > > I hope that we handle that gracefully, rather than causing a build > failure. > > Can't we detect the presence of the compat compiler at config time, as > happens for the native compiler? > > Thanks, > Mark. > > > > > Cc: Catalin Marinas > > Cc: Will Deacon > > Signed-off-by: Vincenzo Frascino > > --- > > arch/arm64/configs/defconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > > index c8432e24207e..3adebe5f3573 100644 > > --- a/arch/arm64/configs/defconfig > > +++ b/arch/arm64/configs/defconfig > > @@ -120,6 +120,7 @@ CONFIG_ACPI_APEI_MEMORY_FAILURE=y > > CONFIG_ACPI_APEI_EINJ=y > > CONFIG_VIRTUALIZATION=y > > CONFIG_KVM=y > > +CONFIG_CROSS_COMPILE_COMPAT_VDSO="arm-linux-gnueabihf-" Also, the kernel.org crosstool compilers are arm-linux-gnueabi-. Could we please avoid having a default, in the same way that we don't have a default for CROSS_COMPILE? Otherwise, it's always gongi to be wrong for someone, and we'll never be able to change it anyway. Thanks, Mark. > > CONFIG_ARM64_CRYPTO=y > > CONFIG_CRYPTO_SHA1_ARM64_CE=y > > CONFIG_CRYPTO_SHA2_ARM64_CE=y > > -- > > 2.20.1 > >