From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH v9 1/9] bitops: Introduce the for_each_set_clump8 macro Date: Mon, 11 Mar 2019 18:01:13 -0700 Message-ID: <20190311180113.c283fdbcba3df10db2c815aa@linux-foundation.org> References: <12b3a364ac7fc32194fa6f55911dd800aca92a56.1551598603.git.vilhelm.gray@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Linus Walleij Cc: William Breathitt Gray , "open list:GPIO SUBSYSTEM" , linux-arch@vger.kernel.org, "linux-kernel@vger.kernel.org" , Andy Shevchenko , Rasmus Villemoes , Masahiro Yamada , Bartosz Golaszewski , Linux ARM , Andy Shevchenko , Arnd Bergmann List-Id: linux-arch.vger.kernel.org On Fri, 8 Mar 2019 09:31:00 +0100 Linus Walleij wrote: > On Sun, Mar 3, 2019 at 8:47 AM William Breathitt Gray > wrote: > > > This macro iterates for each 8-bit group of bits (clump) with set bits, > > within a bitmap memory region. For each iteration, "start" is set to the > > bit offset of the found clump, while the respective clump value is > > stored to the location pointed by "clump". Additionally, the > > bitmap_get_value8 and bitmap_set_value8 functions are introduced to > > respectively get and set an 8-bit value in a bitmap memory region. > > > > Suggested-by: Andy Shevchenko > > Suggested-by: Rasmus Villemoes > > Cc: Arnd Bergmann > > Cc: Andrew Morton > > Reviewed-by: Andy Shevchenko > > Reviewed-by: Linus Walleij > > Signed-off-by: William Breathitt Gray > > Andrew: would you be OK with this being merged in v5.1? Yup. We have quite a few users there. I assume this will go via the gpio tree? Feel free to add Acked-by: Andrew Morton , although it probably isn't worth churning the git tree to do so at this late stage - your cvall. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:41144 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726167AbfCLBBQ (ORCPT ); Mon, 11 Mar 2019 21:01:16 -0400 Date: Mon, 11 Mar 2019 18:01:13 -0700 From: Andrew Morton Subject: Re: [PATCH v9 1/9] bitops: Introduce the for_each_set_clump8 macro Message-ID: <20190311180113.c283fdbcba3df10db2c815aa@linux-foundation.org> In-Reply-To: References: <12b3a364ac7fc32194fa6f55911dd800aca92a56.1551598603.git.vilhelm.gray@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Linus Walleij Cc: William Breathitt Gray , "open list:GPIO SUBSYSTEM" , linux-arch@vger.kernel.org, "linux-kernel@vger.kernel.org" , Andy Shevchenko , Rasmus Villemoes , Masahiro Yamada , Bartosz Golaszewski , Linux ARM , Andy Shevchenko , Arnd Bergmann Message-ID: <20190312010113.dnfVJpTb1cwzcJDv0_wUntNOqcBzuM_HRe4M6HbBSmc@z> On Fri, 8 Mar 2019 09:31:00 +0100 Linus Walleij wrote: > On Sun, Mar 3, 2019 at 8:47 AM William Breathitt Gray > wrote: > > > This macro iterates for each 8-bit group of bits (clump) with set bits, > > within a bitmap memory region. For each iteration, "start" is set to the > > bit offset of the found clump, while the respective clump value is > > stored to the location pointed by "clump". Additionally, the > > bitmap_get_value8 and bitmap_set_value8 functions are introduced to > > respectively get and set an 8-bit value in a bitmap memory region. > > > > Suggested-by: Andy Shevchenko > > Suggested-by: Rasmus Villemoes > > Cc: Arnd Bergmann > > Cc: Andrew Morton > > Reviewed-by: Andy Shevchenko > > Reviewed-by: Linus Walleij > > Signed-off-by: William Breathitt Gray > > Andrew: would you be OK with this being merged in v5.1? Yup. We have quite a few users there. I assume this will go via the gpio tree? Feel free to add Acked-by: Andrew Morton , although it probably isn't worth churning the git tree to do so at this late stage - your cvall.