From: "Dmitry V. Levin" <ldv@altlinux.org>
To: Guo Ren <guoren@kernel.org>
Cc: linux-arch@vger.kernel.org, ren_guo@c-sky.com,
strace-devel@lists.strace.io, arnd@arndb.de,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] csky: Update syscall_trace_enter/exit implementation
Date: Mon, 25 Mar 2019 18:27:23 +0300 [thread overview]
Message-ID: <20190325152722.GA23169@altlinux.org> (raw)
In-Reply-To: <20190325124154.GA2653@guoren-Inspiron-7460>
[-- Attachment #1: Type: text/plain, Size: 1268 bytes --]
On Mon, Mar 25, 2019 at 08:41:54PM +0800, Guo Ren wrote:
> On Mon, Mar 25, 2019 at 03:17:54PM +0300, Dmitry V. Levin wrote:
> > On Mon, Mar 25, 2019 at 08:03:39PM +0800, guoren@kernel.org wrote:
> > [...]
> > > diff --git a/arch/csky/include/uapi/asm/ptrace.h b/arch/csky/include/uapi/asm/ptrace.h
> > > index a4eaa8d..9bf5b1a 100644
> > > --- a/arch/csky/include/uapi/asm/ptrace.h
> > > +++ b/arch/csky/include/uapi/asm/ptrace.h
> > > @@ -62,6 +62,11 @@ struct user_fp {
> > > #define instruction_pointer(regs) ((regs)->pc)
> > > #define profile_pc(regs) instruction_pointer(regs)
> > >
> > > +static inline unsigned long regs_return_value(struct pt_regs *regs)
> > > +{
> > > + return regs->a0;
> > > +}
> > > +
> > > #endif /* __KERNEL__ */
> > > #endif /* __ASSEMBLY__ */
> > > #endif /* _CSKY_PTRACE_H */
> >
> > I wonder why we have this #ifdef __KERNEL__ code in the uapi namespace,
> > it defeats the idea of uapi. Doesn't it belong to non-uapi
> > include/asm/ptrace.h namespace?
>
> Yes, I should move __KERNEL__ codes into arch/csky/include/asm/ptrace.h.
> But it'll be another patch for the modification. Any other problems?
From UAPI perspective? No, I don't see any more UAPI issues with the patch.
--
ldv
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2019-03-25 15:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 12:03 [PATCH] csky: Update syscall_trace_enter/exit implementation guoren
2019-03-25 12:03 ` guoren
2019-03-25 12:17 ` Dmitry V. Levin
2019-03-25 12:17 ` Dmitry V. Levin
[not found] ` <20190325121754.GB19244-u2l5PoMzF/Vg9hUCZPvPmw@public.gmane.org>
2019-03-25 12:41 ` Guo Ren
2019-03-25 12:41 ` Guo Ren
2019-03-25 15:27 ` Dmitry V. Levin [this message]
2019-03-25 15:27 ` Dmitry V. Levin
2019-03-25 14:39 ` Guo Ren
2019-03-25 14:39 ` Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190325152722.GA23169@altlinux.org \
--to=ldv@altlinux.org \
--cc=arnd@arndb.de \
--cc=guoren@kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ren_guo@c-sky.com \
--cc=strace-devel@lists.strace.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox