From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v13 10/11] gpio: 74x164: Utilize the for_each_set_clump8 macro Date: Thu, 28 Mar 2019 11:11:51 +0200 Message-ID: <20190328091151.GU9224@smile.fi.intel.com> References: <645f16f1d1ad3f215e34a82f457e06725fcf8f56.1553661964.git.vilhelm.gray@gmail.com> <20190327123314.GJ9224@smile.fi.intel.com> <20190328044004.GB3251@icarus> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190328044004.GB3251@icarus> Sender: linux-kernel-owner@vger.kernel.org To: William Breathitt Gray Cc: linus.walleij@linaro.org, bgolaszewski@baylibre.com, akpm@linux-foundation.org, linux-gpio@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux@rasmusvillemoes.dk, yamada.masahiro@socionext.com, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, geert@linux-m68k.org, preid@electromag.com.au, Geert Uytterhoeven List-Id: linux-arch.vger.kernel.org On Thu, Mar 28, 2019 at 01:40:04PM +0900, William Breathitt Gray wrote: > On Wed, Mar 27, 2019 at 02:33:14PM +0200, Andy Shevchenko wrote: > > On Wed, Mar 27, 2019 at 02:02:39PM +0900, William Breathitt Gray wrote: > > > Replace verbose implementation in set_multiple callback with > > > for_each_set_clump8 macro to simplify code and improve clarity. > > > > > + for_each_set_clump8(offset, bankmask, mask, chip->registers * 8) { > > > > > + bank = (chip->registers - 1) - (offset / 8); > > > > Excessive parens, but it's minor. > > Fair point, this could do without parens around (chip->registers - 1). And around division too. > Since this and renaming 'idx' to 'index' in find_bit.c are such a minor > changes, I'll wait first to see if something else comes up to be fixed > in this review. If so, I'll add these changes to the next version of > this patchset. It seems inline proposal would going to be implemented. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com ([134.134.136.24]:12899 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725779AbfC1JL5 (ORCPT ); Thu, 28 Mar 2019 05:11:57 -0400 Date: Thu, 28 Mar 2019 11:11:51 +0200 From: Andy Shevchenko Subject: Re: [PATCH v13 10/11] gpio: 74x164: Utilize the for_each_set_clump8 macro Message-ID: <20190328091151.GU9224@smile.fi.intel.com> References: <645f16f1d1ad3f215e34a82f457e06725fcf8f56.1553661964.git.vilhelm.gray@gmail.com> <20190327123314.GJ9224@smile.fi.intel.com> <20190328044004.GB3251@icarus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190328044004.GB3251@icarus> Sender: linux-arch-owner@vger.kernel.org List-ID: To: William Breathitt Gray Cc: linus.walleij@linaro.org, bgolaszewski@baylibre.com, akpm@linux-foundation.org, linux-gpio@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux@rasmusvillemoes.dk, yamada.masahiro@socionext.com, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, geert@linux-m68k.org, preid@electromag.com.au, Geert Uytterhoeven Message-ID: <20190328091151.qmabCEXVRn0XVJPhxWKwzkHvFOC0-afvL-Og5Ew3buU@z> On Thu, Mar 28, 2019 at 01:40:04PM +0900, William Breathitt Gray wrote: > On Wed, Mar 27, 2019 at 02:33:14PM +0200, Andy Shevchenko wrote: > > On Wed, Mar 27, 2019 at 02:02:39PM +0900, William Breathitt Gray wrote: > > > Replace verbose implementation in set_multiple callback with > > > for_each_set_clump8 macro to simplify code and improve clarity. > > > > > + for_each_set_clump8(offset, bankmask, mask, chip->registers * 8) { > > > > > + bank = (chip->registers - 1) - (offset / 8); > > > > Excessive parens, but it's minor. > > Fair point, this could do without parens around (chip->registers - 1). And around division too. > Since this and renaming 'idx' to 'index' in find_bit.c are such a minor > changes, I'll wait first to see if something else comes up to be fixed > in this review. If so, I'll add these changes to the next version of > this patchset. It seems inline proposal would going to be implemented. -- With Best Regards, Andy Shevchenko