public inbox for linux-arch@vger.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Andy Lutomirski <luto@amacapital.net>,
	Roland McGrath <roland@hack.frob.com>,
	Oleg Nesterov <oleg@redhat.com>,
	linux-arch <linux-arch@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	the arch/x86 maintainers <x86@kernel.org>,
	Dominik Brodowski <linux@dominikbrodowski.net>,
	Andy Lutomirski <luto@kernel.org>,
	Kees Cook <keescook@chromium.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	"Dmitry V. Levin" <ldv@altlinux.org>
Subject: Re: [PATCH 0/6 v3] sycalls: Remove args i and n from syscall_get_arguments()
Date: Fri, 5 Apr 2019 10:07:49 -0400	[thread overview]
Message-ID: <20190405100749.56bf86a2@gandalf.local.home> (raw)
In-Reply-To: <CAHk-=wh1wv_g2cW07OG1n5oHFXxZUc2192ZQ+6p5Cj+46FDQVQ@mail.gmail.com>

On Thu, 4 Apr 2019 15:24:16 -1000
Linus Torvalds <torvalds@linux-foundation.org> wrote:


> I assume you've actually used this and can trace system calls with
> arguments properly, so that it's all tested at least on x86-64?
>

Yep, and even tested it against strace. Looks fine. I also ran it
through my entire ftrace test suite (takes around 10 hours or more),
and it all passed.

I'll collect the last bit of acks and then send you a pull request.

-- Steve

WARNING: multiple messages have this Message-ID (diff)
From: Steven Rostedt <rostedt@goodmis.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Andy Lutomirski <luto@amacapital.net>,
	Roland McGrath <roland@hack.frob.com>,
	Oleg Nesterov <oleg@redhat.com>,
	linux-arch <linux-arch@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	the arch/x86 maintainers <x86@kernel.org>,
	Dominik Brodowski <linux@dominikbrodowski.net>,
	Andy Lutomirski <luto@kernel.org>,
	Kees Cook <keescook@chromium.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	"Dmitry V. Levin" <ldv@altlinux.org>,
	Palmer Dabbelt <palmer@sifive.com>
Subject: Re: [PATCH 0/6 v3] sycalls: Remove args i and n from syscall_get_arguments()
Date: Fri, 5 Apr 2019 10:07:49 -0400	[thread overview]
Message-ID: <20190405100749.56bf86a2@gandalf.local.home> (raw)
Message-ID: <20190405140749.1svBum2F9MpZ1vYFCvplUjdXKBwYqArqY4eJYlN1dFw@z> (raw)
In-Reply-To: <CAHk-=wh1wv_g2cW07OG1n5oHFXxZUc2192ZQ+6p5Cj+46FDQVQ@mail.gmail.com>

On Thu, 4 Apr 2019 15:24:16 -1000
Linus Torvalds <torvalds@linux-foundation.org> wrote:


> I assume you've actually used this and can trace system calls with
> arguments properly, so that it's all tested at least on x86-64?
>

Yep, and even tested it against strace. Looks fine. I also ran it
through my entire ftrace test suite (takes around 10 hours or more),
and it all passed.

I'll collect the last bit of acks and then send you a pull request.

-- Steve

  parent reply	other threads:[~2019-04-05 14:07 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-01 13:41 [PATCH 0/6 v3] sycalls: Remove args i and n from syscall_get_arguments() Steven Rostedt
2019-04-01 13:41 ` Steven Rostedt
2019-04-01 13:41 ` [PATCH 1/6 v3] ptrace: Remove maxargs from task_current_syscall() Steven Rostedt
2019-04-01 13:41   ` Steven Rostedt
2019-04-04  7:52   ` Thomas Gleixner
2019-04-04  7:52     ` Thomas Gleixner
2019-04-01 13:41 ` [PATCH 2/6 v3] tracing/syscalls: Pass in hardcoded 6 into syscall_get_arguments() Steven Rostedt
2019-04-01 13:41   ` Steven Rostedt
2019-04-01 13:41 ` [PATCH 3/6 v3] riscv: Fix syscall_get_arguments() and syscall_set_arguments() Steven Rostedt
2019-04-01 13:41   ` Steven Rostedt
2019-04-04 14:02   ` Dmitry V. Levin
2019-04-04 14:02     ` Dmitry V. Levin
2019-04-04 14:26     ` Steven Rostedt
2019-04-04 14:26       ` Steven Rostedt
2019-04-04 23:29       ` Palmer Dabbelt
2019-04-04 23:29         ` Palmer Dabbelt
2019-04-01 13:41 ` [PATCH 4/6 v3] csky: " Steven Rostedt
2019-04-01 13:41   ` Steven Rostedt
2019-04-04 14:02   ` Dmitry V. Levin
2019-04-04 14:02     ` Dmitry V. Levin
2019-04-04 14:28     ` Steven Rostedt
2019-04-04 14:28       ` Steven Rostedt
2019-04-01 13:41 ` [PATCH 5/6 v3] syscalls: Remove start and number from syscall_get_arguments() args Steven Rostedt
2019-04-01 13:41   ` Steven Rostedt
2019-04-03 22:51   ` Paul Burton
2019-04-04  7:52   ` Thomas Gleixner
2019-04-04  7:52     ` Thomas Gleixner
2019-04-04 18:17   ` Dmitry V. Levin
2019-04-04 18:17     ` Dmitry V. Levin
2019-04-04 21:06     ` Steven Rostedt
2019-04-04 21:06       ` Steven Rostedt
2019-04-04 18:56   ` Max Filippov
2019-04-04 18:56     ` Max Filippov
2019-04-01 13:41 ` [PATCH 6/6 v3] syscalls: Remove start and number from syscall_set_arguments() args Steven Rostedt
2019-04-01 13:41   ` Steven Rostedt
2019-04-04  7:53   ` Thomas Gleixner
2019-04-04  7:53     ` Thomas Gleixner
2019-04-04 18:18   ` Dmitry V. Levin
2019-04-04 18:18     ` Dmitry V. Levin
2019-04-04 18:55   ` Max Filippov
2019-04-04 18:55     ` Max Filippov
2019-04-04 13:28 ` [PATCH 0/6 v3] sycalls: Remove args i and n from syscall_get_arguments() Steven Rostedt
2019-04-04 13:28   ` Steven Rostedt
2019-04-05  1:24   ` Linus Torvalds
2019-04-05  1:24     ` Linus Torvalds
2019-04-05 14:07     ` Steven Rostedt [this message]
2019-04-05 14:07       ` Steven Rostedt
2019-04-05  8:58 ` Will Deacon
2019-04-05  8:58   ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190405100749.56bf86a2@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=bp@alien8.de \
    --cc=ebiederm@xmission.com \
    --cc=gustavo@embeddedor.com \
    --cc=hpa@zytor.com \
    --cc=keescook@chromium.org \
    --cc=ldv@altlinux.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@dominikbrodowski.net \
    --cc=luto@amacapital.net \
    --cc=luto@kernel.org \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=oleg@redhat.com \
    --cc=peterz@infradead.org \
    --cc=roland@hack.frob.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox