From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Rostedt Subject: Re: [PATCH 0/6 v3] sycalls: Remove args i and n from syscall_get_arguments() Date: Fri, 5 Apr 2019 10:07:49 -0400 Message-ID: <20190405100749.56bf86a2@gandalf.local.home> References: <20190401134104.676620247@goodmis.org> <20190404092803.1bffd135@gandalf.local.home> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Linus Torvalds Cc: Linux List Kernel Mailing , Ingo Molnar , Andrew Morton , Andy Lutomirski , Roland McGrath , Oleg Nesterov , linux-arch , Peter Zijlstra , Thomas Gleixner , "Gustavo A. R. Silva" , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , the arch/x86 maintainers , Dominik Brodowski , Andy Lutomirski , Kees Cook , "Eric W. Biederman" , "Dmitry V. Levin" List-Id: linux-arch.vger.kernel.org On Thu, 4 Apr 2019 15:24:16 -1000 Linus Torvalds wrote: > I assume you've actually used this and can trace system calls with > arguments properly, so that it's all tested at least on x86-64? > Yep, and even tested it against strace. Looks fine. I also ran it through my entire ftrace test suite (takes around 10 hours or more), and it all passed. I'll collect the last bit of acks and then send you a pull request. -- Steve From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:52918 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728811AbfDEOHx (ORCPT ); Fri, 5 Apr 2019 10:07:53 -0400 Date: Fri, 5 Apr 2019 10:07:49 -0400 From: Steven Rostedt Subject: Re: [PATCH 0/6 v3] sycalls: Remove args i and n from syscall_get_arguments() Message-ID: <20190405100749.56bf86a2@gandalf.local.home> In-Reply-To: References: <20190401134104.676620247@goodmis.org> <20190404092803.1bffd135@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Linus Torvalds Cc: Linux List Kernel Mailing , Ingo Molnar , Andrew Morton , Andy Lutomirski , Roland McGrath , Oleg Nesterov , linux-arch , Peter Zijlstra , Thomas Gleixner , "Gustavo A. R. Silva" , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , the arch/x86 maintainers , Dominik Brodowski , Andy Lutomirski , Kees Cook , "Eric W. Biederman" , "Dmitry V. Levin" , Palmer Dabbelt Message-ID: <20190405140749.1svBum2F9MpZ1vYFCvplUjdXKBwYqArqY4eJYlN1dFw@z> On Thu, 4 Apr 2019 15:24:16 -1000 Linus Torvalds wrote: > I assume you've actually used this and can trace system calls with > arguments properly, so that it's all tested at least on x86-64? > Yep, and even tested it against strace. Looks fine. I also ran it through my entire ftrace test suite (takes around 10 hours or more), and it all passed. I'll collect the last bit of acks and then send you a pull request. -- Steve