From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Rostedt Subject: Re: [patch V2 20/29] tracing: Simplify stacktrace retrieval in histograms Date: Thu, 18 Apr 2019 09:40:14 -0400 Message-ID: <20190418094014.7d457f29@gandalf.local.home> References: <20190418084119.056416939@linutronix.de> <20190418084254.910579307@linutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190418084254.910579307@linutronix.de> Sender: linux-kernel-owner@vger.kernel.org To: Thomas Gleixner , Tom Zanussi Cc: LKML , Josh Poimboeuf , x86@kernel.org, Andy Lutomirski , Alexander Potapenko , Alexey Dobriyan , Andrew Morton , Pekka Enberg , linux-mm@kvack.org, David Rientjes , Christoph Lameter , Catalin Marinas , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, Mike Rapoport , Akinobu Mita , iommu@lists.linux-foundation.org, Robin Murphy , Christoph Hellwig , Marek Szyprowski List-Id: linux-arch.vger.kernel.org [ Added Tom Zanussi ] On Thu, 18 Apr 2019 10:41:39 +0200 Thomas Gleixner wrote: > The indirection through struct stack_trace is not necessary at all. Use the > storage array based interface. > > Signed-off-by: Thomas Gleixner > Cc: Steven Rostedt Looks fine to me Acked-by: Steven Rostedt (VMware) But... Tom, Can you review this too? Patch series starts here: http://lkml.kernel.org/r/20190418084119.056416939@linutronix.de Thanks, -- Steve > --- > kernel/trace/trace_events_hist.c | 12 +++--------- > 1 file changed, 3 insertions(+), 9 deletions(-) > > --- a/kernel/trace/trace_events_hist.c > +++ b/kernel/trace/trace_events_hist.c > @@ -5186,7 +5186,6 @@ static void event_hist_trigger(struct ev > u64 var_ref_vals[TRACING_MAP_VARS_MAX]; > char compound_key[HIST_KEY_SIZE_MAX]; > struct tracing_map_elt *elt = NULL; > - struct stack_trace stacktrace; > struct hist_field *key_field; > u64 field_contents; > void *key = NULL; > @@ -5198,14 +5197,9 @@ static void event_hist_trigger(struct ev > key_field = hist_data->fields[i]; > > if (key_field->flags & HIST_FIELD_FL_STACKTRACE) { > - stacktrace.max_entries = HIST_STACKTRACE_DEPTH; > - stacktrace.entries = entries; > - stacktrace.nr_entries = 0; > - stacktrace.skip = HIST_STACKTRACE_SKIP; > - > - memset(stacktrace.entries, 0, HIST_STACKTRACE_SIZE); > - save_stack_trace(&stacktrace); > - > + memset(entries, 0, HIST_STACKTRACE_SIZE); > + stack_trace_save(entries, HIST_STACKTRACE_DEPTH, > + HIST_STACKTRACE_SKIP); > key = entries; > } else { > field_contents = key_field->fn(key_field, elt, rbe, rec); > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:44522 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388535AbfDRNkT (ORCPT ); Thu, 18 Apr 2019 09:40:19 -0400 Date: Thu, 18 Apr 2019 09:40:14 -0400 From: Steven Rostedt Subject: Re: [patch V2 20/29] tracing: Simplify stacktrace retrieval in histograms Message-ID: <20190418094014.7d457f29@gandalf.local.home> In-Reply-To: <20190418084254.910579307@linutronix.de> References: <20190418084119.056416939@linutronix.de> <20190418084254.910579307@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Thomas Gleixner , Tom Zanussi Cc: LKML , Josh Poimboeuf , x86@kernel.org, Andy Lutomirski , Alexander Potapenko , Alexey Dobriyan , Andrew Morton , Pekka Enberg , linux-mm@kvack.org, David Rientjes , Christoph Lameter , Catalin Marinas , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, Mike Rapoport , Akinobu Mita , iommu@lists.linux-foundation.org, Robin Murphy , Christoph Hellwig , Marek Szyprowski , Johannes Thumshirn , David Sterba , Chris Mason , Josef Bacik , linux-btrfs@vger.kernel.org, dm-devel@redhat.com, Mike Snitzer , Alasdair Kergon , intel-gfx@lists.freedesktop.org, Joonas Lahtinen , Maarten Lankhorst , dri-devel@lists.freedesktop.org, David Airlie , Jani Nikula , Daniel Vetter , Rodrigo Vivi , linux-arch@vger.kernel.org Message-ID: <20190418134014.VrEEJembJ-GIv_y8MoTTR6lB-LPWigfG3TUX3oMozuY@z> [ Added Tom Zanussi ] On Thu, 18 Apr 2019 10:41:39 +0200 Thomas Gleixner wrote: > The indirection through struct stack_trace is not necessary at all. Use the > storage array based interface. > > Signed-off-by: Thomas Gleixner > Cc: Steven Rostedt Looks fine to me Acked-by: Steven Rostedt (VMware) But... Tom, Can you review this too? Patch series starts here: http://lkml.kernel.org/r/20190418084119.056416939@linutronix.de Thanks, -- Steve > --- > kernel/trace/trace_events_hist.c | 12 +++--------- > 1 file changed, 3 insertions(+), 9 deletions(-) > > --- a/kernel/trace/trace_events_hist.c > +++ b/kernel/trace/trace_events_hist.c > @@ -5186,7 +5186,6 @@ static void event_hist_trigger(struct ev > u64 var_ref_vals[TRACING_MAP_VARS_MAX]; > char compound_key[HIST_KEY_SIZE_MAX]; > struct tracing_map_elt *elt = NULL; > - struct stack_trace stacktrace; > struct hist_field *key_field; > u64 field_contents; > void *key = NULL; > @@ -5198,14 +5197,9 @@ static void event_hist_trigger(struct ev > key_field = hist_data->fields[i]; > > if (key_field->flags & HIST_FIELD_FL_STACKTRACE) { > - stacktrace.max_entries = HIST_STACKTRACE_DEPTH; > - stacktrace.entries = entries; > - stacktrace.nr_entries = 0; > - stacktrace.skip = HIST_STACKTRACE_SKIP; > - > - memset(stacktrace.entries, 0, HIST_STACKTRACE_SIZE); > - save_stack_trace(&stacktrace); > - > + memset(entries, 0, HIST_STACKTRACE_SIZE); > + stack_trace_save(entries, HIST_STACKTRACE_DEPTH, > + HIST_STACKTRACE_SKIP); > key = entries; > } else { > field_contents = key_field->fn(key_field, elt, rbe, rec); >