From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Subject: [patch V3 04/29] backtrace-test: Simplify stack trace handling Date: Thu, 25 Apr 2019 11:44:57 +0200 Message-ID: <20190425094801.501919093@linutronix.de> References: <20190425094453.875139013@linutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: LKML Cc: Mike Snitzer , David Airlie , Catalin Marinas , dri-devel@lists.freedesktop.org, linux-mm@kvack.org, dm-devel@redhat.com, Alexander Potapenko , Christoph Lameter , Miroslav Benes , Christoph Hellwig , Alasdair Kergon , Marek Szyprowski , linux-arch@vger.kernel.org, x86@kernel.org, kasan-dev@googlegroups.com, Johannes Thumshirn , Andrey Ryabinin , Alexey Dobriyan , intel-gfx@lists.freedesktop.org, David Rientjes , Akinobu Mita , Steven Rostedt , Josef Bacik , Mike Rapoport , Andy Lutomirski , Josh Poimboeuf List-Id: linux-arch.vger.kernel.org UmVwbGFjZSB0aGUgaW5kaXJlY3Rpb24gdGhyb3VnaCBzdHJ1Y3Qgc3RhY2tfdHJhY2UgYnkgdXNp bmcgdGhlIHN0b3JhZ2UKYXJyYXkgYmFzZWQgaW50ZXJmYWNlcy4KClNpZ25lZC1vZmYtYnk6IFRo b21hcyBHbGVpeG5lciA8dGdseEBsaW51dHJvbml4LmRlPgotLS0KIGtlcm5lbC9iYWNrdHJhY2V0 ZXN0LmMgfCAgIDExICsrKy0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCsp LCA4IGRlbGV0aW9ucygtKQoKLS0tIGEva2VybmVsL2JhY2t0cmFjZXRlc3QuYworKysgYi9rZXJu ZWwvYmFja3RyYWNldGVzdC5jCkBAIC00OCwxOSArNDgsMTQgQEAgc3RhdGljIHZvaWQgYmFja3Ry YWNlX3Rlc3RfaXJxKHZvaWQpCiAjaWZkZWYgQ09ORklHX1NUQUNLVFJBQ0UKIHN0YXRpYyB2b2lk IGJhY2t0cmFjZV90ZXN0X3NhdmVkKHZvaWQpCiB7Ci0Jc3RydWN0IHN0YWNrX3RyYWNlIHRyYWNl OwogCXVuc2lnbmVkIGxvbmcgZW50cmllc1s4XTsKKwl1bnNpZ25lZCBpbnQgbnJfZW50cmllczsK IAogCXByX2luZm8oIlRlc3RpbmcgYSBzYXZlZCBiYWNrdHJhY2UuXG4iKTsKIAlwcl9pbmZvKCJU aGUgZm9sbG93aW5nIHRyYWNlIGlzIGEga2VybmVsIHNlbGYgdGVzdCBhbmQgbm90IGEgYnVnIVxu Iik7CiAKLQl0cmFjZS5ucl9lbnRyaWVzID0gMDsKLQl0cmFjZS5tYXhfZW50cmllcyA9IEFSUkFZ X1NJWkUoZW50cmllcyk7Ci0JdHJhY2UuZW50cmllcyA9IGVudHJpZXM7Ci0JdHJhY2Uuc2tpcCA9 IDA7Ci0KLQlzYXZlX3N0YWNrX3RyYWNlKCZ0cmFjZSk7Ci0JcHJpbnRfc3RhY2tfdHJhY2UoJnRy YWNlLCAwKTsKKwlucl9lbnRyaWVzID0gc3RhY2tfdHJhY2Vfc2F2ZShlbnRyaWVzLCBBUlJBWV9T SVpFKGVudHJpZXMpLCAwKTsKKwlzdGFja190cmFjZV9wcmludChlbnRyaWVzLCBucl9lbnRyaWVz LCAwKTsKIH0KICNlbHNlCiBzdGF0aWMgdm9pZCBiYWNrdHJhY2VfdGVzdF9zYXZlZCh2b2lkKQoK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdm eCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from Galois.linutronix.de ([146.0.238.70]:58137 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728758AbfDYKBd (ORCPT ); Thu, 25 Apr 2019 06:01:33 -0400 Message-ID: <20190425094801.501919093@linutronix.de> Date: Thu, 25 Apr 2019 11:44:57 +0200 From: Thomas Gleixner Subject: [patch V3 04/29] backtrace-test: Simplify stack trace handling References: <20190425094453.875139013@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-arch-owner@vger.kernel.org List-ID: To: LKML Cc: Josh Poimboeuf , x86@kernel.org, Andy Lutomirski , Steven Rostedt , Alexander Potapenko , Alexey Dobriyan , Andrew Morton , Christoph Lameter , Pekka Enberg , linux-mm@kvack.org, David Rientjes , Catalin Marinas , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, Mike Rapoport , Akinobu Mita , Christoph Hellwig , iommu@lists.linux-foundation.org, Robin Murphy , Marek Szyprowski , Johannes Thumshirn , David Sterba , Chris Mason , Josef Bacik , linux-btrfs@vger.kernel.org, dm-devel@redhat.com, Mike Snitzer , Alasdair Kergon , Daniel Vetter , intel-gfx@lists.freedesktop.org, Joonas Lahtinen , Maarten Lankhorst , dri-devel@lists.freedesktop.org, David Airlie , Jani Nikula , Rodrigo Vivi , Tom Zanussi , Miroslav Benes , linux-arch@vger.kernel.org Message-ID: <20190425094457.t4PisWZkAiwPfB4RG5rljsc4Kx-GFbCtCVFiOKF1xjY@z> Replace the indirection through struct stack_trace by using the storage array based interfaces. Signed-off-by: Thomas Gleixner --- kernel/backtracetest.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) --- a/kernel/backtracetest.c +++ b/kernel/backtracetest.c @@ -48,19 +48,14 @@ static void backtrace_test_irq(void) #ifdef CONFIG_STACKTRACE static void backtrace_test_saved(void) { - struct stack_trace trace; unsigned long entries[8]; + unsigned int nr_entries; pr_info("Testing a saved backtrace.\n"); pr_info("The following trace is a kernel self test and not a bug!\n"); - trace.nr_entries = 0; - trace.max_entries = ARRAY_SIZE(entries); - trace.entries = entries; - trace.skip = 0; - - save_stack_trace(&trace); - print_stack_trace(&trace, 0); + nr_entries = stack_trace_save(entries, ARRAY_SIZE(entries), 0); + stack_trace_print(entries, nr_entries, 0); } #else static void backtrace_test_saved(void)