From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Subject: [patch V3 07/29] mm/slub: Simplify stack trace retrieval Date: Thu, 25 Apr 2019 11:45:00 +0200 Message-ID: <20190425094801.771410441@linutronix.de> References: <20190425094453.875139013@linutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: LKML Cc: Mike Snitzer , David Airlie , Catalin Marinas , dri-devel@lists.freedesktop.org, linux-mm@kvack.org, dm-devel@redhat.com, Alexander Potapenko , Christoph Lameter , Miroslav Benes , Christoph Hellwig , Alasdair Kergon , Marek Szyprowski , linux-arch@vger.kernel.org, x86@kernel.org, kasan-dev@googlegroups.com, Johannes Thumshirn , Andrey Ryabinin , Alexey Dobriyan , intel-gfx@lists.freedesktop.org, David Rientjes , Akinobu Mita , Steven Rostedt , Josef Bacik , Mike Rapoport , Andy Lutomirski , Josh Poimboeuf List-Id: linux-arch.vger.kernel.org UmVwbGFjZSB0aGUgaW5kaXJlY3Rpb24gdGhyb3VnaCBzdHJ1Y3Qgc3RhY2tfdHJhY2Ugd2l0aCBh biBpbnZvY2F0aW9uIG9mCnRoZSBzdG9yYWdlIGFycmF5IGJhc2VkIGludGVyZmFjZS4KClNpZ25l ZC1vZmYtYnk6IFRob21hcyBHbGVpeG5lciA8dGdseEBsaW51dHJvbml4LmRlPgpBY2tlZC1ieTog Q2hyaXN0b3BoIExhbWV0ZXIgPGNsQGxpbnV4LmNvbT4KQ2M6IEFuZHJldyBNb3J0b24gPGFrcG1A bGludXgtZm91bmRhdGlvbi5vcmc+CkNjOiBQZWtrYSBFbmJlcmcgPHBlbmJlcmdAa2VybmVsLm9y Zz4KQ2M6IGxpbnV4LW1tQGt2YWNrLm9yZwpDYzogRGF2aWQgUmllbnRqZXMgPHJpZW50amVzQGdv b2dsZS5jb20+Ci0tLQogbW0vc2x1Yi5jIHwgICAxMiArKysrLS0tLS0tLS0KIDEgZmlsZSBjaGFu Z2VkLCA0IGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0pCgotLS0gYS9tbS9zbHViLmMKKysr IGIvbW0vc2x1Yi5jCkBAIC01NTIsMTggKzU1MiwxNCBAQCBzdGF0aWMgdm9pZCBzZXRfdHJhY2so c3RydWN0IGttZW1fY2FjaGUKIAogCWlmIChhZGRyKSB7CiAjaWZkZWYgQ09ORklHX1NUQUNLVFJB Q0UKLQkJc3RydWN0IHN0YWNrX3RyYWNlIHRyYWNlOworCQl1bnNpZ25lZCBpbnQgbnJfZW50cmll czsKIAotCQl0cmFjZS5ucl9lbnRyaWVzID0gMDsKLQkJdHJhY2UubWF4X2VudHJpZXMgPSBUUkFD S19BRERSU19DT1VOVDsKLQkJdHJhY2UuZW50cmllcyA9IHAtPmFkZHJzOwotCQl0cmFjZS5za2lw ID0gMzsKIAkJbWV0YWRhdGFfYWNjZXNzX2VuYWJsZSgpOwotCQlzYXZlX3N0YWNrX3RyYWNlKCZ0 cmFjZSk7CisJCW5yX2VudHJpZXMgPSBzdGFja190cmFjZV9zYXZlKHAtPmFkZHJzLCBUUkFDS19B RERSU19DT1VOVCwgMyk7CiAJCW1ldGFkYXRhX2FjY2Vzc19kaXNhYmxlKCk7CiAKLQkJaWYgKHRy YWNlLm5yX2VudHJpZXMgPCBUUkFDS19BRERSU19DT1VOVCkKLQkJCXAtPmFkZHJzW3RyYWNlLm5y X2VudHJpZXNdID0gMDsKKwkJaWYgKG5yX2VudHJpZXMgPCBUUkFDS19BRERSU19DT1VOVCkKKwkJ CXAtPmFkZHJzW25yX2VudHJpZXNdID0gMDsKICNlbmRpZgogCQlwLT5hZGRyID0gYWRkcjsKIAkJ cC0+Y3B1ID0gc21wX3Byb2Nlc3Nvcl9pZCgpOwoKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2ludGVsLWdmeA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from Galois.linutronix.de ([146.0.238.70]:57664 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728077AbfDYJ7o (ORCPT ); Thu, 25 Apr 2019 05:59:44 -0400 Message-ID: <20190425094801.771410441@linutronix.de> Date: Thu, 25 Apr 2019 11:45:00 +0200 From: Thomas Gleixner Subject: [patch V3 07/29] mm/slub: Simplify stack trace retrieval References: <20190425094453.875139013@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-arch-owner@vger.kernel.org List-ID: To: LKML Cc: Josh Poimboeuf , x86@kernel.org, Andy Lutomirski , Christoph Lameter , Andrew Morton , Pekka Enberg , linux-mm@kvack.org, David Rientjes , Steven Rostedt , Alexander Potapenko , Alexey Dobriyan , Catalin Marinas , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, Mike Rapoport , Akinobu Mita , Christoph Hellwig , iommu@lists.linux-foundation.org, Robin Murphy , Marek Szyprowski , Johannes Thumshirn , David Sterba , Chris Mason , Josef Bacik , linux-btrfs@vger.kernel.org, dm-devel@redhat.com, Mike Snitzer , Alasdair Kergon , Daniel Vetter , intel-gfx@lists.freedesktop.org, Joonas Lahtinen , Maarten Lankhorst , dri-devel@lists.freedesktop.org, David Airlie , Jani Nikula , Rodrigo Vivi , Tom Zanussi , Miroslav Benes , linux-arch@vger.kernel.org Message-ID: <20190425094500.-j1axc5yb3_bwPvTFTlN9avy_pFrqxoz1Mch3qR4r-g@z> Replace the indirection through struct stack_trace with an invocation of the storage array based interface. Signed-off-by: Thomas Gleixner Acked-by: Christoph Lameter Cc: Andrew Morton Cc: Pekka Enberg Cc: linux-mm@kvack.org Cc: David Rientjes --- mm/slub.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) --- a/mm/slub.c +++ b/mm/slub.c @@ -552,18 +552,14 @@ static void set_track(struct kmem_cache if (addr) { #ifdef CONFIG_STACKTRACE - struct stack_trace trace; + unsigned int nr_entries; - trace.nr_entries = 0; - trace.max_entries = TRACK_ADDRS_COUNT; - trace.entries = p->addrs; - trace.skip = 3; metadata_access_enable(); - save_stack_trace(&trace); + nr_entries = stack_trace_save(p->addrs, TRACK_ADDRS_COUNT, 3); metadata_access_disable(); - if (trace.nr_entries < TRACK_ADDRS_COUNT) - p->addrs[trace.nr_entries] = 0; + if (nr_entries < TRACK_ADDRS_COUNT) + p->addrs[nr_entries] = 0; #endif p->addr = addr; p->cpu = smp_processor_id();