Re: [patch V3 00/29] stacktrace: Consolidate stack trace usage

Ingo Molnar
2019-04-25T10:09:39Z

* Thomas Gleixner <tglx@linutronix.de> wrote:

> - if (unlikely(!ret))
> + if (unlikely(!ret)) {
> + if (!trace->nr_entries) {
> + /*
> + * If save_trace fails here, the printing might
> + * trigger a WARN but because of the !nr_entries it
> + * should not do bad things.
> + */
> + save_trace(trace);
> + }
> return print_circular_bug(&this, target_entry, next, prev);
> + }
> else if (unlikely(ret < 0))
> return print_bfs_bug(ret);

Just a minor style nit: the 'else' should probably on the same line as
the '}' it belongs to, to make it really obvious that the 'if' has an
'else' branch?

At that point the condition should probably also use balanced curly
braces.

Interdiff looks good otherwise.

Thanks,

Ingo