Re: [patch V3 24/29] tracing: Remove the last struct stack_trace usage

Josh Poimboeuf
2019-04-25T13:30:46Z

On Thu, Apr 25, 2019 at 11:45:17AM +0200, Thomas Gleixner wrote:
> Simplify the stack retrieval code by using the storage array based
> interface.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> ---
> kernel/trace/trace_stack.c | 37 ++++++++++++++++---------------------
> 1 file changed, 16 insertions(+), 21 deletions(-)
>
> --- a/kernel/trace/trace_stack.c
> +++ b/kernel/trace/trace_stack.c
> @@ -23,11 +23,7 @@
> static unsigned long stack_dump_trace[STACK_TRACE_ENTRIES];
> static unsigned stack_trace_index[STACK_TRACE_ENTRIES];
>
> -struct stack_trace stack_trace_max = {
> - .max_entries = STACK_TRACE_ENTRIES,
> - .entries = &stack_dump_trace[0],
> -};
> -
> +static unsigned int stack_trace_entries;

"stack_trace_entries" -> "nr_stack_trace_entries"

--
Josh