From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Subject: [patch V3 26/29] stacktrace: Remove obsolete functions Date: Thu, 25 Apr 2019 11:45:19 +0200 Message-ID: <20190425094803.524796783@linutronix.de> References: <20190425094453.875139013@linutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: LKML Cc: Mike Snitzer , David Airlie , Catalin Marinas , dri-devel@lists.freedesktop.org, linux-mm@kvack.org, dm-devel@redhat.com, Alexander Potapenko , Christoph Lameter , Miroslav Benes , Christoph Hellwig , Alasdair Kergon , Marek Szyprowski , linux-arch@vger.kernel.org, x86@kernel.org, kasan-dev@googlegroups.com, Johannes Thumshirn , Andrey Ryabinin , Alexey Dobriyan , intel-gfx@lists.freedesktop.org, David Rientjes , Akinobu Mita , Steven Rostedt , Josef Bacik , Mike Rapoport , Andy Lutomirski , Josh Poimboeuf List-Id: linux-arch.vger.kernel.org Tm8gbW9yZSB1c2VycyBvZiB0aGUgc3RydWN0IHN0YWNrX3RyYWNlIGJhc2VkIGludGVyZmFjZXMu IFJlbW92ZSB0aGVtLgoKUmVtb3ZlIHRoZSBtYWNybyBzdHVicyBmb3IgIUNPTkZJR19TVEFDS1RS QUNFIGFzIHdlbGwgYXMgdGhleSBhcmUgcG9pbnRsZXNzCmJlY2F1c2UgdGhlIHN0b3JhZ2Ugb24g dGhlIGNhbGwgc2l0ZXMgaXMgY29uZGl0aW9uYWwgb24gQ09ORklHX1NUQUNLVFJBQ0UKYWxyZWFk eS4gTm8gcG9pbnQgdG8gYmUgJ3NtYXJ0Jy4KClNpZ25lZC1vZmYtYnk6IFRob21hcyBHbGVpeG5l ciA8dGdseEBsaW51dHJvbml4LmRlPgotLS0KIGluY2x1ZGUvbGludXgvc3RhY2t0cmFjZS5oIHwg ICAxNyAtLS0tLS0tLS0tLS0tLS0tLQoga2VybmVsL3N0YWNrdHJhY2UuYyAgICAgICAgfCAgIDE0 IC0tLS0tLS0tLS0tLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDMxIGRlbGV0aW9ucygtKQoKLS0tIGEv aW5jbHVkZS9saW51eC9zdGFja3RyYWNlLmgKKysrIGIvaW5jbHVkZS9saW51eC9zdGFja3RyYWNl LmgKQEAgLTM2LDI0ICszNiw3IEBAIGV4dGVybiB2b2lkIHNhdmVfc3RhY2tfdHJhY2VfdHNrKHN0 cnVjdAogCQkJCXN0cnVjdCBzdGFja190cmFjZSAqdHJhY2UpOwogZXh0ZXJuIGludCBzYXZlX3N0 YWNrX3RyYWNlX3Rza19yZWxpYWJsZShzdHJ1Y3QgdGFza19zdHJ1Y3QgKnRzaywKIAkJCQkJIHN0 cnVjdCBzdGFja190cmFjZSAqdHJhY2UpOwotCi1leHRlcm4gdm9pZCBwcmludF9zdGFja190cmFj ZShzdHJ1Y3Qgc3RhY2tfdHJhY2UgKnRyYWNlLCBpbnQgc3BhY2VzKTsKLWV4dGVybiBpbnQgc25w cmludF9zdGFja190cmFjZShjaGFyICpidWYsIHNpemVfdCBzaXplLAotCQkJc3RydWN0IHN0YWNr X3RyYWNlICp0cmFjZSwgaW50IHNwYWNlcyk7Ci0KLSNpZmRlZiBDT05GSUdfVVNFUl9TVEFDS1RS QUNFX1NVUFBPUlQKIGV4dGVybiB2b2lkIHNhdmVfc3RhY2tfdHJhY2VfdXNlcihzdHJ1Y3Qgc3Rh Y2tfdHJhY2UgKnRyYWNlKTsKLSNlbHNlCi0jIGRlZmluZSBzYXZlX3N0YWNrX3RyYWNlX3VzZXIo dHJhY2UpICAgICAgICAgICAgICBkbyB7IH0gd2hpbGUgKDApCi0jZW5kaWYKLQotI2Vsc2UgLyog IUNPTkZJR19TVEFDS1RSQUNFICovCi0jIGRlZmluZSBzYXZlX3N0YWNrX3RyYWNlKHRyYWNlKQkJ CWRvIHsgfSB3aGlsZSAoMCkKLSMgZGVmaW5lIHNhdmVfc3RhY2tfdHJhY2VfdHNrKHRzaywgdHJh Y2UpCQlkbyB7IH0gd2hpbGUgKDApCi0jIGRlZmluZSBzYXZlX3N0YWNrX3RyYWNlX3VzZXIodHJh Y2UpCQkJZG8geyB9IHdoaWxlICgwKQotIyBkZWZpbmUgcHJpbnRfc3RhY2tfdHJhY2UodHJhY2Us IHNwYWNlcykJCWRvIHsgfSB3aGlsZSAoMCkKLSMgZGVmaW5lIHNucHJpbnRfc3RhY2tfdHJhY2Uo YnVmLCBzaXplLCB0cmFjZSwgc3BhY2VzKQlkbyB7IH0gd2hpbGUgKDApCi0jIGRlZmluZSBzYXZl X3N0YWNrX3RyYWNlX3Rza19yZWxpYWJsZSh0c2ssIHRyYWNlKQkoeyAtRU5PU1lTOyB9KQogI2Vu ZGlmIC8qIENPTkZJR19TVEFDS1RSQUNFICovCiAKICNpZiBkZWZpbmVkKENPTkZJR19TVEFDS1RS QUNFKSAmJiBkZWZpbmVkKENPTkZJR19IQVZFX1JFTElBQkxFX1NUQUNLVFJBQ0UpCi0tLSBhL2tl cm5lbC9zdGFja3RyYWNlLmMKKysrIGIva2VybmVsL3N0YWNrdHJhY2UuYwpAQCAtMzAsMTIgKzMw LDYgQEAgdm9pZCBzdGFja190cmFjZV9wcmludCh1bnNpZ25lZCBsb25nICplbgogfQogRVhQT1JU X1NZTUJPTF9HUEwoc3RhY2tfdHJhY2VfcHJpbnQpOwogCi12b2lkIHByaW50X3N0YWNrX3RyYWNl KHN0cnVjdCBzdGFja190cmFjZSAqdHJhY2UsIGludCBzcGFjZXMpCi17Ci0Jc3RhY2tfdHJhY2Vf cHJpbnQodHJhY2UtPmVudHJpZXMsIHRyYWNlLT5ucl9lbnRyaWVzLCBzcGFjZXMpOwotfQotRVhQ T1JUX1NZTUJPTF9HUEwocHJpbnRfc3RhY2tfdHJhY2UpOwotCiAvKioKICAqIHN0YWNrX3RyYWNl X3NucHJpbnQgLSBQcmludCB0aGUgZW50cmllcyBpbiB0aGUgc3RhY2sgdHJhY2UgaW50byBhIGJ1 ZmZlcgogICogQGJ1ZjoJUG9pbnRlciB0byB0aGUgcHJpbnQgYnVmZmVyCkBAIC03MiwxNCArNjYs NiBAQCBpbnQgc3RhY2tfdHJhY2Vfc25wcmludChjaGFyICpidWYsIHNpemVfCiB9CiBFWFBPUlRf U1lNQk9MX0dQTChzdGFja190cmFjZV9zbnByaW50KTsKIAotaW50IHNucHJpbnRfc3RhY2tfdHJh Y2UoY2hhciAqYnVmLCBzaXplX3Qgc2l6ZSwKLQkJCXN0cnVjdCBzdGFja190cmFjZSAqdHJhY2Us IGludCBzcGFjZXMpCi17Ci0JcmV0dXJuIHN0YWNrX3RyYWNlX3NucHJpbnQoYnVmLCBzaXplLCB0 cmFjZS0+ZW50cmllcywKLQkJCQkgICB0cmFjZS0+bnJfZW50cmllcywgc3BhY2VzKTsKLX0KLUVY UE9SVF9TWU1CT0xfR1BMKHNucHJpbnRfc3RhY2tfdHJhY2UpOwotCiAvKgogICogQXJjaGl0ZWN0 dXJlcyB0aGF0IGRvIG5vdCBpbXBsZW1lbnQgc2F2ZV9zdGFja190cmFjZV8qKCkKICAqIGdldCB0 aGVzZSB3ZWFrIGFsaWFzZXMgYW5kIG9uY2UtcGVyLWJvb3R1cCB3YXJuaW5ncwoKCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5n IGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from Galois.linutronix.de ([146.0.238.70]:57978 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728935AbfDYKAU (ORCPT ); Thu, 25 Apr 2019 06:00:20 -0400 Message-ID: <20190425094803.524796783@linutronix.de> Date: Thu, 25 Apr 2019 11:45:19 +0200 From: Thomas Gleixner Subject: [patch V3 26/29] stacktrace: Remove obsolete functions References: <20190425094453.875139013@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-arch-owner@vger.kernel.org List-ID: To: LKML Cc: Josh Poimboeuf , x86@kernel.org, Andy Lutomirski , Steven Rostedt , Alexander Potapenko , Alexey Dobriyan , Andrew Morton , Christoph Lameter , Pekka Enberg , linux-mm@kvack.org, David Rientjes , Catalin Marinas , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, Mike Rapoport , Akinobu Mita , Christoph Hellwig , iommu@lists.linux-foundation.org, Robin Murphy , Marek Szyprowski , Johannes Thumshirn , David Sterba , Chris Mason , Josef Bacik , linux-btrfs@vger.kernel.org, dm-devel@redhat.com, Mike Snitzer , Alasdair Kergon , Daniel Vetter , intel-gfx@lists.freedesktop.org, Joonas Lahtinen , Maarten Lankhorst , dri-devel@lists.freedesktop.org, David Airlie , Jani Nikula , Rodrigo Vivi , Tom Zanussi , Miroslav Benes , linux-arch@vger.kernel.org Message-ID: <20190425094519.eX5c-cwSwCnBqChagDcap2zxehuIJOPBZUvt_CIOBM4@z> No more users of the struct stack_trace based interfaces. Remove them. Remove the macro stubs for !CONFIG_STACKTRACE as well as they are pointless because the storage on the call sites is conditional on CONFIG_STACKTRACE already. No point to be 'smart'. Signed-off-by: Thomas Gleixner --- include/linux/stacktrace.h | 17 ----------------- kernel/stacktrace.c | 14 -------------- 2 files changed, 31 deletions(-) --- a/include/linux/stacktrace.h +++ b/include/linux/stacktrace.h @@ -36,24 +36,7 @@ extern void save_stack_trace_tsk(struct struct stack_trace *trace); extern int save_stack_trace_tsk_reliable(struct task_struct *tsk, struct stack_trace *trace); - -extern void print_stack_trace(struct stack_trace *trace, int spaces); -extern int snprint_stack_trace(char *buf, size_t size, - struct stack_trace *trace, int spaces); - -#ifdef CONFIG_USER_STACKTRACE_SUPPORT extern void save_stack_trace_user(struct stack_trace *trace); -#else -# define save_stack_trace_user(trace) do { } while (0) -#endif - -#else /* !CONFIG_STACKTRACE */ -# define save_stack_trace(trace) do { } while (0) -# define save_stack_trace_tsk(tsk, trace) do { } while (0) -# define save_stack_trace_user(trace) do { } while (0) -# define print_stack_trace(trace, spaces) do { } while (0) -# define snprint_stack_trace(buf, size, trace, spaces) do { } while (0) -# define save_stack_trace_tsk_reliable(tsk, trace) ({ -ENOSYS; }) #endif /* CONFIG_STACKTRACE */ #if defined(CONFIG_STACKTRACE) && defined(CONFIG_HAVE_RELIABLE_STACKTRACE) --- a/kernel/stacktrace.c +++ b/kernel/stacktrace.c @@ -30,12 +30,6 @@ void stack_trace_print(unsigned long *en } EXPORT_SYMBOL_GPL(stack_trace_print); -void print_stack_trace(struct stack_trace *trace, int spaces) -{ - stack_trace_print(trace->entries, trace->nr_entries, spaces); -} -EXPORT_SYMBOL_GPL(print_stack_trace); - /** * stack_trace_snprint - Print the entries in the stack trace into a buffer * @buf: Pointer to the print buffer @@ -72,14 +66,6 @@ int stack_trace_snprint(char *buf, size_ } EXPORT_SYMBOL_GPL(stack_trace_snprint); -int snprint_stack_trace(char *buf, size_t size, - struct stack_trace *trace, int spaces) -{ - return stack_trace_snprint(buf, size, trace->entries, - trace->nr_entries, spaces); -} -EXPORT_SYMBOL_GPL(snprint_stack_trace); - /* * Architectures that do not implement save_stack_trace_*() * get these weak aliases and once-per-bootup warnings