Re: [PATCH v14 01/11] bitops: Introduce the for_each_set_clump8 macro

William Breathitt Gray
2019-04-27T00:40:26Z

On Fri, Mar 29, 2019 at 12:04:08PM +0900, William Breathitt Gray wrote:
> This macro iterates for each 8-bit group of bits (clump) with set bits,
> within a bitmap memory region. For each iteration, "start" is set to the
> bit offset of the found clump, while the respective clump value is
> stored to the location pointed by "clump". Additionally, the
> bitmap_get_value8 and bitmap_set_value8 functions are introduced to
> respectively get and set an 8-bit value in a bitmap memory region.
>
> Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Suggested-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> Suggested-by: Lukas Wunner <lukas@wunner.de>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
> ---
> include/asm-generic/bitops/find.h | 61 +++++++++++++++++++++++++++++++
> include/linux/bitops.h | 5 +++
> 2 files changed, 66 insertions(+)

Andrew, Linus,

I reverted your Acked-by/Reviewed-by lines to Cc in this release because
the code has significantly changed from the simplification effort. If
you are satisfied with these changes, please ack to confirm.

William Breathitt Gray