From: Peter Zijlstra <peterz@infradead.org>
To: Marco Elver <elver@google.com>
Cc: Dmitry Vyukov <dvyukov@google.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Alexander Potapenko <glider@google.com>,
Andrey Konovalov <andreyknvl@google.com>,
Jonathan Corbet <corbet@lwn.net>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
the arch/x86 maintainers <x86@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Josh Poimboeuf <jpoimboe@redhat.com>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-arch <linux-arch@vger.kernel.org>,
kasan-dev <kasan-dev@googlegroups.com>
Subject: Re: [PATCH 2/3] tools/objtool: add kasan_check_* to uaccess whitelist
Date: Wed, 29 May 2019 11:58:15 +0200 [thread overview]
Message-ID: <20190529095815.GL2623@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <CANpmjNP7nNO36p03_1fksx1O2-MNevHzF7revUwQ3b7+RR0y+w@mail.gmail.com>
On Wed, May 29, 2019 at 11:46:10AM +0200, Marco Elver wrote:
> On Wed, 29 May 2019 at 10:55, Dmitry Vyukov <dvyukov@google.com> wrote:
> >
> > On Tue, May 28, 2019 at 7:19 PM Peter Zijlstra <peterz@infradead.org> wrote:
> > >
> > > On Tue, May 28, 2019 at 06:32:57PM +0200, Marco Elver wrote:
> > > > This is a pre-requisite for enabling bitops instrumentation. Some bitops
> > > > may safely be used with instrumentation in uaccess regions.
> > > >
> > > > For example, on x86, `test_bit` is used to test a CPU-feature in a
> > > > uaccess region: arch/x86/ia32/ia32_signal.c:361
> > >
> > > That one can easily be moved out of the uaccess region. Any else?
> >
> > Marco, try to update config with "make allyesconfig" and then build
> > the kernel without this change.
> >
>
> Done. The only instance of the uaccess warning is still in
> arch/x86/ia32/ia32_signal.c.
>
> Change the patch to move this access instead? Let me know what you prefer.
Yes, I think that might be best. The whitelist should be minimal.
next prev parent reply other threads:[~2019-05-29 9:58 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 16:32 [PATCH 1/3] lib/test_kasan: Add bitops tests Marco Elver
2019-05-28 16:32 ` Marco Elver
2019-05-28 16:32 ` [PATCH 2/3] tools/objtool: add kasan_check_* to uaccess whitelist Marco Elver
2019-05-28 16:32 ` Marco Elver
2019-05-28 17:19 ` Peter Zijlstra
2019-05-28 17:19 ` Peter Zijlstra
2019-05-29 8:54 ` Dmitry Vyukov
2019-05-29 8:54 ` Dmitry Vyukov
2019-05-29 9:46 ` Marco Elver
2019-05-29 9:46 ` Marco Elver
2019-05-29 9:58 ` Peter Zijlstra [this message]
2019-05-29 9:58 ` Peter Zijlstra
2019-05-28 16:32 ` [PATCH 3/3] asm-generic, x86: Add bitops instrumentation for KASAN Marco Elver
2019-05-28 16:32 ` Marco Elver
2019-05-28 16:50 ` Mark Rutland
2019-05-28 16:50 ` Mark Rutland
2019-05-29 8:53 ` Dmitry Vyukov
2019-05-29 8:53 ` Dmitry Vyukov
2019-05-29 9:20 ` Marco Elver
2019-05-29 9:20 ` Marco Elver
2019-05-29 10:01 ` Peter Zijlstra
2019-05-29 10:01 ` Peter Zijlstra
2019-05-29 10:16 ` Marco Elver
2019-05-29 10:16 ` Marco Elver
2019-05-29 10:30 ` Peter Zijlstra
2019-05-29 10:30 ` Peter Zijlstra
2019-05-29 10:57 ` Dmitry Vyukov
2019-05-29 10:57 ` Dmitry Vyukov
2019-05-29 11:20 ` David Laight
2019-05-29 11:20 ` David Laight
2019-05-29 12:01 ` Peter Zijlstra
2019-05-29 12:01 ` Peter Zijlstra
2019-05-29 11:23 ` Andrey Ryabinin
2019-05-29 11:23 ` Andrey Ryabinin
2019-05-29 11:29 ` Dmitry Vyukov
2019-05-29 11:29 ` Dmitry Vyukov
2019-05-29 12:01 ` Peter Zijlstra
2019-05-29 12:01 ` Peter Zijlstra
2019-05-29 13:26 ` Mark Rutland
2019-05-29 13:26 ` Mark Rutland
2019-05-28 16:50 ` [PATCH 1/3] lib/test_kasan: Add bitops tests Mark Rutland
2019-05-28 16:50 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190529095815.GL2623@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=andreyknvl@google.com \
--cc=arnd@arndb.de \
--cc=aryabinin@virtuozzo.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=hpa@zytor.com \
--cc=jpoimboe@redhat.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox