From: Marco Elver <elver@google.com>
To: peterz@infradead.org, aryabinin@virtuozzo.com,
dvyukov@google.com, glider@google.com, andreyknvl@google.com,
mark.rutland@arm.com, hpa@zytor.com
Cc: corbet@lwn.net, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, x86@kernel.org, arnd@arndb.de, jpoimboe@redhat.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, kasan-dev@googlegroups.com,
Marco Elver <elver@google.com>
Subject: [PATCH v3 2/3] x86: Use static_cpu_has in uaccess region to avoid instrumentation
Date: Fri, 31 May 2019 17:08:30 +0200 [thread overview]
Message-ID: <20190531150828.157832-3-elver@google.com> (raw)
In-Reply-To: <20190531150828.157832-1-elver@google.com>
This patch is a pre-requisite for enabling KASAN bitops instrumentation;
using static_cpu_has instead of boot_cpu_has avoids instrumentation of
test_bit inside the uaccess region. With instrumentation, the KASAN
check would otherwise be flagged by objtool.
For consistency, kernel/signal.c was changed to mirror this change,
however, is never instrumented with KASAN (currently unsupported under
x86 32bit).
Signed-off-by: Marco Elver <elver@google.com>
Suggested-by: H. Peter Anvin <hpa@zytor.com>
---
Changes in v3:
* Use static_cpu_has instead of moving boot_cpu_has outside uaccess
region.
Changes in v2:
* Replaces patch: 'tools/objtool: add kasan_check_* to uaccess
whitelist'
---
arch/x86/ia32/ia32_signal.c | 2 +-
arch/x86/kernel/signal.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/ia32/ia32_signal.c b/arch/x86/ia32/ia32_signal.c
index 629d1ee05599..1cee10091b9f 100644
--- a/arch/x86/ia32/ia32_signal.c
+++ b/arch/x86/ia32/ia32_signal.c
@@ -358,7 +358,7 @@ int ia32_setup_rt_frame(int sig, struct ksignal *ksig,
put_user_ex(ptr_to_compat(&frame->uc), &frame->puc);
/* Create the ucontext. */
- if (boot_cpu_has(X86_FEATURE_XSAVE))
+ if (static_cpu_has(X86_FEATURE_XSAVE))
put_user_ex(UC_FP_XSTATE, &frame->uc.uc_flags);
else
put_user_ex(0, &frame->uc.uc_flags);
diff --git a/arch/x86/kernel/signal.c b/arch/x86/kernel/signal.c
index 364813cea647..52eb1d551aed 100644
--- a/arch/x86/kernel/signal.c
+++ b/arch/x86/kernel/signal.c
@@ -391,7 +391,7 @@ static int __setup_rt_frame(int sig, struct ksignal *ksig,
put_user_ex(&frame->uc, &frame->puc);
/* Create the ucontext. */
- if (boot_cpu_has(X86_FEATURE_XSAVE))
+ if (static_cpu_has(X86_FEATURE_XSAVE))
put_user_ex(UC_FP_XSTATE, &frame->uc.uc_flags);
else
put_user_ex(0, &frame->uc.uc_flags);
--
2.22.0.rc1.257.g3120a18244-goog
next prev parent reply other threads:[~2019-05-31 15:08 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 15:08 [PATCH v3 0/3] Bitops instrumentation for KASAN Marco Elver
2019-05-31 15:08 ` Marco Elver
2019-05-31 15:08 ` [PATCH v3 1/3] lib/test_kasan: Add bitops tests Marco Elver
2019-05-31 15:08 ` Marco Elver
2019-05-31 15:57 ` Mark Rutland
2019-05-31 15:57 ` Mark Rutland
2019-06-13 10:49 ` Andrey Ryabinin
2019-06-13 10:49 ` Andrey Ryabinin
2019-06-13 12:35 ` Marco Elver
2019-06-13 12:35 ` Marco Elver
2019-05-31 15:08 ` Marco Elver [this message]
2019-05-31 15:08 ` [PATCH v3 2/3] x86: Use static_cpu_has in uaccess region to avoid instrumentation Marco Elver
2019-06-07 9:43 ` Marco Elver
2019-06-07 9:43 ` Marco Elver
2019-06-12 14:12 ` Dmitry Vyukov
2019-06-12 14:12 ` Dmitry Vyukov
2019-06-13 9:21 ` Peter Zijlstra
2019-06-13 9:21 ` Peter Zijlstra
2019-06-13 10:50 ` Andrey Ryabinin
2019-06-13 10:50 ` Andrey Ryabinin
2019-05-31 15:08 ` [PATCH v3 3/3] asm-generic, x86: Add bitops instrumentation for KASAN Marco Elver
2019-05-31 15:08 ` Marco Elver
2019-05-31 16:01 ` Mark Rutland
2019-05-31 16:01 ` Mark Rutland
2019-06-13 10:51 ` Andrey Ryabinin
2019-06-13 10:51 ` Andrey Ryabinin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190531150828.157832-3-elver@google.com \
--to=elver@google.com \
--cc=andreyknvl@google.com \
--cc=arnd@arndb.de \
--cc=aryabinin@virtuozzo.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=hpa@zytor.com \
--cc=jpoimboe@redhat.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).