From: Oleg Nesterov <oleg@redhat.com>
To: David Laight <David.Laight@ACULAB.COM>
Cc: "'Eric W. Biederman'" <ebiederm@xmission.com>,
'Andrew Morton' <akpm@linux-foundation.org>,
'Deepa Dinamani' <deepa.kernel@gmail.com>,
"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
"'arnd@arndb.de'" <arnd@arndb.de>,
"'dbueso@suse.de'" <dbueso@suse.de>,
"'axboe@kernel.dk'" <axboe@kernel.dk>,
"'dave@stgolabs.net'" <dave@stgolabs.net>,
"'e@80x24.org'" <e@80x24.org>,
"'jbaron@akamai.com'" <jbaron@akamai.com>,
"'linux-fsdevel@vger.kernel.org'" <linux-fsdevel@vger.kernel.org>,
"'linux-aio@kvack.org'" <linux-aio@kvack.org>,
"'omar.kilani@gmail.com'" <omar.kilani@gmail.com>,
"'tglx@linutronix.de'" <tglx@linutronix.de>,
'Al Viro' <viro@ZenIV.linux.org.uk>,
'Linus Torvalds' <torvalds@linux-foundation.org>,
"'linux-arch@vger.kernel.org'" <linux-arch@>
Subject: Re: [RFC PATCH 1/5] signal: Teach sigsuspend to use set_user_sigmask
Date: Wed, 12 Jun 2019 15:35:20 +0200 [thread overview]
Message-ID: <20190612133519.GA3276@redhat.com> (raw)
In-Reply-To: <a11bb1a2a6de4cf5aa773ea79c602f1a@AcuMS.aculab.com>
On 06/12, David Laight wrote:
>
> > > If I add a signal handler for SIGINT it is called when pselect()
> > > returns regardless of the return value.
> >
> > That is odd. Is this with Oleg's fix applied?
>
> No it is a 5.1.0-rc5 kernel with no related local patches.
> So it is the 'historic' behaviour of pselect().
No, this is not historic behaviour,
> But not the original one! Under 2.6.22-5-31 the signal handler isn't caller
> when pselect() returns 1.
This is historic behaviour.
And it was broken by 854a6ed56839a4 ("signal: Add restore_user_sigmask()").
And this is what we already discussed many, many times in this thread ;)
Oleg.
WARNING: multiple messages have this Message-ID (diff)
From: Oleg Nesterov <oleg@redhat.com>
To: David Laight <David.Laight@ACULAB.COM>
Cc: "'Eric W. Biederman'" <ebiederm@xmission.com>,
'Andrew Morton' <akpm@linux-foundation.org>,
'Deepa Dinamani' <deepa.kernel@gmail.com>,
"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
"'arnd@arndb.de'" <arnd@arndb.de>,
"'dbueso@suse.de'" <dbueso@suse.de>,
"'axboe@kernel.dk'" <axboe@kernel.dk>,
"'dave@stgolabs.net'" <dave@stgolabs.net>,
"'e@80x24.org'" <e@80x24.org>,
"'jbaron@akamai.com'" <jbaron@akamai.com>,
"'linux-fsdevel@vger.kernel.org'" <linux-fsdevel@vger.kernel.org>,
"'linux-aio@kvack.org'" <linux-aio@kvack.org>,
"'omar.kilani@gmail.com'" <omar.kilani@gmail.com>,
"'tglx@linutronix.de'" <tglx@linutronix.de>,
'Al Viro' <viro@ZenIV.linux.org.uk>,
'Linus Torvalds' <torvalds@linux-foundation.org>,
"'linux-arch@vger.kernel.org'" <linux-arch@vger.kernel.org>
Subject: Re: [RFC PATCH 1/5] signal: Teach sigsuspend to use set_user_sigmask
Date: Wed, 12 Jun 2019 15:35:20 +0200 [thread overview]
Message-ID: <20190612133519.GA3276@redhat.com> (raw)
Message-ID: <20190612133520.qoAHZnEGuO9nQt3upDxM6ZGIGjW1zSfmtl-KbelzuJ4@z> (raw)
In-Reply-To: <a11bb1a2a6de4cf5aa773ea79c602f1a@AcuMS.aculab.com>
On 06/12, David Laight wrote:
>
> > > If I add a signal handler for SIGINT it is called when pselect()
> > > returns regardless of the return value.
> >
> > That is odd. Is this with Oleg's fix applied?
>
> No it is a 5.1.0-rc5 kernel with no related local patches.
> So it is the 'historic' behaviour of pselect().
No, this is not historic behaviour,
> But not the original one! Under 2.6.22-5-31 the signal handler isn't caller
> when pselect() returns 1.
This is historic behaviour.
And it was broken by 854a6ed56839a4 ("signal: Add restore_user_sigmask()").
And this is what we already discussed many, many times in this thread ;)
Oleg.
next prev parent reply other threads:[~2019-06-12 13:35 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190522032144.10995-1-deepa.kernel@gmail.com>
[not found] ` <20190529161157.GA27659@redhat.com>
[not found] ` <20190604134117.GA29963@redhat.com>
[not found] ` <20190606140814.GA13440@redhat.com>
2019-06-07 21:39 ` [RFC PATCH 0/5]: Removing saved_sigmask Eric W. Biederman
2019-06-07 21:39 ` Eric W. Biederman
2019-06-07 21:41 ` [RFC PATCH 1/5] signal: Teach sigsuspend to use set_user_sigmask Eric W. Biederman
2019-06-07 21:41 ` Eric W. Biederman
2019-06-07 22:07 ` Linus Torvalds
2019-06-07 22:07 ` Linus Torvalds
2019-06-10 16:22 ` Oleg Nesterov
2019-06-10 16:22 ` Oleg Nesterov
2019-06-10 21:20 ` Eric W. Biederman
2019-06-10 21:20 ` Eric W. Biederman
2019-06-11 9:52 ` David Laight
2019-06-11 9:52 ` David Laight
2019-06-11 11:14 ` David Laight
2019-06-11 11:14 ` David Laight
2019-06-12 12:55 ` Eric W. Biederman
2019-06-12 12:55 ` Eric W. Biederman
2019-06-12 13:24 ` David Laight
2019-06-12 13:24 ` David Laight
2019-06-12 13:35 ` Oleg Nesterov [this message]
2019-06-12 13:35 ` Oleg Nesterov
2019-06-12 13:39 ` David Laight
2019-06-12 13:39 ` David Laight
2019-06-11 15:46 ` David Laight
2019-06-11 15:46 ` David Laight
2019-06-12 12:40 ` Eric W. Biederman
2019-06-12 12:40 ` Eric W. Biederman
2019-06-12 13:45 ` Oleg Nesterov
2019-06-12 13:45 ` Oleg Nesterov
2019-06-12 14:18 ` David Laight
2019-06-12 14:18 ` David Laight
2019-06-12 15:11 ` Eric W. Biederman
2019-06-12 15:11 ` Eric W. Biederman
2019-06-12 15:37 ` Oleg Nesterov
2019-06-12 15:37 ` Oleg Nesterov
2019-06-13 8:48 ` David Laight
2019-06-13 8:48 ` David Laight
2019-06-13 9:43 ` Oleg Nesterov
2019-06-13 9:43 ` Oleg Nesterov
2019-06-13 10:56 ` David Laight
2019-06-13 10:56 ` David Laight
2019-06-13 12:43 ` Oleg Nesterov
2019-06-13 12:43 ` Oleg Nesterov
2019-06-11 18:55 ` Oleg Nesterov
2019-06-11 18:55 ` Oleg Nesterov
2019-06-11 19:02 ` Eric W. Biederman
2019-06-11 19:02 ` Eric W. Biederman
2019-06-12 8:39 ` David Laight
2019-06-12 8:39 ` David Laight
2019-06-12 13:09 ` Eric W. Biederman
2019-06-12 13:09 ` Eric W. Biederman
2019-06-07 21:41 ` [RFC PATCH 2/5] signal/kvm: Stop using sigprocmask in kvm_sigset_(activate|deactivate) Eric W. Biederman
2019-06-07 21:41 ` Eric W. Biederman
2019-06-07 21:42 ` [RFC PATCH 3/5] signal: Always keep real_blocked in sync with blocked Eric W. Biederman
2019-06-07 21:42 ` Eric W. Biederman
2019-06-07 21:43 ` [RFC PATCH 4/5] signal: Remove saved_sigmask Eric W. Biederman
2019-06-07 21:43 ` Eric W. Biederman
2019-06-07 21:44 ` [RFC PATCH 5/5] signal: Remove the unnecessary restore_sigmask flag Eric W. Biederman
2019-06-07 21:44 ` Eric W. Biederman
2019-06-11 18:58 ` [RFC PATCH 0/5]: Removing saved_sigmask Oleg Nesterov
2019-06-11 18:58 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612133519.GA3276@redhat.com \
--to=oleg@redhat.com \
--cc=David.Laight@ACULAB.COM \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=dave@stgolabs.net \
--cc=dbueso@suse.de \
--cc=deepa.kernel@gmail.com \
--cc=e@80x24.org \
--cc=ebiederm@xmission.com \
--cc=jbaron@akamai.com \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=omar.kilani@gmail.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).