From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oleg Nesterov Subject: Re: [RFC PATCH 1/5] signal: Teach sigsuspend to use set_user_sigmask Date: Wed, 12 Jun 2019 15:35:20 +0200 Message-ID: <20190612133519.GA3276@redhat.com> References: <20190604134117.GA29963@redhat.com> <20190606140814.GA13440@redhat.com> <87k1dxaxcl.fsf_-_@xmission.com> <87ef45axa4.fsf_-_@xmission.com> <20190610162244.GB8127@redhat.com> <87lfy96sta.fsf@xmission.com> <9199239a450d4ea397783ccf98742220@AcuMS.aculab.com> <95decc6904754004af8a5546aca0468a@AcuMS.aculab.com> <87pnnj2ca0.fsf@xmission.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: David Laight Cc: "'Eric W. Biederman'" , 'Andrew Morton' , 'Deepa Dinamani' , "'linux-kernel@vger.kernel.org'" , "'arnd@arndb.de'" , "'dbueso@suse.de'" , "'axboe@kernel.dk'" , "'dave@stgolabs.net'" , "'e@80x24.org'" , "'jbaron@akamai.com'" , "'linux-fsdevel@vger.kernel.org'" , "'linux-aio@kvack.org'" , "'omar.kilani@gmail.com'" , "'tglx@linutronix.de'" , 'Al Viro' , 'Linus Torvalds' , "'linux-arch@vger.kernel.org'" List-Id: linux-arch.vger.kernel.org On 06/12, David Laight wrote: > > > > If I add a signal handler for SIGINT it is called when pselect() > > > returns regardless of the return value. > > > > That is odd. Is this with Oleg's fix applied? > > No it is a 5.1.0-rc5 kernel with no related local patches. > So it is the 'historic' behaviour of pselect(). No, this is not historic behaviour, > But not the original one! Under 2.6.22-5-31 the signal handler isn't caller > when pselect() returns 1. This is historic behaviour. And it was broken by 854a6ed56839a4 ("signal: Add restore_user_sigmask()"). And this is what we already discussed many, many times in this thread ;) Oleg. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:51930 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726747AbfFLNfi (ORCPT ); Wed, 12 Jun 2019 09:35:38 -0400 Date: Wed, 12 Jun 2019 15:35:20 +0200 From: Oleg Nesterov Subject: Re: [RFC PATCH 1/5] signal: Teach sigsuspend to use set_user_sigmask Message-ID: <20190612133519.GA3276@redhat.com> References: <20190604134117.GA29963@redhat.com> <20190606140814.GA13440@redhat.com> <87k1dxaxcl.fsf_-_@xmission.com> <87ef45axa4.fsf_-_@xmission.com> <20190610162244.GB8127@redhat.com> <87lfy96sta.fsf@xmission.com> <9199239a450d4ea397783ccf98742220@AcuMS.aculab.com> <95decc6904754004af8a5546aca0468a@AcuMS.aculab.com> <87pnnj2ca0.fsf@xmission.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: David Laight Cc: "'Eric W. Biederman'" , 'Andrew Morton' , 'Deepa Dinamani' , "'linux-kernel@vger.kernel.org'" , "'arnd@arndb.de'" , "'dbueso@suse.de'" , "'axboe@kernel.dk'" , "'dave@stgolabs.net'" , "'e@80x24.org'" , "'jbaron@akamai.com'" , "'linux-fsdevel@vger.kernel.org'" , "'linux-aio@kvack.org'" , "'omar.kilani@gmail.com'" , "'tglx@linutronix.de'" , 'Al Viro' , 'Linus Torvalds' , "'linux-arch@vger.kernel.org'" Message-ID: <20190612133520.qoAHZnEGuO9nQt3upDxM6ZGIGjW1zSfmtl-KbelzuJ4@z> On 06/12, David Laight wrote: > > > > If I add a signal handler for SIGINT it is called when pselect() > > > returns regardless of the return value. > > > > That is odd. Is this with Oleg's fix applied? > > No it is a 5.1.0-rc5 kernel with no related local patches. > So it is the 'historic' behaviour of pselect(). No, this is not historic behaviour, > But not the original one! Under 2.6.22-5-31 the signal handler isn't caller > when pselect() returns 1. This is historic behaviour. And it was broken by 854a6ed56839a4 ("signal: Add restore_user_sigmask()"). And this is what we already discussed many, many times in this thread ;) Oleg.