From: Peter Zijlstra <peterz@infradead.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Steffen Klassert <steffen.klassert@secunet.com>,
Daniel Jordan <daniel.m.jordan@oracle.com>,
andrea.parri@amarulasolutions.com, boqun.feng@gmail.com,
paulmck@linux.ibm.com, linux-arch@vger.kernel.org,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] padata: Use RCU when fetching pd from do_serial
Date: Tue, 16 Jul 2019 15:50:10 +0200 [thread overview]
Message-ID: <20190716135010.GC3402@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20190716131807.twahbbdff6jhpnu2@gondor.apana.org.au>
On Tue, Jul 16, 2019 at 09:18:07PM +0800, Herbert Xu wrote:
> On Tue, Jul 16, 2019 at 03:15:20PM +0200, Peter Zijlstra wrote:
> >
> > > @@ -367,7 +368,7 @@ void padata_do_serial(struct padata_priv *padata)
> > > struct parallel_data *pd;
> > > int reorder_via_wq = 0;
> > >
> > > - pd = padata->pd;
> > > + pd = rcu_dereference_bh(padata->inst->pd);
> > >
> > > cpu = get_cpu();
> > >
> >
> > That's weird for not having a matching assign and lacking comments to
> > explain that.
>
> There is a matching rcu_assign_pointer. But we should add some
> RCU markers.
>
> Or perhaps you're misreading the level of indirections :)
Could well be, I'm not much familiar with this code; I'll look more
careful.
next prev parent reply other threads:[~2019-07-16 13:50 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 22:12 [PATCH] padata: use smp_mb in padata_reorder to avoid orphaned padata jobs Daniel Jordan
2019-07-11 22:12 ` Daniel Jordan
2019-07-12 10:06 ` Herbert Xu
2019-07-12 10:06 ` Herbert Xu
2019-07-12 10:10 ` Steffen Klassert
2019-07-12 10:10 ` Steffen Klassert
2019-07-12 16:07 ` Daniel Jordan
2019-07-12 16:07 ` Daniel Jordan
2019-07-13 5:03 ` Herbert Xu
2019-07-13 5:03 ` Herbert Xu
2019-07-15 16:10 ` Daniel Jordan
2019-07-15 16:10 ` Daniel Jordan
2019-07-16 10:04 ` Herbert Xu
2019-07-16 10:04 ` Herbert Xu
2019-07-16 11:14 ` Steffen Klassert
2019-07-16 11:14 ` Steffen Klassert
2019-07-16 12:57 ` [PATCH] padata: Use RCU when fetching pd from do_serial Herbert Xu
2019-07-16 12:57 ` Herbert Xu
2019-07-16 13:09 ` Herbert Xu
2019-07-16 13:09 ` Herbert Xu
2019-07-16 13:23 ` [v2 PATCH] " Herbert Xu
2019-07-16 13:23 ` Herbert Xu
2019-07-17 8:36 ` Steffen Klassert
2019-07-17 8:36 ` Steffen Klassert
2019-07-17 8:50 ` Herbert Xu
2019-07-17 8:50 ` Herbert Xu
2019-07-17 8:28 ` [PATCH] " Steffen Klassert
2019-07-17 8:28 ` Steffen Klassert
2019-07-17 8:47 ` Herbert Xu
2019-07-17 8:47 ` Herbert Xu
2019-07-17 8:53 ` Steffen Klassert
2019-07-17 8:53 ` Steffen Klassert
2019-07-16 13:15 ` Peter Zijlstra
2019-07-16 13:15 ` Peter Zijlstra
2019-07-16 13:18 ` Herbert Xu
2019-07-16 13:18 ` Herbert Xu
2019-07-16 13:50 ` Peter Zijlstra [this message]
2019-07-16 13:50 ` Peter Zijlstra
2019-07-16 13:52 ` Herbert Xu
2019-07-16 13:52 ` Herbert Xu
2019-07-16 12:53 ` [PATCH] padata: use smp_mb in padata_reorder to avoid orphaned padata jobs Andrea Parri
2019-07-16 12:53 ` Andrea Parri
2019-07-16 13:13 ` Peter Zijlstra
2019-07-16 13:13 ` Peter Zijlstra
2019-07-16 15:01 ` Herbert Xu
2019-07-16 15:01 ` Herbert Xu
2019-07-16 15:44 ` Daniel Jordan
2019-07-16 15:44 ` Daniel Jordan
2019-07-16 16:32 ` [PATCH v2] " Daniel Jordan
2019-07-16 16:32 ` Daniel Jordan
2019-07-17 11:11 ` [PATCH] padata: Replace delayed timer with immediate workqueue in padata_reorder Herbert Xu
2019-07-17 11:11 ` Herbert Xu
2019-07-17 18:32 ` Daniel Jordan
2019-07-17 18:32 ` Daniel Jordan
2019-07-18 3:31 ` Herbert Xu
2019-07-18 3:31 ` Herbert Xu
2019-07-18 14:27 ` Daniel Jordan
2019-07-18 14:27 ` Daniel Jordan
2019-07-18 14:56 ` Herbert Xu
2019-07-18 14:56 ` Herbert Xu
2019-07-18 15:01 ` [v2 PATCH] " Herbert Xu
2019-07-18 15:01 ` Herbert Xu
2019-07-19 14:37 ` Daniel Jordan
2019-07-19 14:37 ` Daniel Jordan
2019-07-19 14:55 ` Herbert Xu
2019-07-19 14:55 ` Herbert Xu
2019-07-19 14:27 ` [PATCH] " Daniel Jordan
2019-07-19 14:27 ` Daniel Jordan
2019-07-17 23:21 ` Daniel Jordan
2019-07-17 23:21 ` Daniel Jordan
2019-07-18 3:30 ` Herbert Xu
2019-07-18 3:30 ` Herbert Xu
2019-07-18 14:25 ` Daniel Jordan
2019-07-18 14:25 ` Daniel Jordan
2019-07-18 14:49 ` Herbert Xu
2019-07-18 14:49 ` Herbert Xu
2019-07-19 14:21 ` Daniel Jordan
2019-07-19 14:21 ` Daniel Jordan
2019-07-18 5:42 ` [PATCH v2] padata: use smp_mb in padata_reorder to avoid orphaned padata jobs Herbert Xu
2019-07-18 5:42 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190716135010.GC3402@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=andrea.parri@amarulasolutions.com \
--cc=boqun.feng@gmail.com \
--cc=daniel.m.jordan@oracle.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arch@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.ibm.com \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox