From: "Paul E. McKenney" <paulmck@linux.ibm.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: "Joel Fernandes (Google)" <joel@joelfernandes.org>,
linux-kernel@vger.kernel.org, Akira Yokosawa <akiyks@gmail.com>,
Andrea Parri <andrea.parri@amarulasolutions.com>,
Boqun Feng <boqun.feng@gmail.com>,
Daniel Lustig <dlustig@nvidia.com>,
David Howells <dhowells@redhat.com>,
Ingo Molnar <mingo@kernel.org>,
Jade Alglave <j.alglave@ucl.ac.uk>,
linux-arch@vger.kernel.org, Luc Maranget <luc.maranget@inria.fr>,
Nicholas Piggin <npiggin@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Will Deacon <will@kernel.org>
Subject: Re: [PATCH] Use term cumul-fence instead of fence in ->prop ordering example
Date: Tue, 30 Jul 2019 08:58:47 -0700 [thread overview]
Message-ID: <20190730155847.GW14271@linux.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1907291641220.760-100000@netrider.rowland.org>
On Mon, Jul 29, 2019 at 04:41:34PM -0400, Alan Stern wrote:
> On Mon, 29 Jul 2019, Joel Fernandes (Google) wrote:
>
> > To reduce ambiguity in the more exotic ->prop ordering example, let us
> > use the term cumul-fence instead fence for the 2 fences, so that the
> > implict ->rfe on loads/stores to Y are covered by the description.
> >
> > Link: https://lore.kernel.org/lkml/20190729121745.GA140682@google.com
> >
> > Suggested-by: Alan Stern <stern@rowland.harvard.edu>
> > Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
> > ---
> > tools/memory-model/Documentation/explanation.txt | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/tools/memory-model/Documentation/explanation.txt b/tools/memory-model/Documentation/explanation.txt
> > index 68caa9a976d0..634dc6db26c4 100644
> > --- a/tools/memory-model/Documentation/explanation.txt
> > +++ b/tools/memory-model/Documentation/explanation.txt
> > @@ -1302,7 +1302,7 @@ followed by an arbitrary number of cumul-fence links, ending with an
> > rfe link. You can concoct more exotic examples, containing more than
> > one fence, although this quickly leads to diminishing returns in terms
> > of complexity. For instance, here's an example containing a coe link
> > -followed by two fences and an rfe link, utilizing the fact that
> > +followed by two cumul-fences and an rfe link, utilizing the fact that
> > release fences are A-cumulative:
> >
> > int x, y, z;
> > @@ -1334,10 +1334,10 @@ If x = 2, r0 = 1, and r2 = 1 after this code runs then there is a prop
> > link from P0's store to its load. This is because P0's store gets
> > overwritten by P1's store since x = 2 at the end (a coe link), the
> > smp_wmb() ensures that P1's store to x propagates to P2 before the
> > -store to y does (the first fence), the store to y propagates to P2
> > +store to y does (the first cumul-fence), the store to y propagates to P2
> > before P2's load and store execute, P2's smp_store_release()
> > guarantees that the stores to x and y both propagate to P0 before the
> > -store to z does (the second fence), and P0's load executes after the
> > +store to z does (the second cumul-fence), and P0's load executes after the
> > store to z has propagated to P0 (an rfe link).
> >
> > In summary, the fact that the hb relation links memory access events
>
> Acked-by: Alan Stern <stern@rowland.harvard.edu>
Queued with Alan's ack, thank you both!
Thanx, Paul
next prev parent reply other threads:[~2019-07-30 15:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 12:36 [PATCH] Use term cumul-fence instead of fence in ->prop ordering example Joel Fernandes (Google)
2019-07-29 12:36 ` Joel Fernandes (Google)
2019-07-29 20:41 ` Alan Stern
2019-07-29 20:41 ` Alan Stern
2019-07-30 15:58 ` Paul E. McKenney [this message]
2019-07-30 15:58 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190730155847.GW14271@linux.ibm.com \
--to=paulmck@linux.ibm.com \
--cc=akiyks@gmail.com \
--cc=andrea.parri@amarulasolutions.com \
--cc=boqun.feng@gmail.com \
--cc=dhowells@redhat.com \
--cc=dlustig@nvidia.com \
--cc=j.alglave@ucl.ac.uk \
--cc=joel@joelfernandes.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luc.maranget@inria.fr \
--cc=mingo@kernel.org \
--cc=npiggin@gmail.com \
--cc=peterz@infradead.org \
--cc=stern@rowland.harvard.edu \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox