From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Maennich Subject: Re: [Cocci] [PATCH v2 08/10] scripts: Coccinelle script for namespace dependencies. Date: Wed, 14 Aug 2019 09:03:07 +0100 Message-ID: <20190814080307.GA2911@google.com> References: <20180716122125.175792-1-maco@android.com> <20190813121733.52480-1-maennich@google.com> <20190813121733.52480-9-maennich@google.com> <20190814063611.GA22387@himanshu-Vostro-3559> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Return-path: Content-Disposition: inline In-Reply-To: <20190814063611.GA22387@himanshu-Vostro-3559> Sender: linux-kernel-owner@vger.kernel.org To: Himanshu Jha Cc: linux-kernel@vger.kernel.org, maco@android.com, kstewart@linuxfoundation.org, linux-m68k@vger.kernel.org, oneukum@suse.com, Mauro Carvalho Chehab , usb-storage@lists.one-eyed-alien.net, hpa@zytor.com, joel@joelfernandes.org, sam@ravnborg.org, cocci@systeme.lip6.fr, linux-arch@vger.kernel.org, linux-scsi@vger.kernel.org, x86@kernel.org, lucas.de.marchi@gmail.com, mingo@redhat.com, geert@linux-m68k.org, stern@rowland.harvard.edu, kernel-team@android.com, sspatil@google.com, arnd@arndb.de, linux-kbuild@vger.kernel.org, Nicolas Palix , jeyu@kernel.org, Jonathan Cameron , tglx@linutronix.de, michal.lkml@markovi.net, gregkh@linuxfoundation.org, linux-usb@vger.kernel.orgNicolas Ferre List-Id: linux-arch.vger.kernel.org On Wed, Aug 14, 2019 at 12:06:11PM +0530, Himanshu Jha wrote: >On Tue, Aug 13, 2019 at 01:17:05PM +0100, Matthias Maennich wrote: >> A script that uses the '.ns_deps' file generated by modpost to >> automatically add the required symbol namespace dependencies to each >> module. >> >> Usage: >> 1) Move some symbols to a namespace with EXPORT_SYMBOL_NS() or define >> DEFAULT_SYMBOL_NAMESPACE >> 2) Run 'make' (or 'make modules') and get warnings about modules not >> importing that namespace. >> 3) Run 'make nsdeps' to automatically add required import statements >> to said modules. >> >> This makes it easer for subsystem maintainers to introduce and maintain >> symbol namespaces into their codebase. >> >> Co-developed-by: Martijn Coenen >> Signed-off-by: Martijn Coenen >> Signed-off-by: Matthias Maennich >> --- > >[] > >> MAINTAINERS | 5 ++ >> Makefile | 12 +++++ >> scripts/Makefile.modpost | 4 +- >> scripts/coccinelle/misc/add_namespace.cocci | 23 +++++++++ >> scripts/nsdeps | 54 +++++++++++++++++++++ >> 5 files changed, 97 insertions(+), 1 deletion(-) >> create mode 100644 scripts/coccinelle/misc/add_namespace.cocci >> create mode 100644 scripts/nsdeps > >[] > >> +if [ "$SPATCH_VERSION_NUM" -lt "$SPATCH_REQ_VERSION_NUM" ] ; then >> + echo 'spatch needs to be version 1.06 or higher' > >Nitpick: 1.0.6 > Good catch! Thanks! Actually it needs to be even 1.0.4, so I will just use $SPATCH_REQ_VERSION from above. >> + exit 1 >> +fi > > >-- >Himanshu Jha >Undergraduate Student >Department of Electronics & Communication >Guru Tegh Bahadur Institute of Technology From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f67.google.com ([209.85.128.67]:52446 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726383AbfHNIDO (ORCPT ); Wed, 14 Aug 2019 04:03:14 -0400 Received: by mail-wm1-f67.google.com with SMTP id o4so3585173wmh.2 for ; Wed, 14 Aug 2019 01:03:13 -0700 (PDT) Date: Wed, 14 Aug 2019 09:03:07 +0100 From: Matthias Maennich Subject: Re: [Cocci] [PATCH v2 08/10] scripts: Coccinelle script for namespace dependencies. Message-ID: <20190814080307.GA2911@google.com> References: <20180716122125.175792-1-maco@android.com> <20190813121733.52480-1-maennich@google.com> <20190813121733.52480-9-maennich@google.com> <20190814063611.GA22387@himanshu-Vostro-3559> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20190814063611.GA22387@himanshu-Vostro-3559> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Himanshu Jha Cc: linux-kernel@vger.kernel.org, maco@android.com, kstewart@linuxfoundation.org, linux-m68k@vger.kernel.org, oneukum@suse.com, Mauro Carvalho Chehab , usb-storage@lists.one-eyed-alien.net, hpa@zytor.com, joel@joelfernandes.org, sam@ravnborg.org, cocci@systeme.lip6.fr, linux-arch@vger.kernel.org, linux-scsi@vger.kernel.org, x86@kernel.org, lucas.de.marchi@gmail.com, mingo@redhat.com, geert@linux-m68k.org, stern@rowland.harvard.edu, kernel-team@android.com, sspatil@google.com, arnd@arndb.de, linux-kbuild@vger.kernel.org, Nicolas Palix , jeyu@kernel.org, Jonathan Cameron , tglx@linutronix.de, michal.lkml@markovi.net, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, Nicolas Ferre , maco@google.com, pombredanne@nexb.com, "David S. Miller" , linux-modules@vger.kernel.org Message-ID: <20190814080307.TN63YcddZ-X5Sb1VVG-2IaPvsPhUdS_-0PWrxw4DXMY@z> On Wed, Aug 14, 2019 at 12:06:11PM +0530, Himanshu Jha wrote: >On Tue, Aug 13, 2019 at 01:17:05PM +0100, Matthias Maennich wrote: >> A script that uses the '.ns_deps' file generated by modpost to >> automatically add the required symbol namespace dependencies to each >> module. >> >> Usage: >> 1) Move some symbols to a namespace with EXPORT_SYMBOL_NS() or define >> DEFAULT_SYMBOL_NAMESPACE >> 2) Run 'make' (or 'make modules') and get warnings about modules not >> importing that namespace. >> 3) Run 'make nsdeps' to automatically add required import statements >> to said modules. >> >> This makes it easer for subsystem maintainers to introduce and maintain >> symbol namespaces into their codebase. >> >> Co-developed-by: Martijn Coenen >> Signed-off-by: Martijn Coenen >> Signed-off-by: Matthias Maennich >> --- > >[] > >> MAINTAINERS | 5 ++ >> Makefile | 12 +++++ >> scripts/Makefile.modpost | 4 +- >> scripts/coccinelle/misc/add_namespace.cocci | 23 +++++++++ >> scripts/nsdeps | 54 +++++++++++++++++++++ >> 5 files changed, 97 insertions(+), 1 deletion(-) >> create mode 100644 scripts/coccinelle/misc/add_namespace.cocci >> create mode 100644 scripts/nsdeps > >[] > >> +if [ "$SPATCH_VERSION_NUM" -lt "$SPATCH_REQ_VERSION_NUM" ] ; then >> + echo 'spatch needs to be version 1.06 or higher' > >Nitpick: 1.0.6 > Good catch! Thanks! Actually it needs to be even 1.0.4, so I will just use $SPATCH_REQ_VERSION from above. >> + exit 1 >> +fi > > >-- >Himanshu Jha >Undergraduate Student >Department of Electronics & Communication >Guru Tegh Bahadur Institute of Technology