From: Christoph Hellwig <hch@infradead.org>
To: guoren@kernel.org
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, linux-csky@vger.kernel.org,
zhang_jian5@dahuatech.com, Guo Ren <ren_guo@c-sky.com>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] csky: Fixup ioremap function losing
Date: Fri, 16 Aug 2019 00:03:48 -0700 [thread overview]
Message-ID: <20190816070348.GA13766@infradead.org> (raw)
In-Reply-To: <1565868537-17753-1-git-send-email-guoren@kernel.org>
On Thu, Aug 15, 2019 at 07:28:57PM +0800, guoren@kernel.org wrote:
> From: Guo Ren <ren_guo@c-sky.com>
>
> Implement the following apis to meet usage in different scenarios.
>
> - ioremap (NonCache + StrongOrder)
> - ioremap_nocache (NonCache + StrongOrder)
> - ioremap_wc (NonCache + WeakOrder )
> - ioremap_cache ( Cache + WeakOrder )
>
> Also change flag VM_ALLOC to VM_IOREMAP in get_vm_area_caller.
Looks generally fine, but two comments:
- do you have a need for ioremap_cache? We are generally try to
phase it out in favour of memremap, and it is generally only used
by arch specific code.
- I have a big series pending to clean up the mess with our
ioremap_* functions, including adding a generic implementation
that csky should be able to use. Unless this patch is urgent it
might make sense to rebase it on top. Here is my current tree, I
plan to post it soon:
http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/generic-ioremap
next prev parent reply other threads:[~2019-08-16 7:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 11:28 [PATCH] csky: Fixup ioremap function losing guoren
2019-08-15 11:28 ` guoren
2019-08-16 7:03 ` Christoph Hellwig [this message]
2019-08-16 7:03 ` Christoph Hellwig
2019-08-18 2:20 ` Guo Ren
2019-08-18 2:20 ` Guo Ren
2019-08-18 18:21 ` Christoph Hellwig
2019-08-18 18:21 ` Christoph Hellwig
2019-08-20 8:26 ` Guo Ren
2019-08-20 8:26 ` Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190816070348.GA13766@infradead.org \
--to=hch@infradead.org \
--cc=arnd@arndb.de \
--cc=guoren@kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ren_guo@c-sky.com \
--cc=zhang_jian5@dahuatech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox