From: Christoph Hellwig <hch@infradead.org>
To: Guo Ren <guoren@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Arnd Bergmann <arnd@arndb.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arch <linux-arch@vger.kernel.org>,
linux-csky@vger.kernel.org, zhang_jian5@dahuatech.com,
Guo Ren <ren_guo@c-sky.com>
Subject: Re: [PATCH] csky: Fixup ioremap function losing
Date: Sun, 18 Aug 2019 11:21:18 -0700 [thread overview]
Message-ID: <20190818182118.GA30141@infradead.org> (raw)
In-Reply-To: <CAJF2gTTBc3+SnKMbVU4A+tekyjkd_7XUmDCUfNCcA-CZf=JUyg@mail.gmail.com>
On Sun, Aug 18, 2019 at 10:20:18AM +0800, Guo Ren wrote:
> > > Also change flag VM_ALLOC to VM_IOREMAP in get_vm_area_caller.
> >
> > Looks generally fine, but two comments:
> >
> > - do you have a need for ioremap_cache? We are generally try to
> > phase it out in favour of memremap, and it is generally only used
> > by arch specific code.
> Yes, some drivers of our customers use ioremap_cache to map phy_addr
> which isn't belong to system memory.
Which driver? We should move it over to memremap instead of adding
a new ioremap_cache.
> I agree to use GENERIC_IOREMAP, but I want to add csky support
> GENERIC_IOREMAP patch by myself.
> You could remove "csky: use generic ioremap" in your patchset first
> and I'll add support GENERIC_IORMAP patch later.
> Then we won't get confilct :)
Ok.
next prev parent reply other threads:[~2019-08-18 18:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 11:28 [PATCH] csky: Fixup ioremap function losing guoren
2019-08-15 11:28 ` guoren
2019-08-16 7:03 ` Christoph Hellwig
2019-08-16 7:03 ` Christoph Hellwig
2019-08-18 2:20 ` Guo Ren
2019-08-18 2:20 ` Guo Ren
2019-08-18 18:21 ` Christoph Hellwig [this message]
2019-08-18 18:21 ` Christoph Hellwig
2019-08-20 8:26 ` Guo Ren
2019-08-20 8:26 ` Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190818182118.GA30141@infradead.org \
--to=hch@infradead.org \
--cc=arnd@arndb.de \
--cc=guoren@kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ren_guo@c-sky.com \
--cc=zhang_jian5@dahuatech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox