From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH v8 1/5] mm: untag user pointers in mmap/munmap/mremap/brk Date: Thu, 22 Aug 2019 16:41:25 -0700 Message-ID: <20190822164125.acfb97de912996b2b9127c61@linux-foundation.org> References: <20190815154403.16473-1-catalin.marinas@arm.com> <20190815154403.16473-2-catalin.marinas@arm.com> <20190819162851.tncj4wpwf625ofg6@willie-the-truck> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190819162851.tncj4wpwf625ofg6@willie-the-truck> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Will Deacon Cc: linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, Szabolcs Nagy , Catalin Marinas , Kevin Brodsky , Will Deacon , Dave P Martin , linux-mm@kvack.org, Andrey Konovalov , Vincenzo Frascino , Dave Hansen , linux-arm-kernel@lists.infradead.org List-Id: linux-arch.vger.kernel.org On Mon, 19 Aug 2019 17:28:51 +0100 Will Deacon wrote: > On Thu, Aug 15, 2019 at 04:43:59PM +0100, Catalin Marinas wrote: > > There isn't a good reason to differentiate between the user address > > space layout modification syscalls and the other memory > > permission/attributes ones (e.g. mprotect, madvise) w.r.t. the tagged > > address ABI. Untag the user addresses on entry to these functions. > > > > Signed-off-by: Catalin Marinas > > --- > > mm/mmap.c | 5 +++++ > > mm/mremap.c | 6 +----- > > 2 files changed, 6 insertions(+), 5 deletions(-) > > Acked-by: Will Deacon > > Andrew -- please can you pick this patch up? I'll take the rest of the > series via arm64 once we've finished discussing the wording details. > Sure, I grabbed the patch from the v9 series. But please feel free to include this in the arm64 tree - I'll autodrop my copy if this turns up in linux-next. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:44638 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726591AbfHVXl1 (ORCPT ); Thu, 22 Aug 2019 19:41:27 -0400 Date: Thu, 22 Aug 2019 16:41:25 -0700 From: Andrew Morton Subject: Re: [PATCH v8 1/5] mm: untag user pointers in mmap/munmap/mremap/brk Message-ID: <20190822164125.acfb97de912996b2b9127c61@linux-foundation.org> In-Reply-To: <20190819162851.tncj4wpwf625ofg6@willie-the-truck> References: <20190815154403.16473-1-catalin.marinas@arm.com> <20190815154403.16473-2-catalin.marinas@arm.com> <20190819162851.tncj4wpwf625ofg6@willie-the-truck> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Will Deacon Cc: Catalin Marinas , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, Szabolcs Nagy , Andrey Konovalov , Kevin Brodsky , Will Deacon , Dave Hansen , Vincenzo Frascino , Dave P Martin Message-ID: <20190822234125.iWVtIdeP9IdWPhEwr476mDsT9CAUVG36IwyHXQO5j70@z> On Mon, 19 Aug 2019 17:28:51 +0100 Will Deacon wrote: > On Thu, Aug 15, 2019 at 04:43:59PM +0100, Catalin Marinas wrote: > > There isn't a good reason to differentiate between the user address > > space layout modification syscalls and the other memory > > permission/attributes ones (e.g. mprotect, madvise) w.r.t. the tagged > > address ABI. Untag the user addresses on entry to these functions. > > > > Signed-off-by: Catalin Marinas > > --- > > mm/mmap.c | 5 +++++ > > mm/mremap.c | 6 +----- > > 2 files changed, 6 insertions(+), 5 deletions(-) > > Acked-by: Will Deacon > > Andrew -- please can you pick this patch up? I'll take the rest of the > series via arm64 once we've finished discussing the wording details. > Sure, I grabbed the patch from the v9 series. But please feel free to include this in the arm64 tree - I'll autodrop my copy if this turns up in linux-next.