From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
linux-arch <linux-arch@vger.kernel.org>,
linux-kernel@vger.kernel.org,
Catalin Marinas <catalin.marinas@arm.com>,
rmk+kernel@arm.linux.org.uk, Will Deacon <will@kernel.org>,
Stefan Wahren <wahrenst@gmx.net>
Subject: Re: [PATCH] compiler: enable CONFIG_OPTIMIZE_INLINING forcibly
Date: Fri, 27 Sep 2019 10:59:42 +0000 [thread overview]
Message-ID: <20190927105942.GS10204@ediswmail.ad.cirrus.com> (raw)
In-Reply-To: <f5c221f5749e5768c9f0d909175a14910d349456.camel@suse.de>
On Fri, Sep 27, 2019 at 12:43:33PM +0200, Nicolas Saenz Julienne wrote:
> On Fri, 2019-08-30 at 12:43 +0900, Masahiro Yamada wrote:
> > Commit 9012d011660e ("compiler: allow all arches to enable
> > CONFIG_OPTIMIZE_INLINING") allowed all architectures to enable
> > this option. A couple of build errors were reported by randconfig,
> > but all of them have been ironed out.
> >
> > Towards the goal of removing CONFIG_OPTIMIZE_INLINING entirely
> > (and it will simplify the 'inline' macro in compiler_types.h),
> > this commit changes it to always-on option. Going forward, the
> > compiler will always be allowed to not inline functions marked
> > 'inline'.
> >
> > This is not a problem for x86 since it has been long used by
> > arch/x86/configs/{x86_64,i386}_defconfig.
> >
> > I am keeping the config option just in case any problem crops up for
> > other architectures.
> >
> > The code clean-up will be done after confirming this is solid.
> >
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>
> [ Adding some ARM people as they might be able to help ]
>
> This was found to cause a regression on a Raspberry Pi 2 B built with
> bcm2835_defconfig which among other things has no SMP support.
>
> The relevant logs (edited to remove the noise) are:
>
> [ 5.827333] Run /init as init process
> Loading, please wait...
> Failed to set SO_PASSCRED: Bad address
> Failed to bind netlink socket: Bad address
> Failed to create manager: Bad address
> Failed to set SO_PASSCRED: Bad address
> [ 9.021623] systemd[1]: SO_PASSCRED failed: Bad address
> [!!!!!!] Failed to start up manager.
> [ 9.079148] systemd[1]: Freezing execution.
>
> I looked into it, it turns out that the call to get_user() in sock_setsockopt()
> is returning -EFAULT. Down the assembly rabbit hole that get_user() is I
> found-out that it's the macro 'check_uaccess' who's triggering the error.
>
> I'm clueless at this point, so I hope you can give me some hints on what's
> going bad here.
>
Not sure I can add much in terms of a solution, but I can at
least confirm I am seeing exactly the same issue, on my Zynq
based ARM system.
Thanks,
Charles
next prev parent reply other threads:[~2019-09-27 10:59 UTC|newest]
Thread overview: 98+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 3:43 [PATCH] compiler: enable CONFIG_OPTIMIZE_INLINING forcibly Masahiro Yamada
2019-08-30 3:43 ` Masahiro Yamada
2019-08-30 20:54 ` Nick Desaulniers
2019-08-30 20:54 ` Nick Desaulniers
2019-09-26 8:54 ` Geert Uytterhoeven
2019-09-26 8:54 ` Geert Uytterhoeven
2019-09-26 9:02 ` Masahiro Yamada
2019-09-26 9:02 ` Masahiro Yamada
2019-09-26 9:26 ` Geert Uytterhoeven
2019-09-26 9:26 ` Geert Uytterhoeven
2019-09-26 9:46 ` Masahiro Yamada
2019-09-26 9:46 ` Masahiro Yamada
2019-09-27 10:43 ` Nicolas Saenz Julienne
2019-09-27 10:43 ` Nicolas Saenz Julienne
2019-09-27 10:59 ` Charles Keepax [this message]
2019-09-27 10:59 ` Charles Keepax
2019-09-27 22:08 ` Nick Desaulniers
2019-09-27 22:08 ` Nick Desaulniers
2019-09-27 22:38 ` Linus Torvalds
2019-09-27 22:38 ` Linus Torvalds
2019-09-30 11:26 ` Will Deacon
2019-09-30 11:26 ` Will Deacon
2019-09-30 12:05 ` Masahiro Yamada
2019-09-30 12:05 ` Masahiro Yamada
2019-09-30 12:18 ` Will Deacon
2019-09-30 12:18 ` Will Deacon
2019-09-30 21:50 ` Nick Desaulniers
2019-09-30 21:50 ` Nick Desaulniers
2019-09-30 22:08 ` Miguel Ojeda
2019-09-30 22:08 ` Miguel Ojeda
2019-09-30 22:34 ` Nick Desaulniers
2019-09-30 22:34 ` Nick Desaulniers
2019-10-01 9:28 ` Will Deacon
2019-10-01 9:28 ` Will Deacon
2019-10-01 16:32 ` Nick Desaulniers
2019-10-01 16:32 ` Nick Desaulniers
2019-10-01 17:01 ` Will Deacon
2019-10-01 17:01 ` Will Deacon
2019-10-01 17:44 ` Nick Desaulniers
2019-10-01 17:44 ` Nick Desaulniers
2019-10-01 17:55 ` Russell King - ARM Linux admin
2019-10-01 17:55 ` Russell King - ARM Linux admin
2019-10-01 18:00 ` Nick Desaulniers
2019-10-01 18:00 ` Nick Desaulniers
2019-10-01 18:14 ` Russell King - ARM Linux admin
2019-10-01 18:14 ` Russell King - ARM Linux admin
2019-10-01 20:21 ` Nick Desaulniers
2019-10-01 20:21 ` Nick Desaulniers
2019-10-01 20:53 ` Arnd Bergmann
2019-10-01 20:53 ` Arnd Bergmann
2019-10-01 21:06 ` Miguel Ojeda
2019-10-01 21:06 ` Miguel Ojeda
2019-10-01 21:14 ` Nick Desaulniers
2019-10-01 21:14 ` Nick Desaulniers
2019-10-01 20:59 ` Russell King - ARM Linux admin
2019-10-01 20:59 ` Russell King - ARM Linux admin
2019-10-01 21:26 ` Russell King - ARM Linux admin
2019-10-01 21:26 ` Russell King - ARM Linux admin
2019-10-01 21:32 ` Nick Desaulniers
2019-10-01 21:32 ` Nick Desaulniers
2019-10-01 21:58 ` Russell King - ARM Linux admin
2019-10-01 21:58 ` Russell King - ARM Linux admin
2019-10-02 12:55 ` Geert Uytterhoeven
2019-10-02 12:55 ` Geert Uytterhoeven
2019-10-02 18:51 ` Will Deacon
2019-10-02 18:51 ` Will Deacon
2019-10-02 20:39 ` Linus Torvalds
2019-10-02 20:39 ` Linus Torvalds
2019-10-03 2:10 ` Masahiro Yamada
2019-10-03 2:10 ` Masahiro Yamada
2019-10-03 17:01 ` Linus Torvalds
2019-10-03 17:01 ` Linus Torvalds
2019-10-03 17:08 ` Linus Torvalds
2019-10-03 17:08 ` Linus Torvalds
2019-10-03 17:23 ` Masahiro Yamada
2019-10-03 17:23 ` Masahiro Yamada
2019-10-03 17:29 ` Linus Torvalds
2019-10-03 17:29 ` Linus Torvalds
2019-10-03 20:21 ` Miguel Ojeda
2019-10-03 20:21 ` Miguel Ojeda
2019-10-04 7:37 ` Geert Uytterhoeven
2019-10-04 7:37 ` Geert Uytterhoeven
2019-10-03 16:36 ` Will Deacon
2019-10-03 16:36 ` Will Deacon
2019-10-12 10:15 ` Stefan Wahren
2019-10-12 10:15 ` Stefan Wahren
2019-10-12 11:12 ` Masahiro Yamada
2019-10-12 11:12 ` Masahiro Yamada
2019-10-12 14:45 ` Russell King - ARM Linux admin
2019-10-12 14:45 ` Russell King - ARM Linux admin
2019-10-01 9:39 ` Masahiro Yamada
2019-10-01 9:39 ` Masahiro Yamada
2019-10-01 10:40 ` Will Deacon
2019-10-01 10:40 ` Will Deacon
2019-09-27 10:58 ` Nicolas Saenz Julienne
2019-09-27 10:58 ` Nicolas Saenz Julienne
2019-09-30 6:04 ` Masahiro Yamada
2019-09-30 6:04 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190927105942.GS10204@ediswmail.ad.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=mingo@redhat.com \
--cc=ndesaulniers@google.com \
--cc=nsaenzjulienne@suse.de \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=torvalds@linux-foundation.org \
--cc=wahrenst@gmx.net \
--cc=will@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox